public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove unnecessary if statement 

Signed-off-by: Anton Bretting <sajfer@gmail.com>
This commit is contained in:
Anton Bretting 2022-06-11 17:24:13 +02:00 committed by Yusuke Kuoka
parent c6e8afd3d0
commit eb2419aa15
1 changed files with 15 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pkg/app/app.go
View File

@ -1326,7 +1326,6 @@ func (a *App) apply(r *Run, c ApplyConfigProvider) (bool, bool, []error) {
var releasesWithPreApply []state.ReleaseSpec
for _, r := range toApplyWithNeeds {
release := r
if len(release.Hooks) > 0 {
for _, hook := range release.Hooks {
if slices.Contains(hook.Events, "preapply") {
releasesWithPreApply = append(releasesWithPreApply, release)
@ -1334,19 +1333,18 @@ func (a *App) apply(r *Run, c ApplyConfigProvider) (bool, bool, []error) {
}
}
}
}
if len(releasesWithPreApply) > 0 {
msg := "Releases with preapply hooks: \n"
if infoMsg != nil {
msg = fmt.Sprintf("%s%s", *infoMsg, msg)
}
infoMsg = &msg
}
for _, release := range releasesWithPreApply {
tmp := fmt.Sprintf("%s %s (%s)", *infoMsg, release.Name, release.Chart)
infoMsg = &tmp
}
// if len(releasesWithPreApply) > 0 {
// msg := "Releases with preapply hooks: \n"
// if infoMsg != nil {
// msg = fmt.Sprintf("%s%s", *infoMsg, msg)
// }
// infoMsg = &msg
// }
// for _, release := range releasesWithPreApply {
// tmp := fmt.Sprintf("%s %s (%s)", *infoMsg, release.Name, release.Chart)
// infoMsg = &tmp
// }
if releasesToBeDeleted == nil && releasesToBeUpdated == nil && releasesWithPreApply == nil {
if infoMsg != nil {