public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #46 from mseashor/master 

Synchronous add repository calls avoid helm add repo race conditions
This commit is contained in:
KUOKA Yusuke 2018-03-06 11:23:35 +09:00 committed by GitHub
parent 8f607b0da7 412d9244c8
commit e4961a8c34
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
state/state.go
View File

@ -124,19 +124,13 @@ func (state *HelmState) applyDefaultsTo(spec ReleaseSpec) ReleaseSpec {
}
func (state *HelmState) SyncRepos(helm helmexec.Interface) []error {
var wg sync.WaitGroup
errs := []error{}
for _, repo := range state.Repositories {
wg.Add(1)
go func(wg *sync.WaitGroup, name, url string) {
if err := helm.AddRepo(name, url); err != nil {
if err := helm.AddRepo(repo.Name, repo.URL); err != nil {
errs = append(errs, err)
}
wg.Done()
}(&wg, repo.Name, repo.URL)
}
wg.Wait()
if len(errs) != 0 {
return errs