test: add integration test for issue #2291 (CRD preservation with strategicMergePatches) (#2292)

mirror of https://github.com/helmfile/helmfile.git synced 2026-10-06 05:11:28 +02:00

* test: add integration test for issue #2291 with all fixes

Add comprehensive integration test for issue #2291 that validates CRD
preservation when using strategicMergePatches with chartify.

Problem:
When using strategicMergePatches, chartify was relocating CRDs from
templates/crds/ to root crds/ directory, changing how Helm manages them.
This caused helm diff to incorrectly show CRDs as being removed, even
though they were still present.

Solution:
Chartify now preserves the original CRD location in templates/crds/.
This integration test validates the fix by:
1. Templating a chart with CRDs in templates/crds/
2. Applying the chart with strategicMergePatches
3. Verifying CRD is installed
4. Running helm diff to ensure CRD is NOT marked for removal
5. Verifying the strategic merge patch was applied

Additional fixes included in this commit:
- Fixed grep command error when matching YAML deletion patterns
- Updated expected test output for Helm 4 diff behavior
- Fixed EXIT trap interference between test cases
- Added --plain-http flag for Helm 4 OCI registry compatibility
- Ensured CRD templates are valid (cluster-scoped, no namespace)
- Fixed strategic merge patch namespace matching

Test coverage:
- CRD preservation in templates/crds/ subdirectory
- Strategic merge patch application
- Helm diff behavior with CRDs
- Integration with chartify kustomize processing

Fixes #2291

Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>

* switch chartify package to upstream one

Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>

* implement copilot suggestion

Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>

---------

Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>

This commit is contained in:

Aditya Menon

2025-11-25 09:19:41 +08:00

committed by

GitHub

parent 83b4a8ffc7

commit d40bfced56

12 changed files with 239 additions and 12 deletions

									
										go.mod
									
		+1
		-1
	
												View File
												
				@@ -15,7 +15,7 @@ require (

					github.com/gosuri/uitable v0.0.4

					github.com/hashicorp/go-getter v1.8.3

					github.com/hashicorp/hcl/v2 v2.24.0

					github.com/helmfile/chartify v0.26.0

					github.com/helmfile/chartify v0.26.1

					github.com/helmfile/vals v0.42.6

					github.com/spf13/cobra v1.10.1

					github.com/spf13/pflag v1.0.10