mirror of
https://github.com/helmfile/helmfile.git
synced 2026-10-18 05:40:40 +02:00
* Add integration tests for #1749 Signed-off-by: Matthias Baur <m.baur@syseleven.de> * Reset extra args on a higher level to only affect subsequent helmfiles With the implementation before, extra args has been reset after each helm.exec which leads to problems with multiple charts in a helmfile since the correct args are only set once in Template(). But Template() calls helm.exec(template) multiple times. Signed-off-by: Matthias Baur <m.baur@syseleven.de> --------- Signed-off-by: Matthias Baur <m.baur@syseleven.de>
This commit is contained in:
@@ -1439,6 +1439,11 @@ func (st *HelmState) runHelmDepBuilds(helm helmexec.Interface, concurrency int,
|
||||
// So we shouldn't use goroutines like we do for other helm operations here.
|
||||
//
|
||||
// See https://github.com/roboll/helmfile/issues/1521
|
||||
|
||||
// Reset helm extra args to not pollute BuildDeps() on subsequent helmfiles
|
||||
// https://github.com/helmfile/helmfile/issues/1749
|
||||
helm.SetExtraArgs()
|
||||
|
||||
for _, r := range builds {
|
||||
buildDepsFlags := getBuildDepsFlags(r)
|
||||
if err := helm.BuildDeps(r.releaseName, r.chartPath, buildDepsFlags...); err != nil {
|
||||
|
||||
Reference in New Issue
Block a user