fix: nested helmfile values should replace arrays, not merge element-by-element (#2458)

mirror of https://github.com/helmfile/helmfile.git synced 2026-10-18 06:40:31 +02:00

PR #2367 introduced CLIOverrides to give --state-values-set element-by-element
array merge semantics. However, nested helmfile values (helmfiles[].values:)
were also routed into CLIOverrides, causing their arrays to merge instead of
replace. This broke the pre-v1.3.0 behavior where passing an array via
helmfiles[].values: would fully replace the child's default array.

Add OverrideValuesAreCLI flag to SubhelmfileEnvironmentSpec so the loader can
distinguish CLI flags from nested helmfile values. CLI values continue using
CLIOverrides (element-by-element merge); nested helmfile values now use Values
(Sparse merge strategy → full array replacement).

Fixes #2451

Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>

This commit is contained in:

Aditya Menon

2026-03-09 18:31:21 +08:00

committed by

GitHub

parent 26646ebd31

commit c375b48550

11 changed files with 75 additions and 4 deletions

									
										test/integration/test-cases/issue-2451-nested-helmfile-array-replace/output/output.yaml
									
		+7
		
												View File
												
				@@ -0,0 +1,7 @@

				---

				# Source: raw/templates/resources.yaml

				---

				apiVersion: v1

				kind: ConfigMap

				metadata:

				  name: override1