public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

feat: Automatically update repos on diffing by default (#462) 

Resolves #452
This commit is contained in:
KUOKA Yusuke 2019-02-04 11:12:34 +09:00 committed by GitHub
parent fb256b0161
commit b894012c80
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
main.go
View File

@ -170,7 +170,11 @@ func main() {
}, },
cli.BoolFlag{ cli.BoolFlag{
Name: "sync-repos", Name: "sync-repos",
Usage: "enable a repo sync prior to diffing", Usage: "DEPRECATED",
},
cli.BoolFlag{
Name: "skip-repo-update",
Usage: "skip running `helm repo update` on repositories declared in helmfile",
}, },
cli.BoolFlag{ cli.BoolFlag{
Name: "detailed-exitcode", Name: "detailed-exitcode",
@ -188,7 +192,10 @@ func main() {
}, },
Action: func(c *cli.Context) error { Action: func(c *cli.Context) error {
return findAndIterateOverDesiredStatesUsingFlags(c, func(state *state.HelmState, helm helmexec.Interface, ctx context) []error { return findAndIterateOverDesiredStatesUsingFlags(c, func(state *state.HelmState, helm helmexec.Interface, ctx context) []error {
if c.Bool("sync-repos") { if !c.Bool("skip-repo-update") {
if c.Bool("sync-repos") {
logger.Warnf("--sync-repos has been removed and `helmfile diff` updates repositories by default. Provide `--skip-repo-update` to opt-out.")
}
if errs := ctx.SyncReposOnce(state, helm); errs != nil && len(errs) > 0 { if errs := ctx.SyncReposOnce(state, helm); errs != nil && len(errs) > 0 {
return errs return errs
} }