public_git/helmfile
1
0
Fork 0
mirror of https://github.com/helmfile/helmfile.git synced 2026-09-30 07:20:52 +02:00
Code Issues Projects Releases Wiki Activity

Create DeleteWait and DeleteTimeout parameters for Destroy (#1177)

Browse Source 
* Create DeleteWait and DeleteTimeout parameters

Signed-off-by: Virginia Tavares <briosovirginia@gmail.com>

* Create tests for deleteWait and deleteTimeout

Signed-off-by: Virginia Tavares <briosovirginia@gmail.com>

* build(deps): bump github.com/aws/aws-sdk-go from 1.48.6 to 1.48.7 (#1176)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.48.6 to 1.48.7.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.48.6...v1.48.7)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update temp_test.go with DeleteWait and DeleteTimeout

Signed-off-by: Virginia Tavares <briosovirginia@gmail.com>

* Create deleteWait function in state.go

Signed-off-by: Virginia Tavares <briosovirginia@gmail.com>

* Fix comments from review

Signed-off-by: Virginia Tavares <briosovirginia@gmail.com>

---------

Signed-off-by: Virginia Tavares <briosovirginia@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Virginia Tavares <virginia.tavares@ericsson.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This commit is contained in:
Virgínia Tavares
2023-12-05 08:38:37 +08:00
committed by GitHub
co-authored by dependabot[bot] Virginia Tavares
parent 4659b2fdd8
commit b10692dc9b
12 changed files with 157 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/config/delete.go
+14
View File
@@ -11,6 +11,10 @@ type DeleteOptions struct {
SkipCharts bool
// Cascade '--cascade' to helmv3 delete, available values: background, foreground, or orphan, default: background
Cascade string
// Wait '--wait' if set, will wait until all the resources are deleted before returning. It will wait for as long as --timeout
DeleteWait bool
// Timeout '--timeout', to wait for helm delete operation (default 5m0s)
DeleteTimeout int
}
// NewDeleteOptions creates a new Apply
@@ -51,3 +55,13 @@ func (c *DeleteImpl) SkipCharts() bool {
func (c *DeleteImpl) Cascade() string {
return c.DeleteOptions.Cascade
}
// DeleteWait returns the wait flag
func (c *DeleteImpl) DeleteWait() bool {
return c.DeleteOptions.DeleteWait
}
// DeleteTimeout returns the timeout flag
func (c *DeleteImpl) DeleteTimeout() int {
return c.DeleteOptions.DeleteTimeout
}
pkg/config/destroy.go
+14
View File
@@ -8,6 +8,10 @@ type DestroyOptions struct {
SkipCharts bool
// Cascade '--cascade' to helmv3 delete, available values: background, foreground, or orphan, default: background
Cascade string
// Wait '--wait' if set, will wait until all the resources are destroyed before returning. It will wait for as long as --timeout
DeleteWait bool
// Timeout '--timeout', to wait for helm operation (default 5m0s)
DeleteTimeout int
}
// NewDestroyOptions creates a new Apply
@@ -43,3 +47,13 @@ func (c *DestroyImpl) SkipCharts() bool {
func (c *DestroyImpl) Cascade() string {
return c.DestroyOptions.Cascade
}
// DeleteWait returns the wait flag
func (c *DestroyImpl) DeleteWait() bool {
return c.DestroyOptions.DeleteWait
}
// DeleteTimeout returns the timeout flag
func (c *DestroyImpl) DeleteTimeout() int {
return c.DestroyOptions.DeleteTimeout
}