From b0827faf54a5a50bb115f5f8dab41b00f993a0fe Mon Sep 17 00:00:00 2001 From: yxxhero Date: Wed, 11 Mar 2026 00:28:22 +0800 Subject: [PATCH] fix: lint issues - Fix QF1016 in helmexec/exec.go: use fmt.Fprintf instead of Write([]byte(fmt.Sprintf())) - Remove unused allReleases parameter from collectDirectNeeds Signed-off-by: yxxhero (cherry picked from commit 4a6996c014d71299bb5b070f581a7f421a634727) Signed-off-by: yxxhero --- pkg/helmexec/exec.go | 2 +- pkg/state/state.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/helmexec/exec.go b/pkg/helmexec/exec.go index 4b061266..5283ad84 100644 --- a/pkg/helmexec/exec.go +++ b/pkg/helmexec/exec.go @@ -256,7 +256,7 @@ func (helm *execer) AddRepo(name, repository, cafile, certfile, keyfile, usernam if username != "" && password != "" { args = append(args, "--username", username, "--password-stdin") buffer := bytes.Buffer{} - buffer.Write([]byte(fmt.Sprintf("%s\n", password))) + fmt.Fprintf(&buffer, "%s\n", password) out, err = helm.execStdIn(args, map[string]string{}, &buffer) } else { out, err = helm.exec(args, map[string]string{}, nil) diff --git a/pkg/state/state.go b/pkg/state/state.go index ece35a8d..8561525a 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -3056,7 +3056,7 @@ func unmarkDirectNeeds(filteredReleases []Release, allReleases []ReleaseSpec) { unmarkReleases(directNeeds, filteredReleases) } -func collectDirectNeeds(filteredReleases []Release, allReleases []ReleaseSpec) map[string]struct{} { +func collectDirectNeeds(filteredReleases []Release, _ []ReleaseSpec) map[string]struct{} { directNeeds := map[string]struct{}{} for _, r := range filteredReleases { if !r.Filtered {