mirror of
https://github.com/helmfile/helmfile.git
synced 2026-10-22 09:06:29 +02:00
fix: helmDefaults.skipRefresh ignored in runHelmDepBuilds (#2415)
fix: helmDefaults.skipRefresh ignored in runHelmDepBuilds (#2269) `runHelmDepBuilds()` only checked the CLI flag (`opts.SkipRefresh`) when deciding whether to run `helm repo update` before building dependencies. This meant that setting `helmDefaults.skipRefresh: true` in helmfile.yaml had no effect on the repo update call inside dep builds. Add `!st.HelmDefaults.SkipRefresh` to the guard condition so that `helmDefaults.skipRefresh: true` is respected alongside the CLI flag. Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
This commit is contained in:
@@ -0,0 +1,4 @@
|
||||
apiVersion: v2
|
||||
name: test-chart-2269
|
||||
version: 0.1.0
|
||||
description: Minimal chart for issue #2269 integration test
|
||||
@@ -0,0 +1,6 @@
|
||||
apiVersion: v1
|
||||
kind: ConfigMap
|
||||
metadata:
|
||||
name: test-2269
|
||||
data:
|
||||
key: value
|
||||
@@ -0,0 +1,13 @@
|
||||
# Issue #2269: helmDefaults.skipDeps and helmDefaults.skipRefresh should prevent
|
||||
# repo operations (Adding repo, helm repo update) without needing CLI flags.
|
||||
repositories:
|
||||
- name: fake-repo
|
||||
url: https://fake-repo.example.com
|
||||
|
||||
helmDefaults:
|
||||
skipDeps: true
|
||||
skipRefresh: true
|
||||
|
||||
releases:
|
||||
- name: test-release-2269
|
||||
chart: ./chart
|
||||
Reference in New Issue
Block a user