From a2c62c9e73340785f24557b26b8da97925fdb69b Mon Sep 17 00:00:00 2001 From: KUOKA Yusuke Date: Sat, 4 Apr 2020 15:32:22 +0900 Subject: [PATCH] feat: Emit clear error message instead of panic on empty chart name (#1171) Resolves #999 --- pkg/app/desired_state_file_loader.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/app/desired_state_file_loader.go b/pkg/app/desired_state_file_loader.go index ad00cb10..aa7fed60 100644 --- a/pkg/app/desired_state_file_loader.go +++ b/pkg/app/desired_state_file_loader.go @@ -207,6 +207,12 @@ func (ld *desiredStateLoader) renderAndLoad(env, overrodeEnv *environment.Enviro return nil, err } + for i, r := range currentState.Releases { + if r.Chart == "" { + return nil, fmt.Errorf("error during %s parsing: encountered empty chart while reading release %q at index %d", id, r.Name, i) + } + } + if finalState == nil { finalState = currentState } else {