public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix test command for helm 3 (#1080)

This commit is contained in:
Christoph Hösler 2020-02-03 00:41:38 +01:00 committed by GitHub
parent c8ba676e19
commit 9fab6851f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/app/app.go
View File

@ -168,6 +168,11 @@ func (a *App) Destroy(c DestroyConfigProvider) error {
} }
func (a *App) Test(c TestConfigProvider) error { func (a *App) Test(c TestConfigProvider) error {
if c.Cleanup() && a.helmExecer.IsHelm3() {
a.Logger.Warnf("warn: requested cleanup will not be applied. " +
"To clean up test resources with Helm 3, you have to remove them manually " +
"or set helm.sh/hook-delete-policy\n")
}
return a.ForEachStateFiltered(func(run *Run) []error { return a.ForEachStateFiltered(func(run *Run) []error {
return run.Test(c) return run.Test(c)
}) })

5
pkg/state/state.go
View File

@ -1206,7 +1206,10 @@ func (st *HelmState) TestReleases(helm helmexec.Interface, cleanup bool, timeout
} }
flags := []string{} flags := []string{}
if cleanup { if helm.IsHelm3() && release.Namespace != "" {
flags = append(flags, "--namespace", release.Namespace)
}
if cleanup && !helm.IsHelm3() {
flags = append(flags, "--cleanup") flags = append(flags, "--cleanup")
} }
duration := strconv.Itoa(timeout) duration := strconv.Itoa(timeout)