From 8f44f12f0769e80f7408b654cdc981f7e875c887 Mon Sep 17 00:00:00 2001 From: Zubair Haque Date: Sat, 27 Jul 2024 23:34:27 -0400 Subject: [PATCH] chore: remove unecessary check in HandleExitCoder function and streamline logic (#1646) * rm unecessary check and streamline logic Signed-off-by: zhaque44 * rm else and addressing PR comments Signed-off-by: zhaque44 --------- Signed-off-by: zhaque44 --- pkg/errors/errors.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/errors/errors.go b/pkg/errors/errors.go index 0d17a116..2372e2b0 100644 --- a/pkg/errors/errors.go +++ b/pkg/errors/errors.go @@ -84,14 +84,13 @@ func HandleExitCoder(err error) { } if exitErr, ok := err.(ExitCoder); ok { - if err.Error() != "" { - fmt.Fprintln(ErrWriter, err) + if errMsg := err.Error(); errMsg != "" { + fmt.Fprintln(ErrWriter, errMsg) } OsExiter(exitErr.ExitCode()) return } - // unknown error exit with code 3 - fmt.Fprintln(ErrWriter, err) + fmt.Fprintln(ErrWriter, err) OsExiter(3) }