From 8ed8a9eab3344ac2d25783b7ce2314fbe2043c37 Mon Sep 17 00:00:00 2001 From: kupnu4x Date: Tue, 9 Mar 2021 09:23:36 +0800 Subject: [PATCH] allow to access oci repos without auth (#1711) * allow to access oci repos without auth Co-authored-by: Yusuke Kuoka --- pkg/state/state.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/state/state.go b/pkg/state/state.go index 2b4974b9..de690df6 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -385,10 +385,9 @@ func (st *HelmState) SyncRepos(helm RepoUpdater, shouldSkip map[string]bool) ([] var err error if repo.OCI { username, password := gatherOCIUsernamePassword(repo.Name, repo.Username, repo.Password) - if username == "" || password == "" { - return nil, fmt.Errorf("username and password are required fields for logging in to OCI registries with helm") + if username != "" && password != "" { + err = helm.RegistryLogin(repo.URL, username, password) } - err = helm.RegistryLogin(repo.URL, username, password) } else { err = helm.AddRepo(repo.Name, repo.URL, repo.CaFile, repo.CertFile, repo.KeyFile, repo.Username, repo.Password, repo.Managed) }