public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: Make the forbid-env-with-releases policy strict on v1 (#683) 

Currently, both v0 and v1 warns any usage of environments with releases within the same helmfile part.

It should rather be an error for v1, as proposed in https://github.com/helmfile/helmfile/blob/main/docs/proposals/towards-1.0.md#forbid-the-use-of-environments-and-releases-within-a-single-helmfileyaml-part.

Follow-up for #592

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
This commit is contained in:
Yusuke Kuoka 2023-02-08 10:09:12 +09:00 committed by GitHub
parent fc027d1538
commit 8c130a4fa7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/policy/checker.go
View File

@ -3,6 +3,8 @@ package policy
import ( import (
"errors" "errors"
"github.com/helmfile/helmfile/pkg/runtime"
) )
var ( var (
@ -17,7 +19,7 @@ func forbidEnvironmentsWithReleases(releaseState map[string]interface{}) (bool,
_, hasEnvironments := releaseState["environments"] _, hasEnvironments := releaseState["environments"]
_, hasReleases := releaseState["releases"] _, hasReleases := releaseState["releases"]
if hasEnvironments && hasReleases { if hasEnvironments && hasReleases {
return false, EnvironmentsAndReleasesWithinSameYamlPartErr return runtime.V1Mode, EnvironmentsAndReleasesWithinSameYamlPartErr
} }
return false, nil return false, nil
} }