skip helm dep up for kustomizations (#1424)

skip helm dep up deps for kustomizations

Signed-off-by: Cyril Jouve <jv.cyril@gmail.com>

pkg/state/state.go

@@ -2465,12 +2465,14 @@ func (st *HelmState) UpdateDeps(helm helmexec.Interface, includeTransitiveNeeds
 	var errs []error
 
 	for _, release := range releases {
-		if st.fs.DirectoryExistsAt(release.ChartPathOrName()) {
+		if !st.fs.DirectoryExistsAt(release.ChartPathOrName()) {
+			st.logger.Debugf("skipped updating dependencies for remote chart %s", release.Chart)
+		} else if !st.fs.FileExistsAt(filepath.Join(release.ChartPathOrName(), "Chart.yaml")) {
+			st.logger.Debugf("skipped updating dependencies for %s as it does not have a Chart.yaml", release.Chart)
+		} else {
 			if err := helm.UpdateDeps(release.ChartPathOrName()); err != nil {
 				errs = append(errs, err)
 			}
-		} else {
-			st.logger.Debugf("skipped updating dependencies for remote chart %s", release.Chart)
 		}
 	}
 

test/integration/run.sh

@@ -93,6 +93,7 @@ ${kubectl} create namespace ${test_ns} || fail "Could not create namespace ${tes
 . ${dir}/test-cases/postrender.sh
 . ${dir}/test-cases/chartify.sh
 . ${dir}/test-cases/deps-mr-1011.sh
+. ${dir}/test-cases/deps-kustomization-i-1402.sh
 
 # ALL DONE -----------------------------------------------------------------------------------------------------------
 

test/integration/test-cases/deps-kustomization-i-1402.sh

@@ -0,0 +1,9 @@
+deps_kustomization_i_1402="${cases_dir}/deps-kustomization-i-1402/input"
+
+config_file="helmfile.yaml"
+
+test_start "helmfile deps nonreg for #1402"
+
+${helmfile} -f ${deps_kustomization_i_1402}/${config_file} deps || fail "\"helmfile deps\" shouldn't fail"
+
+test_pass "helmfile deps nonreg for #1402"

test/integration/test-cases/deps-kustomization-i-1402/input/helmfile.yaml

@@ -0,0 +1,9 @@
+repositories:
+  # Only required because helmfile deps doesn't execute without them
+  - name: ingress-nginx
+    url: https://kubernetes.github.io/ingress-nginx
+
+releases:
+  - name: test
+    chart: ./test
+

test/integration/test-cases/deps-kustomization-i-1402/input/test/kustomization.yaml

@@ -0,0 +1,2 @@
+resources:
+  - test.yml

test/integration/test-cases/deps-kustomization-i-1402/input/test/test.yml

@@ -0,0 +1,10 @@
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  name: test
+spec:
+  accessModes:
+    - ReadWriteMany
+  resources:
+    requests:
+      storage: 1G