Use cobra (#234)

switch to cobra

Signed-off-by: yxxhero <aiopsclub@163.com>

cmd/apply.go

@@ -3,113 +3,56 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addApplySubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "apply",
-		Usage: "apply all resources from state file only when there are changes",
-		Flags: []cli.Flag{
-			cli.StringSliceFlag{
-				Name:  "set",
-				Usage: "additional values to be merged into the command",
-			},
-			cli.StringSliceFlag{
-				Name:  "values",
-				Usage: "additional value files to be merged into the command",
-			},
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent helm processes to run, 0 is unlimited",
-			},
-			cli.BoolFlag{
-				Name:  "validate",
-				Usage: "validate your manifests against the Kubernetes cluster you are currently pointing at. Note that this requires access to a Kubernetes cluster to obtain information necessary for validating, like the list of available API versions",
-			},
-			cli.IntFlag{
-				Name:  "context",
-				Value: 0,
-				Usage: "output NUM lines of context around changes",
-			},
-			cli.StringFlag{
-				Name:  "output",
-				Value: "",
-				Usage: "output format for diff plugin",
-			},
-			cli.BoolFlag{
-				Name:  "detailed-exitcode",
-				Usage: "return a non-zero exit code 2 instead of 0 when there were changes detected AND the changes are synced successfully",
-			},
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
-			cli.BoolFlag{
-				Name:  "retain-values-files",
-				Usage: "DEPRECATED: Use skip-cleanup instead",
-			},
-			cli.BoolFlag{
-				Name:  "skip-cleanup",
-				Usage: "Stop cleaning up temporary values generated by helmfile and helm-secrets. Useful for debugging. Don't use in production for security",
-			},
-			cli.BoolFlag{
-				Name:  "skip-crds",
-				Usage: "if set, no CRDs will be installed on sync. By default, CRDs are installed if not already present",
-			},
-			cli.BoolTFlag{
-				Name:  "skip-needs",
-				Usage: `do not automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided. Defaults to true when --include-needs or --include-transitive-needs is not provided`,
-			},
-			cli.BoolFlag{
-				Name:  "include-needs",
-				Usage: `automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided`,
-			},
-			cli.BoolFlag{
-				Name:  "include-transitive-needs",
-				Usage: `like --include-needs, but also includes transitive needs (needs of needs). Does nothing when when --selector/-l flag is not provided. Overrides exclusions of other selectors and conditions.`,
-			},
-			cli.BoolFlag{
-				Name:  "skip-diff-on-install",
-				Usage: "Skips running helm-diff on releases being newly installed on this apply. Useful when the release manifests are too huge to be reviewed, or it's too time-consuming to diff at all",
-			},
-			cli.BoolFlag{
-				Name:  "include-tests",
-				Usage: "enable the diffing of the helm test hooks",
-			},
-			cli.StringSliceFlag{
-				Name:  "suppress",
-				Usage: "suppress specified Kubernetes objects in the diff output. Can be provided multiple times. For example: --suppress KeycloakClient --suppress VaultSecret",
-			},
-			cli.BoolFlag{
-				Name:  "suppress-secrets",
-				Usage: "suppress secrets in the diff output. highly recommended to specify on CI/CD use-cases",
-			},
-			cli.BoolFlag{
-				Name:  "show-secrets",
-				Usage: "do not redact secret values in the diff output. should be used for debug purpose only",
-			},
-			cli.BoolFlag{
-				Name:  "suppress-diff",
-				Usage: "suppress diff in the output. Usable in new installs",
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
-			cli.BoolFlag{
-				Name:  "wait",
-				Usage: `Override helmDefaults.wait setting "helm upgrade --install --wait"`,
-			},
-			cli.BoolFlag{
-				Name:  "wait-for-jobs",
-				Usage: `Override helmDefaults.waitForJobs setting "helm upgrade --install --wait-for-jobs"`,
-			},
+// NewApplyCmd returm apply subcmd
+func NewApplyCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	applyOptions := &config.ApplyOptions{}
+	applyImpl := config.NewApplyImpl(globalCfg, applyOptions)
+
+	cmd := &cobra.Command{
+		Use:   "apply",
+		Short: "Apply all resources from state file only when there are changes",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(applyImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := applyImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(applyImpl)
+			return toCLIError(applyImpl.GlobalImpl, a.Apply(applyImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Apply(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringSliceVar(&applyImpl.ApplyOptions.Set, "selector", []string{}, "additional values to be merged into the command")
+	f.StringSliceVar(&applyImpl.ApplyOptions.Values, "values", []string{}, "additional value files to be merged into the command")
+	f.IntVar(&applyImpl.ApplyOptions.Concurrency, "concurrency", 0, "maximum number of concurrent helm processes to run, 0 is unlimited")
+	f.BoolVar(&applyImpl.ApplyOptions.Validate, "validate", false, "validate your manifests against the Kubernetes cluster you are currently pointing at. Note that this requires access to a Kubernetes cluster to obtain information necessary for validating, like the list of available API versions")
+	f.IntVar(&applyImpl.ApplyOptions.Context, "context", 0, "output NUM lines of context around changes")
+	f.StringVar(&applyImpl.ApplyOptions.Output, "output", "", "output format for diff plugin")
+	f.BoolVar(&applyImpl.ApplyOptions.DetailedExitcode, "detailed-exitcode", false, "return a non-zero exit code 2 instead of 0 when there were changes detected AND the changes are synced successfully")
+	f.StringVar(&applyImpl.ApplyOptions.Args, "args", "", "pass args to helm exec")
+	f.BoolVar(&applyImpl.ApplyOptions.RetainValuesFiles, "retain-values-files", false, "DEPRECATED: Use skip-cleanup instead")
+	f.BoolVar(&applyImpl.ApplyOptions.SkipCleanup, "skip-cleanup", false, "Stop cleaning up temporary values generated by helmfile and helm-secrets. Useful for debugging. Don't use in production for security")
+	f.BoolVar(&applyImpl.ApplyOptions.SkipCRDs, "skip-crds", false, "if set, no CRDs will be installed on sync. By default, CRDs are installed if not already present")
+	f.BoolVar(&applyImpl.ApplyOptions.SkipNeeds, "skip-needs", false, `do not automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided. Defaults to true when --include-needs or --include-transitive-needs is not provided`)
+	f.BoolVar(&applyImpl.ApplyOptions.IncludeNeeds, "include-needs", false, `automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided`)
+	f.BoolVar(&applyImpl.ApplyOptions.IncludeTransitiveNeeds, "include-transitive-needs", false, `like --include-needs, but also includes transitive needs (needs of needs). Does nothing when when --selector/-l flag is not provided. Overrides exclusions of other selectors and conditions.`)
+	f.BoolVar(&applyImpl.ApplyOptions.SkipDiffOnInstall, "skip-diff-on-install", false, "Skips running helm-diff on releases being newly installed on this apply. Useful when the release manifests are too huge to be reviewed, or it's too time-consuming to diff at all0")
+	f.BoolVar(&applyImpl.ApplyOptions.IncludeTests, "include-tests", false, "enable the diffing of the helm test hooks")
+	f.StringArrayVar(&applyImpl.ApplyOptions.Suppress, "suppress", []string{}, "suppress specified Kubernetes objects in the diff output. Can be provided multiple times. For example: --suppress KeycloakClient --suppress VaultSecret")
+	f.BoolVar(&applyImpl.ApplyOptions.SuppressSecrets, "suppress-secrets", false, "suppress secrets in the diff output. highly recommended to specify on CI/CD use-cases")
+	f.BoolVar(&applyImpl.ApplyOptions.ShowSecrets, "show-secrets", false, "do not redact secret values in the diff output. should be used for debug purpose only")
+	f.BoolVar(&applyImpl.ApplyOptions.SuppressDiff, "suppress-diff", false, "suppress diff in the output. Usable in new installs")
+	f.BoolVar(&applyImpl.ApplyOptions.SkipDeps, "skip-deps", false, `skip running "helm repo update" and "helm dependency build"`)
+	f.Bool("wait", false, `Override helmDefaults.wait setting "helm upgrade --install --wait"`)
+	f.Bool("wait-for-jobs", false, `Override helmDefaults.waitForJobs setting "helm upgrade --install --wait-for-jobs"`)
+
+	return cmd
 }

cmd/build.go

@@ -3,21 +3,34 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addBuildSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "build",
-		Usage: "output compiled helmfile state(s) as YAML",
-		Flags: []cli.Flag{
-			cli.BoolFlag{
-				Name:  "embed-values",
-				Usage: "Read all the values files for every release and embed into the output helmfile.yaml",
-			},
+// NewBuildCmd returm build subcmd
+func NewBuildCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	buildOptions := config.NewBuildOptions()
+	buildImpl := config.NewBuildImpl(globalCfg, buildOptions)
+
+	cmd := &cobra.Command{
+		Use:   "build",
+		Short: "Build all resources from state file only when there are changes",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(buildImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := buildImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(buildImpl)
+			return toCLIError(buildImpl.GlobalImpl, a.PrintState(buildImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.PrintState(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.BoolVar(&buildOptions.EmbedValues, "embed-values", false, "Read all the values files for every release and embed into the output helmfile.yaml")
+
+	return cmd
 }

cmd/cache.go

@@ -3,33 +3,66 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-var cacheInfoSubcommand = cli.Command{
-	Name:  "info",
-	Usage: "cache info",
-	Action: Action(func(a *app.App, c config.ConfigImpl) error {
-		return a.ShowCacheDir(c)
-	}),
-}
+func NewCacheInfoSubcommand(cacheImpl *config.CacheImpl) *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "info",
+		Short: "cache info",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(cacheImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
 
-var cacheCleanupSubcommand = cli.Command{
-	Name:  "cleanup",
-	Usage: "clean up cache directory",
-	Action: Action(func(a *app.App, c config.ConfigImpl) error {
-		return a.CleanCacheDir(c)
-	}),
-}
+			if err := cacheImpl.ValidateConfig(); err != nil {
+				return err
+			}
 
-func addCacheSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:      "cache",
-		Usage:     "cache management",
-		ArgsUsage: "[command]",
-		Subcommands: []cli.Command{
-			cacheCleanupSubcommand,
-			cacheInfoSubcommand,
+			a := app.New(cacheImpl)
+			return toCLIError(cacheImpl.GlobalImpl, a.ShowCacheDir(cacheImpl))
 		},
-	})
+	}
+
+	return cmd
+}
+
+func NewCacheCleanupSubcommand(cacheImpl *config.CacheImpl) *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "cleanup",
+		Short: "clean up cache directory",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(cacheImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := cacheImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(cacheImpl)
+			return toCLIError(cacheImpl.GlobalImpl, a.CleanCacheDir(cacheImpl))
+		},
+	}
+	return cmd
+}
+
+// NewCacheCmd returm cache subcmd
+func NewCacheCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	cacheOptions := config.NewCacheOptions()
+	cacheImpl := config.NewCacheImpl(globalCfg, cacheOptions)
+
+	cmd := &cobra.Command{
+		Use:   "cache",
+		Short: "Cache management",
+	}
+
+	cmd.AddCommand(
+		NewCacheCleanupSubcommand(cacheImpl),
+		NewCacheInfoSubcommand(cacheImpl),
+	)
+
+	return cmd
 }

cmd/charts.go

@@ -3,35 +3,37 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addChartsSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "charts",
-		Usage: "DEPRECATED: sync releases from state file (helm upgrade --install)",
-		Flags: []cli.Flag{
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
-			cli.StringSliceFlag{
-				Name:  "set",
-				Usage: "additional values to be merged into the command",
-			},
-			cli.StringSliceFlag{
-				Name:  "values",
-				Usage: "additional value files to be merged into the command",
-			},
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent helm processes to run, 0 is unlimited",
-			},
+// NewChartsCmd returm build subcmd
+func NewChartsCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	chartsOptions := config.NewChartsOptions()
+	chartsImpl := config.NewChartsImpl(globalCfg, chartsOptions)
+
+	cmd := &cobra.Command{
+		Use:   "charts",
+		Short: "DEPRECATED: sync releases from state file (helm upgrade --install)",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(chartsImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := chartsImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(chartsImpl)
+			return toCLIError(chartsImpl.GlobalImpl, a.DeprecatedSyncCharts(chartsImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.DeprecatedSyncCharts(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringVar(&chartsOptions.Args, "args", chartsOptions.Args, "pass args to helm exec")
+	f.StringArrayVar(&chartsOptions.Set, "set", chartsOptions.Set, "additional values to be merged into the command")
+	f.StringArrayVar(&chartsOptions.Values, "values", chartsOptions.Values, "additional value files to be merged into the command")
+	f.IntVar(&chartsOptions.Concurrency, "concurrency", 0, "maximum number of concurrent helm processes to run, 0 is unlimited")
+
+	return cmd
 }

cmd/delete.go

@@ -3,35 +3,37 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addDeleteSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "delete",
-		Usage: "DEPRECATED: delete releases from state file (helm delete)",
-		Flags: []cli.Flag{
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent helm processes to run, 0 is unlimited",
-			},
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
-			cli.BoolFlag{
-				Name:  "purge",
-				Usage: "purge releases i.e. free release names and histories",
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
+// NewDeleteCmd returm build subcmd
+func NewDeleteCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	deleteOptions := config.NewDeleteOptions()
+	deleteImpl := config.NewDeleteImpl(globalCfg, deleteOptions)
+
+	cmd := &cobra.Command{
+		Use:   "delete",
+		Short: "DEPRECATED: delete releases from state file (helm delete)",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(deleteImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := deleteImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(deleteImpl)
+			return toCLIError(deleteImpl.GlobalImpl, a.Delete(deleteImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Delete(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringVar(&deleteOptions.Args, "args", deleteOptions.Args, "pass args to helm exec")
+	f.IntVar(&deleteOptions.Concurrency, "concurrency", 0, "maximum number of concurrent helm processes to run, 0 is unlimited")
+	f.BoolVar(&deleteOptions.Purge, "purge", deleteOptions.Purge, "purge releases i.e. free release names and histories")
+	f.BoolVar(&deleteOptions.SkipDeps, "skip-deps", deleteOptions.SkipDeps, `skip running "helm repo update" and "helm dependency build"`)
+
+	return cmd
 }

cmd/deps.go

@@ -3,26 +3,35 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addDepsSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "deps",
-		Usage: "update charts based on their requirements",
-		Flags: []cli.Flag{
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
-			cli.BoolFlag{
-				Name:  "skip-repos",
-				Usage: `skip running "helm repo update" before running "helm dependency build"`,
-			},
+// NewDepsCmd returm build subcmd
+func NewDepsCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	depsOptions := config.NewDepsOptions()
+	depsImpl := config.NewDepsImpl(globalCfg, depsOptions)
+
+	cmd := &cobra.Command{
+		Use:   "deps",
+		Short: "Update charts based on their requirements",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(depsImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := depsImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(depsImpl)
+			return toCLIError(depsImpl.GlobalImpl, a.Deps(depsImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Deps(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringVar(&depsOptions.Args, "args", depsOptions.Args, "pass args to helm exec")
+	f.BoolVar(&depsOptions.SkipRepos, "skip-deps", depsOptions.SkipRepos, `skip running "helm repo update" and "helm dependency build"`)
+
+	return cmd
 }

cmd/destroy.go

@@ -3,31 +3,36 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addDestroySubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "destroy",
-		Usage: "deletes and then purges releases",
-		Flags: []cli.Flag{
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent helm processes to run, 0 is unlimited",
-			},
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
+// NewDestroyCmd returm build subcmd
+func NewDestroyCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	destroyOptions := config.NewDestroyOptions()
+	destroyImpl := config.NewDestroyImpl(globalCfg, destroyOptions)
+
+	cmd := &cobra.Command{
+		Use:   "destroy",
+		Short: "Destroys and then purges releases",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(destroyImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := destroyImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(destroyImpl)
+			return toCLIError(destroyImpl.GlobalImpl, a.Destroy(destroyImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Destroy(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringVar(&destroyOptions.Args, "args", destroyOptions.Args, "pass args to helm exec")
+	f.IntVar(&destroyOptions.Concurrency, "concurrency", 0, "maximum number of concurrent helm processes to run, 0 is unlimited")
+	f.BoolVar(&destroyOptions.SkipDeps, "skip-deps", destroyOptions.SkipDeps, `skip running "helm repo update" and "helm dependency build"`)
+
+	return cmd
 }

cmd/diff.go

@@ -3,90 +3,50 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addDiffSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "diff",
-		Usage: "diff releases from state file against env (helm diff)",
-		Flags: []cli.Flag{
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
-			cli.StringSliceFlag{
-				Name:  "set",
-				Usage: "additional values to be merged into the command",
-			},
-			cli.StringSliceFlag{
-				Name:  "values",
-				Usage: "additional value files to be merged into the command",
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
-			cli.BoolFlag{
-				Name:  "detailed-exitcode",
-				Usage: "return a non-zero exit code when there are changes",
-			},
-			cli.BoolFlag{
-				Name:  "include-tests",
-				Usage: "enable the diffing of the helm test hooks",
-			},
-			cli.BoolTFlag{
-				Name:  "skip-needs",
-				Usage: `do not automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided. Defaults to true when --include-needs or --include-transitive-needs is not provided`,
-			},
-			cli.BoolFlag{
-				Name:  "include-needs",
-				Usage: `automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided`,
-			},
-			cli.BoolFlag{
-				Name:  "include-transitive-needs",
-				Usage: `like --include-needs, but also includes transitive needs (needs of needs). Does nothing when when --selector/-l flag is not provided. Overrides exclusions of other selectors and conditions.`,
-			},
-			cli.BoolFlag{
-				Name:  "skip-diff-on-install",
-				Usage: "Skips running helm-diff on releases being newly installed on this apply. Useful when the release manifests are too huge to be reviewed, or it's too time-consuming to diff at all",
-			},
-			cli.StringSliceFlag{
-				Name:  "suppress",
-				Usage: "suppress specified Kubernetes objects in the output. Can be provided multiple times. For example: --suppress KeycloakClient --suppress VaultSecret",
-			},
-			cli.BoolFlag{
-				Name:  "suppress-secrets",
-				Usage: "suppress secrets in the output. highly recommended to specify on CI/CD use-cases",
-			},
-			cli.BoolFlag{
-				Name:  "show-secrets",
-				Usage: "do not redact secret values in the output. should be used for debug purpose only",
-			},
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent helm processes to run, 0 is unlimited",
-			},
-			cli.BoolFlag{
-				Name:  "validate",
-				Usage: "validate your manifests against the Kubernetes cluster you are currently pointing at. Note that this requires access to a Kubernetes cluster to obtain information necessary for validating, like the list of available API versions",
-			},
+// NewDiffCmd returm build subcmd
+func NewDiffCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	diffOptions := config.NewDiffOptions()
+	diffImpl := config.NewDiffImpl(globalCfg, diffOptions)
 
-			cli.IntFlag{
-				Name:  "context",
-				Value: 0,
-				Usage: "output NUM lines of context around changes",
-			},
-			cli.StringFlag{
-				Name:  "output",
-				Value: "",
-				Usage: "output format for diff plugin",
-			},
+	cmd := &cobra.Command{
+		Use:   "diff",
+		Short: "Diff releases defined in state file",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(diffImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := diffImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(diffImpl)
+			return toCLIError(diffImpl.GlobalImpl, a.Diff(diffImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Diff(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringVar(&diffOptions.Args, "args", "", "pass args to helm diff")
+	f.StringArrayVar(&diffOptions.Set, "set", []string{}, "additional values to be merged into the command")
+	f.StringArrayVar(&diffOptions.Values, "values", []string{}, "additional value files to be merged into the command")
+	f.IntVar(&diffOptions.Concurrency, "concurrency", 0, "maximum number of concurrent downloads of release charts")
+	f.BoolVar(&diffOptions.Validate, "validate", false, "validate your manifests against the Kubernetes cluster you are currently pointing at. Note that this requires access to a Kubernetes cluster to obtain information necessary for validating, like the diff of available API versions")
+	f.BoolVar(&diffOptions.SkipNeeds, "skip-needs", false, `do not automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided. Defaults to true when --include-needs or --include-transitive-needs is not provided`)
+	f.BoolVar(&diffOptions.IncludeTests, "include-tests", false, "enable the diffing of the helm test hooks")
+	f.BoolVar(&diffOptions.IncludeNeeds, "include-needs", false, `automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided`)
+	f.BoolVar(&diffOptions.IncludeTransitiveNeeds, "include-transitive-needs", false, `like --include-needs, but also includes transitive needs (needs of needs). Does nothing when when --selector/-l flag is not provided. Overrides exclusions of other selectors and conditions.`)
+	f.BoolVar(&diffOptions.SkipDeps, "skip-deps", false, `skip running "helm repo update" and "helm dependency build"`)
+	f.BoolVar(&diffOptions.SkipDiffOnInstall, "skip-diff-on-install", false, "Skips running helm-diff on releases being newly installed on this apply. Useful when the release manifests are too huge to be reviewed, or it's too time-consuming to diff at all")
+	f.BoolVar(&diffOptions.ShowSecrets, "show-secrets", false, "do not redact secret values in the output. should be used for debug purpose only")
+	f.BoolVar(&diffOptions.DetailedExitcode, "detailed-exitcode", false, "return a detailed exit code")
+	f.IntVar(&diffOptions.Context, "context", 0, "output NUM lines of context around changes")
+	f.StringVar(&diffOptions.Output, "output", "", "output format for diff plugin")
+	f.BoolVar(&diffOptions.SuppressSecrets, "suppress-secrets", false, "suppress secrets in the output. highly recommended to specify on CI/CD use-cases")
+	f.StringArrayVar(&diffOptions.Suppress, "suppress", []string{}, "suppress specified Kubernetes objects in the output. Can be provided multiple times. For example: --suppress KeycloakClient --suppress VaultSecret")
+
+	return cmd
 }

cmd/fetch.go

@@ -3,30 +3,36 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addFetchSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "fetch",
-		Usage: "fetch charts from state file",
-		Flags: []cli.Flag{
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent downloads of release charts",
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
-			cli.StringFlag{
-				Name:  "output-dir",
-				Usage: "directory to store charts (default: temporary directory which is deleted when the command terminates)",
-			},
+// NewFetchCmd returm build subcmd
+func NewFetchCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	fetchOptions := config.NewFetchOptions()
+	fetchImpl := config.NewFetchImpl(globalCfg, fetchOptions)
+
+	cmd := &cobra.Command{
+		Use:   "fetch",
+		Short: "Fetch charts from state file",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(fetchImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := fetchImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(fetchImpl)
+			return toCLIError(fetchImpl.GlobalImpl, a.Fetch(fetchImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Fetch(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.IntVar(&fetchOptions.Concurrency, "concurrency", 0, "maximum number of concurrent helm processes to run, 0 is unlimited")
+	f.BoolVar(&fetchOptions.SkipDeps, "skip-deps", fetchOptions.SkipDeps, `skip running "helm repo update" and "helm dependency build"`)
+	f.StringVar(&fetchOptions.OutputDir, "output-dir", fetchOptions.OutputDir, "directory to store charts (default: temporary directory which is deleted when the command terminates)")
+
+	return cmd
 }

cmd/lint.go

@@ -3,39 +3,38 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addLintSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "lint",
-		Usage: "lint charts from state file (helm lint)",
-		Flags: []cli.Flag{
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
-			cli.StringSliceFlag{
-				Name:  "set",
-				Usage: "additional values to be merged into the command",
-			},
-			cli.StringSliceFlag{
-				Name:  "values",
-				Usage: "additional value files to be merged into the command",
-			},
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent downloads of release charts",
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
+// NewLintCmd returm build subcmd
+func NewLintCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	lintOptions := config.NewLintOptions()
+	lintImpl := config.NewLintImpl(globalCfg, lintOptions)
+
+	cmd := &cobra.Command{
+		Use:   "lint",
+		Short: "Lint charts from state file (helm lint)",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(lintImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := lintImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(lintImpl)
+			return toCLIError(lintImpl.GlobalImpl, a.Lint(lintImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Lint(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.IntVar(&lintOptions.Concurrency, "concurrency", 0, "maximum number of concurrent downloads of release charts")
+	f.BoolVar(&lintOptions.SkipDeps, "skip-deps", lintOptions.SkipDeps, `skip running "helm repo update" and "helm dependency build"`)
+	f.StringVar(&lintOptions.Args, "args", lintOptions.Args, "pass args to helm exec")
+	f.StringArrayVar(&lintOptions.Set, "set", lintOptions.Set, "additional values to be merged into the command")
+	f.StringArrayVar(&lintOptions.Values, "values", lintOptions.Values, "additional value files to be merged into the command")
+
+	return cmd
 }

cmd/list.go

@@ -3,26 +3,35 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addListSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "list",
-		Usage: "list releases defined in state file",
-		Flags: []cli.Flag{
-			cli.StringFlag{
-				Name:  "output",
-				Value: "",
-				Usage: "output releases list as a json string",
-			},
-			cli.BoolFlag{
-				Name:  "keep-temp-dir",
-				Usage: "Keep temporary directory",
-			},
+// NewListCmd returm build subcmd
+func NewListCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	listOptions := config.NewListOptions()
+	listImpl := config.NewListImpl(globalCfg, listOptions)
+
+	cmd := &cobra.Command{
+		Use:   "list",
+		Short: "List releases defined in state file",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(listImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := listImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(listImpl)
+			return toCLIError(listImpl.GlobalImpl, a.ListReleases(listImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.ListReleases(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.BoolVar(&listOptions.KeepTempDir, "keep-temp-dir", listOptions.KeepTempDir, "Keep temporary directory")
+	f.StringVar(&listOptions.Output, "output", listOptions.Output, "output releases list as a json string")
+
+	return cmd
 }

cmd/repos.go

@@ -3,22 +3,34 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addReposSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "repos",
-		Usage: "sync repositories from state file (helm repo add && helm repo update)",
-		Flags: []cli.Flag{
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
+// NewReposCmd returm build subcmd
+func NewReposCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	reposOptions := config.NewReposOptions()
+	reposImpl := config.NewReposImpl(globalCfg, reposOptions)
+
+	cmd := &cobra.Command{
+		Use:   "repos",
+		Short: "Repos releases defined in state file",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(reposImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := reposImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(reposImpl)
+			return toCLIError(reposImpl.GlobalImpl, a.Repos(reposImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Repos(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringVar(&reposOptions.Args, "args", reposOptions.Args, "pass args to helm exec")
+
+	return cmd
 }

cmd/root.go

@@ -8,125 +8,21 @@ import (
 	"github.com/helmfile/helmfile/pkg/app/version"
 	"github.com/helmfile/helmfile/pkg/config"
 	"github.com/helmfile/helmfile/pkg/helmexec"
+	"github.com/spf13/cobra"
+	"github.com/spf13/pflag"
 	"github.com/urfave/cli"
 	"go.uber.org/zap"
 )
 
 var logger *zap.SugaredLogger
+var globalUsage = "Declaratively deploy your Kubernetes manifests, Kustomize configs, and Charts as Helm releases in one shot"
 
-// RootCmd is the root command for helmfile.
-func RootCommand() *cli.App {
-	cliApp := cli.NewApp()
-	cliApp.Name = "helmfile"
-	cliApp.Usage = ""
-	cliApp.Version = version.GetVersion()
-	cliApp.EnableBashCompletion = true
-	cliApp.Before = configureLogging
-	setRootCommandFlags(cliApp)
-
-	// add subcommands
-	addDepsSubcommand(cliApp)
-	addReposSubcommand(cliApp)
-	addChartsSubcommand(cliApp)
-	addDiffSubcommand(cliApp)
-	addTemplateSubcommand(cliApp)
-	addWriteValuesSubcommand(cliApp)
-	addLintSubcommand(cliApp)
-	addFetchSubcommand(cliApp)
-	addSyncSubcommand(cliApp)
-	addApplySubcommand(cliApp)
-	addStatusSubcommand(cliApp)
-	addDeleteSubcommand(cliApp)
-	addDestroySubcommand(cliApp)
-	addTestSubcommand(cliApp)
-	addBuildSubcommand(cliApp)
-	addListSubcommand(cliApp)
-	addCacheSubcommand(cliApp)
-	addVersionSubcommand(cliApp)
-
-	return cliApp
-}
-
-// setRootCommandFlags sets the flags for the root command.
-func setRootCommandFlags(cliApp *cli.App) {
-	cliApp.Flags = []cli.Flag{
-		cli.StringFlag{
-			Name:  "helm-binary, b",
-			Usage: "path to helm binary",
-			Value: app.DefaultHelmBinary,
-		},
-		cli.StringFlag{
-			Name:  "file, f",
-			Usage: "load config from file or directory. defaults to `helmfile.yaml` or `helmfile.d`(means `helmfile.d/*.yaml`) in this preference",
-		},
-		cli.StringFlag{
-			Name:  "environment, e",
-			Usage: `specify the environment name. defaults to "default"`,
-		},
-		cli.StringSliceFlag{
-			Name:  "state-values-set",
-			Usage: "set state values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)",
-		},
-		cli.StringSliceFlag{
-			Name:  "state-values-file",
-			Usage: "specify state values in a YAML file",
-		},
-		cli.BoolFlag{
-			Name:  "quiet, q",
-			Usage: "Silence output. Equivalent to log-level warn",
-		},
-		cli.StringFlag{
-			Name:  "kube-context",
-			Usage: "Set kubectl context. Uses current context by default",
-		},
-		cli.BoolFlag{
-			Name:  "debug",
-			Usage: "Enable verbose output for Helm and set log-level to debug, this disables --quiet/-q effect",
-		},
-		cli.BoolFlag{
-			Name:  "color",
-			Usage: "Output with color",
-		},
-		cli.BoolFlag{
-			Name:  "no-color",
-			Usage: "Output without color",
-		},
-		cli.StringFlag{
-			Name:  "log-level",
-			Usage: "Set log level, default info",
-		},
-		cli.StringFlag{
-			Name:  "namespace, n",
-			Usage: "Set namespace. Uses the namespace set in the context by default, and is available in templates as {{ .Namespace }}",
-		},
-		cli.StringFlag{
-			Name:  "chart, c",
-			Usage: "Set chart. Uses the chart set in release by default, and is available in template as {{ .Chart }}",
-		},
-		cli.StringSliceFlag{
-			Name: "selector, l",
-			Usage: `Only run using the releases that match labels. Labels can take the form of foo=bar or foo!=bar.
-	A release must match all labels in a group in order to be used. Multiple groups can be specified at once.
-	--selector tier=frontend,tier!=proxy --selector tier=backend. Will match all frontend, non-proxy releases AND all backend releases.
-	The name of a release can be used as a label. --selector name=myrelease`,
-		},
-		cli.BoolFlag{
-			Name:  "allow-no-matching-release",
-			Usage: `Do not exit with an error code if the provided selector has no matching releases.`,
-		},
-		cli.BoolFlag{
-			Name:  "interactive, i",
-			Usage: "Request confirmation before attempting to modify clusters",
-		},
-	}
-}
-
-func toCliError(c *cli.Context, err error) error {
+func toCLIError(g *config.GlobalImpl, err error) error {
 	if err != nil {
 		switch e := err.(type) {
 		case *app.NoMatchingHelmfileError:
 			noMatchingExitCode := 3
-			if c.GlobalBool("allow-no-matching-release") {
+			if g.AllowNoMatchingRelease {
 				noMatchingExitCode = 0
 			}
 			return cli.NewExitError(e.Error(), noMatchingExitCode)
@@ -141,42 +37,88 @@ func toCliError(c *cli.Context, err error) error {
 	return err
 }
 
-func configureLogging(c *cli.Context) error {
-	// Valid levels:
-	// https://github.com/uber-go/zap/blob/7e7e266a8dbce911a49554b945538c5b950196b8/zapcore/level.go#L126
-	logLevel := c.GlobalString("log-level")
-	if c.GlobalBool("debug") {
-		logLevel = "debug"
-	} else if c.GlobalBool("quiet") {
-		logLevel = "warn"
+// NewRootCmd creates the root command for the CLI.
+func NewRootCmd(globalConfig *config.GlobalOptions, args []string) (*cobra.Command, error) {
+	cmd := &cobra.Command{
+		Use:          "helmfile",
+		Short:        globalUsage,
+		Long:         globalUsage,
+		Args:         cobra.MinimumNArgs(1),
+		Version:      version.GetVersion(),
+		SilenceUsage: true,
+		PersistentPreRunE: func(c *cobra.Command, args []string) error {
+			// Valid levels:
+			// https://github.com/uber-go/zap/blob/7e7e266a8dbce911a49554b945538c5b950196b8/zapcore/level.go#L126
+			logLevel := globalConfig.LogLevel
+			switch {
+			case globalConfig.Debug:
+				logLevel = "debug"
+			case globalConfig.Quiet:
+				logLevel = "warn"
+			}
+			logger = helmexec.NewLogger(os.Stderr, logLevel)
+			globalConfig.SetLogger(logger)
+			return nil
+		},
 	}
-	logger = helmexec.NewLogger(os.Stderr, logLevel)
-	if c.App.Metadata == nil {
-		// Auto-initialized in 1.19.0
-		// https://github.com/urfave/cli/blob/master/CHANGELOG.md#1190---2016-11-19
-		c.App.Metadata = make(map[string]interface{})
+	flags := cmd.PersistentFlags()
+
+	// Set the global options for the root command.
+	setGlobalOptionsForRootCmd(flags, globalConfig)
+
+	// We can safely ignore any errors that flags.Parse encounters since
+	// those errors will be caught later during the call to cmd.Execution.
+	// This call is required to gather configuration information prior to
+	// execution.
+	flags.ParseErrorsWhitelist.UnknownFlags = true
+
+	err := flags.Parse(args)
+	if err != nil {
+		return nil, err
 	}
-	c.App.Metadata["logger"] = logger
-	return nil
+	globalImpl := config.NewGlobalImpl(globalConfig)
+	cmd.AddCommand(
+		NewApplyCmd(globalImpl),
+		NewBuildCmd(globalImpl),
+		NewCacheCmd(globalImpl),
+		NewChartsCmd(globalImpl),
+		NewDeleteCmd(globalImpl),
+		NewDepsCmd(globalImpl),
+		NewDestroyCmd(globalImpl),
+		NewFetchCmd(globalImpl),
+		NewListCmd(globalImpl),
+		NewReposCmd(globalImpl),
+		NewVersionCmd(),
+		NewLintCmd(globalImpl),
+		NewWriteValuesCmd(globalImpl),
+		NewTestCmd(globalImpl),
+		NewTemplateCmd(globalImpl),
+		NewSyncCmd(globalImpl),
+		NewDiffCmd(globalImpl),
+		NewStatusCmd(globalImpl),
+	)
+
+	return cmd, nil
 }
 
-func Action(do func(*app.App, config.ConfigImpl) error) func(*cli.Context) error {
-	return func(implCtx *cli.Context) error {
-		conf, err := config.NewUrfaveCliConfigImpl(implCtx)
-		if err != nil {
-			return err
-		}
-
-		if err := app.ValidateConfig(conf); err != nil {
-			return err
-		}
-
-		a := app.New(conf)
-
-		if err := do(a, conf); err != nil {
-			return toCliError(implCtx, err)
-		}
-
-		return nil
-	}
+func setGlobalOptionsForRootCmd(fs *pflag.FlagSet, globalOptions *config.GlobalOptions) {
+	fs.StringVarP(&globalOptions.HelmBinary, "helm-binary", "b", app.DefaultHelmBinary, "Path to the helm binary")
+	fs.StringVarP(&globalOptions.File, "file", "f", globalOptions.File, "load config from file or directory. defaults to `helmfile.yaml` or `helmfile.d`(means `helmfile.d/*.yaml`) in this preference")
+	fs.StringVarP(&globalOptions.Environment, "env", "e", globalOptions.Environment, `specify the environment name. defaults to "default"`)
+	fs.StringArrayVarP(&globalOptions.StateValuesSet, "state-values-set", "s", globalOptions.StateValuesSet, "set state values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)")
+	fs.StringArrayVarP(&globalOptions.StateValuesFile, "state-values-file", "", globalOptions.StateValuesFile, "specify state values in a YAML file")
+	fs.BoolVarP(&globalOptions.Quiet, "quiet", "q", globalOptions.Quiet, "Silence output. Equivalent to log-level warn")
+	fs.StringVar(&globalOptions.KubeContext, "kube-context", globalOptions.KubeContext, "Set kubectl context. Uses current context by default")
+	fs.BoolVar(&globalOptions.Debug, "debug", globalOptions.Debug, "Enable verbose output for Helm and set log-level to debug, this disables --quiet/-q effect")
+	fs.BoolVar(&globalOptions.Color, "color", globalOptions.Color, "Output with color")
+	fs.BoolVar(&globalOptions.NoColor, "no-color", globalOptions.NoColor, "Output without color")
+	fs.StringVar(&globalOptions.LogLevel, "log-level", globalOptions.LogLevel, "Set log level, default info")
+	fs.StringVar(&globalOptions.Namespace, "namespace", globalOptions.Namespace, "Set namespace. Uses the namespace set in the context by default, and is available in templates as {{ .Namespace }}")
+	fs.StringVar(&globalOptions.Chart, "chart", globalOptions.Chart, "Set chart. Uses the chart set in release by default, and is available in template as {{ .Chart }}")
+	fs.StringArrayVarP(&globalOptions.Selector, "selector", "l", globalOptions.Selector, `Only run using the releases that match labels. Labels can take the form of foo=bar or foo!=bar.
+	A release must match all labels in a group in order to be used. Multiple groups can be specified at once.
+	--selector tier=frontend,tier!=proxy --selector tier=backend. Will match all frontend, non-proxy releases AND all backend releases.
+	The name of a release can be used as a label. --selector name=myrelease`)
+	fs.BoolVar(&globalOptions.AllowNoMatchingRelease, "allow-no-matching-release", globalOptions.AllowNoMatchingRelease, `Do not exit with an error code if the provided selector has no matching releases.`)
+	fs.BoolVarP(&globalOptions.Interactive, "interactive", "i", globalOptions.Interactive, "Request confirmation before attempting to modify clusters")
 }

cmd/status.go

@@ -3,27 +3,34 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addStatusSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "status",
-		Usage: "retrieve status of releases in state file",
-		Flags: []cli.Flag{
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent helm processes to run, 0 is unlimited",
-			},
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
+// NewStatusCmd returm build subcmd
+func NewStatusCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	statusOptions := config.NewStatusOptions()
+	statusImpl := config.NewStatusImpl(globalCfg, statusOptions)
+
+	cmd := &cobra.Command{
+		Use:   "status",
+		Short: "Retrieve status of releases in state file",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(statusImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := statusImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(statusImpl)
+			return toCLIError(statusImpl.GlobalImpl, a.Status(statusImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Status(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringVar(&statusOptions.Args, "args", statusOptions.Args, "pass args to helm exec")
+
+	return cmd
 }

cmd/sync.go

@@ -3,67 +3,45 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addSyncSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "sync",
-		Usage: "sync all resources from state file (repos, releases and chart deps)",
-		Flags: []cli.Flag{
-			cli.StringSliceFlag{
-				Name:  "set",
-				Usage: "additional values to be merged into the command",
-			},
-			cli.StringSliceFlag{
-				Name:  "values",
-				Usage: "additional value files to be merged into the command",
-			},
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent helm processes to run, 0 is unlimited",
-			},
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm exec",
-			},
-			cli.BoolFlag{
-				Name:  "skip-crds",
-				Usage: "if set, no CRDs will be installed on sync. By default, CRDs are installed if not already present",
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
-			cli.BoolTFlag{
-				Name:  "skip-needs",
-				Usage: `do not automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided. Defaults to true when --include-needs or --include-transitive-needs is not provided`,
-			},
-			cli.BoolFlag{
-				Name:  "include-needs",
-				Usage: `automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided`,
-			},
-			cli.BoolFlag{
-				Name:  "include-transitive-needs",
-				Usage: `like --include-needs, but also includes transitive needs (needs of needs). Does nothing when when --selector/-l flag is not provided. Overrides exclusions of other selectors and conditions.`,
-			},
-			cli.BoolFlag{
-				Name:  "validate",
-				Usage: `ADVANCED CONFIGURATION: When sync is going to involve helm-template as a part of the "chartify" process, it might fail due to missing .Capabilities. This flag makes instructs helmfile to pass --validate to helm-template so it populates .Capabilities and validates your manifests against the Kubernetes cluster you are currently pointing at. Note that this requires access to a Kubernetes cluster to obtain information necessary for validating, like the list of available API versions`,
-			},
-			cli.BoolFlag{
-				Name:  "wait",
-				Usage: `Override helmDefaults.wait setting "helm upgrade --install --wait"`,
-			},
-			cli.BoolFlag{
-				Name:  "wait-for-jobs",
-				Usage: `Override helmDefaults.waitForJobs setting "helm upgrade --install --wait-for-jobs"`,
-			},
+// NewSyncCmd returm build subcmd
+func NewSyncCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	syncOptions := config.NewSyncOptions()
+	syncImpl := config.NewSyncImpl(globalCfg, syncOptions)
+
+	cmd := &cobra.Command{
+		Use:   "sync",
+		Short: "Sync releases defined in state file",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(syncImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := syncImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(syncImpl)
+			return toCLIError(syncImpl.GlobalImpl, a.Sync(syncImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Sync(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringVar(&syncOptions.Args, "args", "", "pass args to helm sync")
+	f.StringArrayVar(&syncOptions.Set, "set", []string{}, "additional values to be merged into the command")
+	f.StringArrayVar(&syncOptions.Values, "values", []string{}, "additional value files to be merged into the command")
+	f.IntVar(&syncOptions.Concurrency, "concurrency", 0, "maximum number of concurrent downloads of release charts")
+	f.BoolVar(&syncOptions.Validate, "validate", false, "validate your manifests against the Kubernetes cluster you are currently pointing at. Note that this requires access to a Kubernetes cluster to obtain information necessary for validating, like the sync of available API versions")
+	f.BoolVar(&syncOptions.SkipNeeds, "skip-needs", false, `do not automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided. Defaults to true when --include-needs or --include-transitive-needs is not provided`)
+	f.BoolVar(&syncOptions.SkipCRDs, "skip-crds", false, "if set, no CRDs will be installed on sync. By default, CRDs are installed if not already present")
+	f.BoolVar(&syncOptions.IncludeNeeds, "include-needs", false, `automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided`)
+	f.BoolVar(&syncOptions.IncludeTransitiveNeeds, "include-transitive-needs", false, `like --include-needs, but also includes transitive needs (needs of needs). Does nothing when when --selector/-l flag is not provided. Overrides exclusions of other selectors and conditions.`)
+	f.BoolVar(&syncOptions.SkipDeps, "skip-deps", false, `skip running "helm repo update" and "helm dependency build"`)
+	f.BoolVar(&syncOptions.Wait, "wait", false, `Override helmDefaults.wait setting "helm upgrade --install --wait"`)
+	f.BoolVar(&syncOptions.WaitForJobs, "wait-for-jobs", false, `Override helmDefaults.waitForJobs setting "helm upgrade --install --wait-for-jobs"`)
+
+	return cmd
 }

cmd/template.go

@@ -3,75 +3,47 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addTemplateSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "template",
-		Usage: "template releases from state file against env (helm template)",
-		Flags: []cli.Flag{
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass args to helm template",
-			},
-			cli.StringSliceFlag{
-				Name:  "set",
-				Usage: "additional values to be merged into the command",
-			},
-			cli.StringSliceFlag{
-				Name:  "values",
-				Usage: "additional value files to be merged into the command",
-			},
-			cli.StringFlag{
-				Name:  "output-dir",
-				Usage: "output directory to pass to helm template (helm template --output-dir)",
-			},
-			cli.StringFlag{
-				Name:  "output-dir-template",
-				Usage: "go text template for generating the output directory. Default: {{ .OutputDir }}/{{ .State.BaseName }}-{{ .State.AbsPathSHA1 }}-{{ .Release.Name}}",
-			},
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent downloads of release charts",
-			},
-			cli.BoolFlag{
-				Name:  "validate",
-				Usage: "validate your manifests against the Kubernetes cluster you are currently pointing at. Note that this requires access to a Kubernetes cluster to obtain information necessary for validating, like the list of available API versions",
-			},
-			cli.BoolFlag{
-				Name:  "include-crds",
-				Usage: "include CRDs in the templated output",
-			},
-			cli.BoolFlag{
-				Name:  "skip-tests",
-				Usage: "skip tests from templated output",
-			},
-			cli.BoolFlag{
-				Name:  "skip-needs",
-				Usage: `do not automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided. Defaults to true when --include-needs or --include-transitive-needs is not provided`,
-			},
-			cli.BoolFlag{
-				Name:  "include-needs",
-				Usage: `automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided`,
-			},
-			cli.BoolFlag{
-				Name:  "include-transitive-needs",
-				Usage: `like --include-needs, but also includes transitive needs (needs of needs). Does nothing when when --selector/-l flag is not provided. Overrides exclusions of other selectors and conditions.`,
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
-			cli.BoolFlag{
-				Name:  "skip-cleanup",
-				Usage: "Stop cleaning up temporary values generated by helmfile and helm-secrets. Useful for debugging. Don't use in production for security",
-			},
+// NewTemplateCmd returm build subcmd
+func NewTemplateCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	templateOptions := config.NewTemplateOptions()
+	templateImpl := config.NewTemplateImpl(globalCfg, templateOptions)
+
+	cmd := &cobra.Command{
+		Use:   "template",
+		Short: "Template releases defined in state file",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(templateImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := templateImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(templateImpl)
+			return toCLIError(templateImpl.GlobalImpl, a.Template(templateImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Template(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.StringVar(&templateOptions.Args, "args", "", "pass args to helm template")
+	f.StringArrayVar(&templateOptions.Set, "set", []string{}, "additional values to be merged into the command")
+	f.StringArrayVar(&templateOptions.Values, "values", []string{}, "additional value files to be merged into the command")
+	f.StringVar(&templateOptions.OutputDir, "output-dir", "", "output directory to pass to helm template (helm template --output-dir)")
+	f.StringVar(&templateOptions.OutputDirTemplate, "output-dir-template", "", "go text template for generating the output directory. Default: {{ .OutputDir }}/{{ .State.BaseName }}-{{ .State.AbsPathSHA1 }}-{{ .Release.Name}}")
+	f.IntVar(&templateOptions.Concurrency, "concurrency", 0, "maximum number of concurrent downloads of release charts")
+	f.BoolVar(&templateOptions.Validate, "validate", false, "validate your manifests against the Kubernetes cluster you are currently pointing at. Note that this requires access to a Kubernetes cluster to obtain information necessary for validating, like the template of available API versions")
+	f.BoolVar(&templateOptions.IncludeCRDs, "include-crds", false, "include CRDs in the templated output")
+	f.BoolVar(&templateOptions.SkipTests, "skip-tests", false, "skip tests from templated output")
+	f.BoolVar(&templateOptions.SkipNeeds, "skip-needs", false, `do not automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided. Defaults to true when --include-needs or --include-transitive-needs is not provided`)
+	f.BoolVar(&templateOptions.IncludeNeeds, "include-needs", false, `automatically include releases from the target release's "needs" when --selector/-l flag is provided. Does nothing when when --selector/-l flag is not provided`)
+	f.BoolVar(&templateOptions.IncludeTransitiveNeeds, "include-transitive-needs", false, `like --include-needs, but also includes transitive needs (needs of needs). Does nothing when when --selector/-l flag is not provided. Overrides exclusions of other selectors and conditions.`)
+	f.BoolVar(&templateOptions.SkipDeps, "skip-deps", false, `skip running "helm repo update" and "helm dependency build"`)
+	f.BoolVar(&templateOptions.SkipCleanup, "skip-cleanup", false, "Stop cleaning up temporary values generated by helmfile and helm-secrets. Useful for debugging. Don't use in production for security")
+
+	return cmd
 }

cmd/test.go

@@ -3,44 +3,40 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addTestSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "test",
-		Usage: "test releases from state file (helm test)",
-		Flags: []cli.Flag{
-			cli.BoolFlag{
-				Name:  "cleanup",
-				Usage: "delete test pods upon completion",
-			},
-			cli.BoolFlag{
-				Name:  "logs",
-				Usage: "Dump the logs from test pods (this runs after all tests are complete, but before any cleanup)",
-			},
-			cli.StringFlag{
-				Name:  "args",
-				Value: "",
-				Usage: "pass additional args to helm exec",
-			},
-			cli.IntFlag{
-				Name:  "timeout",
-				Value: 300,
-				Usage: "maximum time for tests to run before being considered failed",
-			},
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent helm processes to run, 0 is unlimited",
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
+// NewTestCmd returm build subcmd
+func NewTestCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	testOptions := config.NewTestOptions()
+	testImpl := config.NewTestImpl(globalCfg, testOptions)
+
+	cmd := &cobra.Command{
+		Use:   "test",
+		Short: "Test charts from state file (helm test)",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(testImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := testImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(testImpl)
+			return toCLIError(testImpl.GlobalImpl, a.Test(testImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.Test(c)
-		}),
-	})
+	}
+	testImpl.Cmd = cmd
+
+	f := cmd.Flags()
+	f.IntVar(&testOptions.Concurrency, "concurrency", 0, "maximum number of concurrent downloads of release charts")
+	f.BoolVar(&testOptions.SkipDeps, "skip-deps", testOptions.SkipDeps, `skip running "helm repo update" and "helm dependency build"`)
+	f.BoolVar(&testOptions.Cleanup, "cleanup", testOptions.Cleanup, "delete test pods upon completion")
+	f.BoolVar(&testOptions.Logs, "logs", testOptions.Logs, "Dump the logs from test pods (this runs after all tests are complete, but before any cleanup)")
+	f.StringVar(&testOptions.Args, "args", testOptions.Args, "pass args to helm exec")
+	f.IntVar(&testOptions.Timeout, "timeout", 300, "maximum time for tests to run before being considered failed")
+
+	return cmd
 }

cmd/version.go

@@ -1,17 +1,22 @@
 package cmd
 
 import (
-	"github.com/urfave/cli"
+	"fmt"
+
+	"github.com/helmfile/helmfile/pkg/app/version"
+	"github.com/spf13/cobra"
 )
 
-func addVersionSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:      "version",
-		Usage:     "Show the version for Helmfile.",
-		ArgsUsage: "[command]",
-		Action: func(c *cli.Context) error {
-			cli.ShowVersion(c)
+// NewVersionCmd returm build subcmd
+func NewVersionCmd() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "version",
+		Short: "Show the version for Helmfile.",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			fmt.Println("Helmfile version " + version.GetVersion())
 			return nil
 		},
-	})
+	}
+
+	return cmd
 }

cmd/write-values.go

@@ -3,38 +3,38 @@ package cmd
 import (
 	"github.com/helmfile/helmfile/pkg/app"
 	"github.com/helmfile/helmfile/pkg/config"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 )
 
-func addWriteValuesSubcommand(cliApp *cli.App) {
-	cliApp.Commands = append(cliApp.Commands, cli.Command{
-		Name:  "write-values",
-		Usage: "write values files for releases. Similar to `helmfile template`, write values files instead of manifests.",
-		Flags: []cli.Flag{
-			cli.StringSliceFlag{
-				Name:  "set",
-				Usage: "additional values to be merged into the command",
-			},
-			cli.StringSliceFlag{
-				Name:  "values",
-				Usage: "additional value files to be merged into the command",
-			},
-			cli.StringFlag{
-				Name:  "output-file-template",
-				Usage: "go text template for generating the output file. Default: {{ .State.BaseName }}-{{ .State.AbsPathSHA1 }}/{{ .Release.Name}}.yaml",
-			},
-			cli.IntFlag{
-				Name:  "concurrency",
-				Value: 0,
-				Usage: "maximum number of concurrent downloads of release charts",
-			},
-			cli.BoolFlag{
-				Name:  "skip-deps",
-				Usage: `skip running "helm repo update" and "helm dependency build"`,
-			},
+// NewWriteValuesCmd returm build subcmd
+func NewWriteValuesCmd(globalCfg *config.GlobalImpl) *cobra.Command {
+	writeValuesOptions := config.NewWriteValuesOptions()
+	writeValuesImpl := config.NewWriteValuesImpl(globalCfg, writeValuesOptions)
+
+	cmd := &cobra.Command{
+		Use:   "write-values",
+		Short: "Write values files for releases. Similar to `helmfile template`, write values files instead of manifests.",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			err := config.NewUrfaveCliConfigImplIns(writeValuesImpl.GlobalImpl)
+			if err != nil {
+				return err
+			}
+
+			if err := writeValuesImpl.ValidateConfig(); err != nil {
+				return err
+			}
+
+			a := app.New(writeValuesImpl)
+			return toCLIError(writeValuesImpl.GlobalImpl, a.WriteValues(writeValuesImpl))
 		},
-		Action: Action(func(a *app.App, c config.ConfigImpl) error {
-			return a.WriteValues(c)
-		}),
-	})
+	}
+
+	f := cmd.Flags()
+	f.IntVar(&writeValuesOptions.Concurrency, "concurrency", 0, "maximum number of concurrent downloads of release charts")
+	f.BoolVar(&writeValuesOptions.SkipDeps, "skip-deps", writeValuesOptions.SkipDeps, `skip running "helm repo update" and "helm dependency build"`)
+	f.StringArrayVar(&writeValuesOptions.Set, "set", writeValuesOptions.Set, "additional values to be merged into the command")
+	f.StringArrayVar(&writeValuesOptions.Values, "values", writeValuesOptions.Values, "additional value files to be merged into the command")
+	f.StringVar(&writeValuesOptions.OutputFileTemplate, "output-file-template", writeValuesOptions.OutputFileTemplate, "go text template for generating the output file. Default: {{ .State.BaseName }}-{{ .State.AbsPathSHA1 }}/{{ .Release.Name}}.yaml")
+
+	return cmd
 }