From 849c4e4e091399d73a138170ec07bfccaad95851 Mon Sep 17 00:00:00 2001 From: yxxhero Date: Sun, 15 Mar 2026 09:30:57 +0800 Subject: [PATCH] fix: address lint errors in CI - Remove unused allReleases parameter from unmarkNeedsDirectOnly - Fix gci formatting in app_sequential_test.go Signed-off-by: yxxhero --- pkg/app/app_sequential_test.go | 10 +++++----- pkg/state/state.go | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/app/app_sequential_test.go b/pkg/app/app_sequential_test.go index f956abaf..57823216 100644 --- a/pkg/app/app_sequential_test.go +++ b/pkg/app/app_sequential_test.go @@ -57,8 +57,8 @@ releases: err = app.ForEachState( Noop, false, - - false,SetFilter(true), + false, + SetFilter(true), ) if err != nil { t.Fatalf("unexpected error: %v", err) @@ -194,7 +194,7 @@ releases: noop, false, - false,SetFilter(true), + false, SetFilter(true), ) if err != nil { t.Fatalf("unexpected error: %v", err) @@ -408,7 +408,7 @@ releases: failingConverge, false, - false,SetFilter(true), + false, SetFilter(true), ) if err == nil { @@ -476,7 +476,7 @@ replicaCount: 3 captureState, false, - false,SetFilter(true), + false, SetFilter(true), ) if err != nil { t.Fatalf("unexpected error: %v", err) diff --git a/pkg/state/state.go b/pkg/state/state.go index aa18e0a5..d700fb93 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -2984,7 +2984,7 @@ func markExcludedReleases(releases []ReleaseSpec, selectors []string, values map if includeTransitiveNeeds { unmarkNeedsAndTransitives(filteredReleases, releases) } else if includeNeeds { - unmarkNeedsDirectOnly(filteredReleases, releases) + unmarkNeedsDirectOnly(filteredReleases) } return filteredReleases, nil } @@ -3042,7 +3042,7 @@ func unmarkNeedsAndTransitives(filteredReleases []Release, allReleases []Release unmarkReleases(needsWithTranstives, filteredReleases) } -func unmarkNeedsDirectOnly(filteredReleases []Release, allReleases []ReleaseSpec) { +func unmarkNeedsDirectOnly(filteredReleases []Release) { directNeeds := collectDirectNeedsOnly(filteredReleases) unmarkReleases(directNeeds, filteredReleases) }