public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Relax the helmfile.lock helmfile binary version constraint (#1511)

This commit is contained in:
Yusuke Kuoka 2024-05-09 10:50:56 +09:00 committed by GitHub
parent f09855d40e
commit 7f798fa7b4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/state/chart_dependency.go
View File

@ -402,21 +402,16 @@ func (m *chartDependencyManager) Resolve(unresolved *UnresolvedDependencies) (*R
// Make sure go run main.go works and compatible with old lock files. // Make sure go run main.go works and compatible with old lock files.
if version.Version() != "" && lockedReqs.Version != "" { if version.Version() != "" && lockedReqs.Version != "" {
lockedVersion, err := semver.NewVersion(lockedReqs.Version) // Check that the locked version, i.e. the helmfile binary version recorded in the lock file,
// conforms to semver.
// This is purely for validation purposes.
_, err := semver.NewVersion(lockedReqs.Version)
if err != nil { if err != nil {
return nil, false, err return nil, false, err
} }
currentVersion, err := semver.NewVersion(version.Version()) // Note: We no longer validate the version of the lockfile against the version of the helmfile binary.
// See https://github.com/helmfile/helmfile/issues/1473
if err != nil {
return nil, false, err
}
if currentVersion.LessThan(lockedVersion) {
return nil, false, fmt.Errorf("the lockfile was created by Helmfile %s, which is newer than current %s; Please upgrade to Helmfile %s or greater", lockedVersion.Original(), currentVersion.Original(), lockedVersion.Original())
}
} }
resolved := &ResolvedDependencies{deps: map[string][]ResolvedChartDependency{}} resolved := &ResolvedDependencies{deps: map[string][]ResolvedChartDependency{}}