public_git/helmfile
1
0
Fork 0
mirror of https://github.com/helmfile/helmfile.git synced 2026-10-18 08:34:57 +02:00
Code Issues Projects Releases Wiki Activity

fix: --include-needs should only include direct dependencies (#1003)

Browse Source 
--include-needs was incorrectly including transitive dependencies when
it should only include direct dependencies per the documentation.

The issue was that ChartPrepareOptions.IncludeTransitiveNeeds was being
set to c.IncludeNeeds() instead of c.IncludeTransitiveNeeds() in the
chart preparation phase for diff, template, lint, sync, and apply commands.

This fix ensures:
- --include-needs includes only direct dependencies
- --include-transitive-needs includes both direct and transitive dependencies

Fixes #1003

Signed-off-by: yxxhero <yxxhero@users.noreply.github.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
This commit is contained in:
yxxhero
2026-03-10 07:38:53 +08:00
parent 8301c491ca
commit 7a2cbeebb8
6 changed files with 165 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/integration/test-cases/include-needs-transitive/input/helmfile.yaml
+23
View File
@@ -0,0 +1,23 @@
repositories:
- name: incubator
url: https://charts.helm.sh/incubator
releases:
# release1 has no dependencies - this is a transitive dependency of release3
- name: release1
chart: incubator/raw
namespace: default
# release2 depends on release1 - this is a direct dependency of release3
- name: release2
chart: incubator/raw
namespace: default
needs:
- default/release1
# release3 depends on release2 (and transitively on release1)
- name: release3
chart: incubator/raw
namespace: default
needs:
- default/release2