public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(hook): event hooks should run on remote charts, too (#364) 

And fixed the bug that "diff" was not triggering "prepare" hooks.

Ref #363
This commit is contained in:
KUOKA Yusuke 2018-09-27 01:01:25 +09:00 committed by GitHub
parent b9de22b256
commit 6cba77d4f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
main.go
View File

@ -183,6 +183,10 @@ func main() {
}, },
Action: func(c *cli.Context) error { Action: func(c *cli.Context) error {
return findAndIterateOverDesiredStatesUsingFlags(c, func(state *state.HelmState, helm helmexec.Interface) []error { return findAndIterateOverDesiredStatesUsingFlags(c, func(state *state.HelmState, helm helmexec.Interface) []error {
if errs := state.PrepareRelease(helm, "diff"); errs != nil && len(errs) > 0 {
return errs
}
_, errs := executeDiffCommand(c, state, helm, c.Bool("detailed-exitcode"), c.Bool("suppress-secrets")) _, errs := executeDiffCommand(c, state, helm, c.Bool("detailed-exitcode"), c.Bool("suppress-secrets"))
return errs return errs
}) })

3
state/state.go
View File

@ -826,11 +826,8 @@ func (state *HelmState) PrepareRelease(helm helmexec.Interface, helmfileCommand
errs := []error{} errs := []error{}
for _, release := range state.Releases { for _, release := range state.Releases {
if isLocalChart(release.Chart) {
if _, err := state.triggerPrepareEvent(&release, helmfileCommand); err != nil { if _, err := state.triggerPrepareEvent(&release, helmfileCommand); err != nil {
errs = append(errs, &ReleaseError{&release, err}) errs = append(errs, &ReleaseError{&release, err})
continue
}
} }
} }
if len(errs) != 0 { if len(errs) != 0 {