public_git/helmfile
1
0
Fork 0
mirror of https://github.com/helmfile/helmfile.git synced 2026-10-09 05:30:49 +02:00
Code Issues Projects Releases Wiki Activity

change the nest level of envvals overrides for nested state files(sub-helmfiles) (#635)

Browse Source 
We added envvals overrides in the state file via #622 two days ago:

```
helmfiles:
- name: sub.helmfile.yaml
  environment:
    values:
    - mykey: myvalue
```

This change removes the `environment` level in the above cofig, so that it looks like:

```
helmfiles:
- name: sub.helmfile.yaml
  values:
  - mykey: myvalue
``

This is an inevitable breaking change towards #361. But I wanted to break it earlier so that less folks are affected.`

Ref https://github.com/roboll/helmfile/issues/361#issuecomment-497530819
This commit is contained in:
KUOKA Yusuke
2019-06-01 12:39:31 +09:00
committed by GitHub
parent 9318d8a040
commit 68b95f14d4
3 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/app/app_test.go
+5 -7
View File
@@ -664,15 +664,13 @@ func TestVisitDesiredStatesWithReleasesFiltered_EmbeddedNestedStateAdditionalEnv
"/path/to/helmfile.yaml": `
helmfiles:
- path: helmfile.d/a*.yaml
environment:
values:
- env.values.yaml
values:
- env.values.yaml
- helmfile.d/b*.yaml
- path: helmfile.d/c*.yaml
environment:
values:
- env.values.yaml
- tillerNs: INLINE_TILLER_NS_3
values:
- env.values.yaml
- tillerNs: INLINE_TILLER_NS_3
`,
"/path/to/helmfile.d/a1.yaml": `
environments: