From 5fb037c8e394f24b58eb691a3d018b5addc36e3e Mon Sep 17 00:00:00 2001 From: Daniel Poelzleithner Date: Mon, 3 Feb 2020 00:42:54 +0100 Subject: [PATCH] Fix crash on missing chart (#1087) When chart is not set, an exception without any hints occure due normalizeChart tries to access the first character of a 0 length string. Properly inform user of missing chart. --- pkg/state/state.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/state/state.go b/pkg/state/state.go index b413018b..b517a335 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -1424,6 +1424,11 @@ func (st *HelmState) BuildDeps(helm helmexec.Interface) []error { errs := []error{} for _, release := range st.Releases { + if len(release.Chart) == 0 { + errs = append(errs, errors.New("chart is required for: "+release.Name)) + continue + } + if isLocalChart(release.Chart) { if err := helm.BuildDeps(release.Name, normalizeChart(st.basePath, release.Chart)); err != nil { errs = append(errs, err)