feat: common labels for all releases in a helmfile (#1415)

This adds `comonLabels` option to helmfile by:

- Adding `CommonLabels` to HelmState
- Changing `markExcludedReleases` and `ListReleases` functions to merge common labels into release labels

Resolves #1266
This commit is contained in:
Maksym Lushpenko
2020-08-29 13:14:58 +09:00
committed by GitHub
parent 6b4b76e2bc
commit 5ca7ce15bc
5 changed files with 67 additions and 9 deletions
+6
View File
@@ -416,6 +416,12 @@ func (a *App) ListReleases(c ListConfigProvider) error {
//var releases m
for _, r := range run.state.Releases {
labels := ""
if r.Labels == nil {
r.Labels = map[string]string{}
}
for k, v := range run.state.CommonLabels {
r.Labels[k] = v
}
for k, v := range r.Labels {
labels = fmt.Sprintf("%s,%s:%s", labels, k, v)
}
+10 -7
View File
@@ -4,8 +4,6 @@ import (
"bufio"
"bytes"
"fmt"
"github.com/google/go-cmp/cmp"
"github.com/roboll/helmfile/pkg/remote"
"io"
"log"
"os"
@@ -17,6 +15,9 @@ import (
"sync"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/roboll/helmfile/pkg/remote"
"github.com/roboll/helmfile/pkg/exectest"
"gotest.tools/v3/assert"
@@ -4051,6 +4052,8 @@ releases:
func TestList(t *testing.T) {
files := map[string]string{
"/path/to/helmfile.d/first.yaml": `
commonLabels:
common: label
releases:
- name: myrelease1
chart: mychart1
@@ -4094,11 +4097,11 @@ releases:
assert.NilError(t, err)
})
expected := `NAME NAMESPACE ENABLED LABELS
myrelease1 false id:myrelease1
myrelease2 true
myrelease3 true
myrelease4 true id:myrelease1
expected := `NAME NAMESPACE ENABLED LABELS
myrelease1 false common:label,id:myrelease1
myrelease2 true common:label
myrelease3 true
myrelease4 true id:myrelease1
`
assert.Equal(t, expected, out)
}