fix needs issue when release installed is false (#997)

* fix needs issue when release installed is false

Signed-off-by: yxxhero <aiopsclub@163.com>

pkg/app/app.go

@@ -1083,7 +1083,11 @@ func (a *App) visitStatesWithSelectorsAndRemoteSupport(fileOrDir string, converg
 
 	// pre-overrides HelmState
 	fHelmStatsWithOverrides := func(st *state.HelmState) (bool, []error) {
-		st.Releases = st.GetReleasesWithOverrides()
+		var err error
+		st.Releases, err = st.GetReleasesWithOverrides()
+		if err != nil {
+			return false, []error{err}
+		}
 		return f(st)
 	}
 
@@ -1111,7 +1115,7 @@ func processFilteredReleases(st *state.HelmState, converge func(st *state.HelmSt
 
 func checkDuplicates(releases []state.ReleaseSpec) error {
 	type Key struct {
-		TillerNamespace, Name, KubeContext string
+		Namespace, Name, KubeContext string
 	}
 
 	releaseNameCounts := map[Key]int{}
@@ -1123,8 +1127,8 @@ func checkDuplicates(releases []state.ReleaseSpec) error {
 		if c > 1 {
 			var msg string
 
-			if name.TillerNamespace != "" {
+			if name.Namespace != "" {
-				msg += fmt.Sprintf(" in namespace %q", name.TillerNamespace)
+				msg += fmt.Sprintf(" in namespace %q", name.Namespace)
 			}
 
 			if name.KubeContext != "" {
@@ -1678,10 +1682,9 @@ func (a *App) status(r *Run, c StatusesConfigProvider) (bool, []error) {
 
 	var toStatus []state.ReleaseSpec
 	for _, r := range selectedReleases {
-		if !r.Desired() {
+		if r.Desired() {
-			continue
+			toStatus = append(toStatus, r)
 		}
-		toStatus = append(toStatus, r)
 	}
 
 	var errs []error
@@ -1761,7 +1764,7 @@ func (a *App) sync(r *Run, c SyncConfigProvider) (bool, []error) {
 	for _, r := range toSyncWithNeeds {
 		release := r
 		if _, deleted := releasesToDelete[state.ReleaseToID(&release)]; !deleted {
-			if release.Installed == nil || *release.Installed {
+			if r.Desired() {
 				toUpdate = append(toUpdate, release)
 			}
 			// TODO Emit error when the user opted to fail when the needed release is disabled,
@@ -1955,7 +1958,7 @@ func (a *App) withNeeds(r *Run, c DAGConfig, includeDisabled bool, f func(*state
 	for _, r := range selectedReleasesWithNeeds {
 		release := r
 		id := state.ReleaseToID(&release)
-		if release.Installed != nil && !*release.Installed {
+		if !release.Desired() {
 			releasesToUninstall[id] = release
 		} else {
 			toRender = append(toRender, release)
@@ -2040,10 +2043,9 @@ func (a *App) writeValues(r *Run, c WriteValuesConfigProvider) (bool, []error) {
 	for _, r := range toRender {
 		release := r
 		id := state.ReleaseToID(&release)
-		if release.Installed != nil && !*release.Installed {
+		if release.Desired() {
-			continue
+			releasesToWrite[id] = release
 		}
-		releasesToWrite[id] = release
 	}
 
 	var errs []error

pkg/app/app_sync_test.go

@@ -807,6 +807,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 24: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 Affected releases are:
@@ -825,6 +826,7 @@ GROUP RELEASES
 2     default/default/my-release
 
 processing releases in group 1/2: default/default/external-secrets
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 processing releases in group 2/2: default/default/my-release
 
 UPDATED RELEASES:
@@ -955,6 +957,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 24: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 Affected releases are:
@@ -967,6 +970,7 @@ GROUP RELEASES
 2     default/default/my-release
 
 processing releases in group 1/2: default/default/external-secrets
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 processing releases in group 2/2: default/default/my-release
 
 UPDATED RELEASES:

pkg/app/app_test.go

@@ -3745,6 +3745,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 err: release(s) "default//foo" depend(s) on an undefined release "default/ns1/bar". Perhaps you made a typo in "needs" or forgot defining a release named "bar" with appropriate "namespace" and "kubeContext"?

pkg/app/desired_state_file_loader.go

@@ -285,5 +285,6 @@ func (ld *desiredStateLoader) load(env, overrodeEnv *environment.Environment, ba
 		}
 	}
 
+	finalState.OrginReleases = finalState.Releases
 	return finalState, nil
 }

pkg/app/destroy_nokubectx_test.go

@@ -377,6 +377,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 processing 5 groups of releases in this order:
@@ -390,6 +391,7 @@ GROUP RELEASES
 processing releases in group 1/5: frontend-v3, frontend-v2, frontend-v1
 release "frontend-v3" processed
 release "frontend-v2" processed
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 release "frontend-v1" processed
 processing releases in group 2/5: backend-v2, backend-v1
 release "backend-v2" processed
@@ -589,6 +591,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 1 release(s) matching name=logging found in helmfile.yaml
 
 processing 1 groups of releases in this order:
@@ -657,6 +660,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 2 release(s) found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -665,6 +669,7 @@ GROUP RELEASES
 2     backend-v1
 
 processing releases in group 1/2: frontend-v1
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 release "frontend-v1" processed
 processing releases in group 2/2: backend-v1
 release "backend-v1" processed
@@ -729,6 +734,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 2 release(s) found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -737,6 +743,7 @@ GROUP RELEASES
 2     backend-v1
 
 processing releases in group 1/2: frontend-v1
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 release "frontend-v1" processed
 processing releases in group 2/2: backend-v1
 release "backend-v1" processed

pkg/app/destroy_test.go

@@ -449,6 +449,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 processing 5 groups of releases in this order:
@@ -462,6 +463,7 @@ GROUP RELEASES
 processing releases in group 1/5: default//frontend-v3, default//frontend-v2, default//frontend-v1
 release "frontend-v3" processed
 release "frontend-v2" processed
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 release "frontend-v1" processed
 processing releases in group 2/5: default//backend-v2, default//backend-v1
 release "backend-v2" processed
@@ -658,6 +660,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 1 release(s) matching name=logging found in helmfile.yaml
 
 processing 1 groups of releases in this order:
@@ -726,6 +729,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 2 release(s) found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -734,6 +738,7 @@ GROUP RELEASES
 2     default//backend-v1
 
 processing releases in group 1/2: default//frontend-v1
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 release "frontend-v1" processed
 processing releases in group 2/2: default//backend-v1
 release "backend-v1" processed
@@ -801,6 +806,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 2 release(s) found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -809,6 +815,7 @@ GROUP RELEASES
 2     default//backend-v1
 
 processing releases in group 1/2: default//frontend-v1
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 release "frontend-v1" processed
 processing releases in group 2/2: default//backend-v1
 release "backend-v1" processed

pkg/app/diff_nokubectx_test.go

@@ -946,6 +946,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 err: release(s) "foo" depend(s) on an undefined release "bar". Perhaps you made a typo in "needs" or forgot defining a release named "bar" with appropriate "namespace" and "kubeContext"?

pkg/app/diff_test.go

@@ -1295,6 +1295,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 err: release(s) "default//foo" depend(s) on an undefined release "default//bar". Perhaps you made a typo in "needs" or forgot defining a release named "bar" with appropriate "namespace" and "kubeContext"?

pkg/app/testdata/app_diff_test/bad_selector

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 0 release(s) matching app=test_non_existent found in helmfile.yaml
 
 changing working directory back to "/path/to"

pkg/app/testdata/app_diff_test/fail_on_unselected_need_by_default

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 err: release "default/default/external-secrets" depends on "default/kube-system/kubernetes-external-secrets" which does not match the selectors. Please add a selector like "--selector name=kubernetes-external-secrets", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies

pkg/app/testdata/app_diff_test/include-needs

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 4 groups of releases in this order:

pkg/app/testdata/app_diff_test/include-needs_should_not_fail_on_disabled_direct_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test2 found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -111,6 +112,7 @@ GROUP RELEASES
 
 processing releases in group 1/2: default/kube-system/disabled
 processing releases in group 2/2: default//test2
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 Affected releases are:
   disabled (incubator/raw) DELETED
 

pkg/app/testdata/app_diff_test/include-needs_should_not_fail_on_disabled_transitive_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test3 found in helmfile.yaml
 
 processing 3 groups of releases in this order:
@@ -113,6 +114,7 @@ GROUP RELEASES
 processing releases in group 1/3: default/kube-system/disabled
 processing releases in group 2/3: default//test2
 processing releases in group 3/3: default//test3
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 Affected releases are:
   disabled (incubator/raw) DELETED
 

pkg/app/testdata/app_diff_test/include-needs_with_include-transitive-needs_should_not_fail_on_disabled_direct_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test2 found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -111,6 +112,7 @@ GROUP RELEASES
 
 processing releases in group 1/2: default/kube-system/disabled
 processing releases in group 2/2: default//test2
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 Affected releases are:
   disabled (incubator/raw) DELETED
 

pkg/app/testdata/app_diff_test/include-needs_with_include-transitive-needs_should_not_fail_on_disabled_transitive_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test3 found in helmfile.yaml
 
 processing 3 groups of releases in this order:
@@ -113,6 +114,7 @@ GROUP RELEASES
 processing releases in group 1/3: default/kube-system/disabled
 processing releases in group 2/3: default//test2
 processing releases in group 3/3: default//test3
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 Affected releases are:
   disabled (incubator/raw) DELETED
 

pkg/app/testdata/app_diff_test/include-transitive-needs

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 4 groups of releases in this order:

pkg/app/testdata/app_diff_test/include-transitive-needs_should_not_fail_on_disabled_transitive_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test3 found in helmfile.yaml
 
 processing 3 groups of releases in this order:
@@ -113,6 +114,7 @@ GROUP RELEASES
 processing releases in group 1/3: default/kube-system/disabled
 processing releases in group 2/3: default//test2
 processing releases in group 3/3: default//test3
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 Affected releases are:
   disabled (incubator/raw) DELETED
 

pkg/app/testdata/app_diff_test/no-hooks

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 2 groups of releases in this order:

pkg/app/testdata/app_diff_test/skip-needs

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 2 groups of releases in this order:

pkg/app/testdata/app_diff_test_1/delete_bar_when_foo_needs_bar

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 err: release "default//foo" depends on "default//bar" which does not match the selectors. Please add a selector like "--selector name=bar", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies

pkg/app/testdata/app_diff_test_1/delete_bar_when_foo_needs_bar_with_include-needs

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -41,6 +42,7 @@ GROUP RELEASES
 
 processing releases in group 1/2: default//bar
 processing releases in group 2/2: default//foo
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 Affected releases are:
   bar (mychart2) DELETED
   foo (mychart1) UPDATED

pkg/app/testdata/app_diff_test_1/delete_bar_when_foo_needs_bar_with_skip-needs

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 processing 1 groups of releases in this order:
@@ -39,6 +40,7 @@ GROUP RELEASES
 1     default//foo
 
 processing releases in group 1/1: default//foo
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 Affected releases are:
   bar (mychart2) DELETED
   foo (mychart1) UPDATED

pkg/app/testdata/app_diff_test_1/delete_foo_and_bar_when_bar_needs_foo

@@ -34,6 +34,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/app_diff_test_1/delete_foo_and_bar_when_foo_needs_bar

@@ -34,6 +34,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/app_diff_test_1/delete_foo_when_bar_needs_foo

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 err: release "default//bar" depends on "default//foo" which does not match the selectors. Please add a selector like "--selector name=foo", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies

pkg/app/testdata/app_diff_test_1/delete_foo_when_bar_needs_foo_with_include-needs

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -41,6 +42,7 @@ GROUP RELEASES
 
 processing releases in group 1/2: default//foo
 processing releases in group 2/2: default//bar
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 Affected releases are:
   bar (mychart2) UPDATED
   foo (mychart1) DELETED

pkg/app/testdata/app_diff_test_1/delete_foo_when_bar_needs_foo_with_skip-needs

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 processing 1 groups of releases in this order:
@@ -39,6 +40,7 @@ GROUP RELEASES
 1     default//bar
 
 processing releases in group 1/1: default//bar
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 Affected releases are:
   bar (mychart2) UPDATED
   foo (mychart1) DELETED

pkg/app/testdata/app_diff_test_1/smoke

@@ -122,6 +122,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 processing 5 groups of releases in this order:

pkg/app/testdata/app_diff_test_2/delete_bar_when_foo_needs_bar

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 err: release "foo" depends on "bar" which does not match the selectors. Please add a selector like "--selector name=bar", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies

pkg/app/testdata/app_diff_test_2/delete_bar_when_foo_needs_bar_with_include-needs

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -41,6 +42,7 @@ GROUP RELEASES
 
 processing releases in group 1/2: bar
 processing releases in group 2/2: foo
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 Affected releases are:
   bar (mychart2) DELETED
   foo (mychart1) UPDATED

pkg/app/testdata/app_diff_test_2/delete_bar_when_foo_needs_bar_with_skip-needs

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 processing 1 groups of releases in this order:
@@ -39,6 +40,7 @@ GROUP RELEASES
 1     foo
 
 processing releases in group 1/1: foo
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 Affected releases are:
   bar (mychart2) DELETED
   foo (mychart1) UPDATED

pkg/app/testdata/app_diff_test_2/delete_foo_and_bar_when_bar_needs_foo

@@ -34,6 +34,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/app_diff_test_2/delete_foo_and_bar_when_foo_needs_bar

@@ -34,6 +34,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/app_diff_test_2/delete_foo_when_bar_needs_foo

@@ -32,6 +32,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 err: release "bar" depends on "foo" which does not match the selectors. Please add a selector like "--selector name=foo", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies

pkg/app/testdata/app_diff_test_2/smoke

@@ -122,6 +122,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 processing 5 groups of releases in this order:

pkg/app/testdata/app_lint_test/bad_selector

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 0 release(s) matching app=test_non_existent found in helmfile.yaml
 
 changing working directory back to "/path/to"

pkg/app/testdata/app_lint_test/fail_on_unselected_need_by_default

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 err: release "default/default/external-secrets" depends on "default/kube-system/kubernetes-external-secrets" which does not match the selectors. Please add a selector like "--selector name=kubernetes-external-secrets", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies

pkg/app/testdata/app_lint_test/include-needs

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 4 groups of releases in this order:

pkg/app/testdata/app_lint_test/include-needs_fail_on_disabled_direct_need

@@ -1,108 +0,0 @@
-processing file "helmfile.yaml" in directory "."
-changing working directory to "/path/to"
-first-pass rendering starting for "helmfile.yaml.part.0": inherited=&{default  map[] map[]}, overrode=<nil>
-first-pass uses: &{default  map[] map[]}
-first-pass rendering output of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-first-pass produced: &{default  map[] map[]}
-first-pass rendering result of "helmfile.yaml.part.0": {default  map[] map[]}
-vals:
-map[]
-defaultVals:[]
-second-pass rendering result of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-merged environment: &{default  map[] map[]}
-1 release(s) matching name=test2 found in helmfile.yaml
-
-err: release "default//test2" depends on "default/kube-system/disabled" which does not match the selectors. Please add a selector like "--selector name=disabled", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies
-changing working directory back to "/path/to"

pkg/app/testdata/app_lint_test/include-needs_fail_on_disabled_transitive_need

@@ -1,108 +0,0 @@
-processing file "helmfile.yaml" in directory "."
-changing working directory to "/path/to"
-first-pass rendering starting for "helmfile.yaml.part.0": inherited=&{default  map[] map[]}, overrode=<nil>
-first-pass uses: &{default  map[] map[]}
-first-pass rendering output of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-first-pass produced: &{default  map[] map[]}
-first-pass rendering result of "helmfile.yaml.part.0": {default  map[] map[]}
-vals:
-map[]
-defaultVals:[]
-second-pass rendering result of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-merged environment: &{default  map[] map[]}
-1 release(s) matching name=test3 found in helmfile.yaml
-
-err: release "default//test2" depends on "default/kube-system/disabled" which does not match the selectors. Please add a selector like "--selector name=disabled", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies
-changing working directory back to "/path/to"

pkg/app/testdata/app_lint_test/include-needs_should_not_fail_on_disabled_direct_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test2 found in helmfile.yaml
 
 processing 2 groups of releases in this order:

pkg/app/testdata/app_lint_test/include-needs_should_not_fail_on_disabled_transitive_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test3 found in helmfile.yaml
 
 processing 3 groups of releases in this order:

pkg/app/testdata/app_lint_test/include-needs_with_include-transitive-needs_fail_on_disabled_direct_need

@@ -1,108 +0,0 @@
-processing file "helmfile.yaml" in directory "."
-changing working directory to "/path/to"
-first-pass rendering starting for "helmfile.yaml.part.0": inherited=&{default  map[] map[]}, overrode=<nil>
-first-pass uses: &{default  map[] map[]}
-first-pass rendering output of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-first-pass produced: &{default  map[] map[]}
-first-pass rendering result of "helmfile.yaml.part.0": {default  map[] map[]}
-vals:
-map[]
-defaultVals:[]
-second-pass rendering result of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-merged environment: &{default  map[] map[]}
-2 release(s) matching name=test2 found in helmfile.yaml
-
-err: release "default//test2" depends on "default/kube-system/disabled" which does not match the selectors. Please add a selector like "--selector name=disabled", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies
-changing working directory back to "/path/to"

pkg/app/testdata/app_lint_test/include-needs_with_include-transitive-needs_fail_on_disabled_transitive_need

@@ -1,108 +0,0 @@
-processing file "helmfile.yaml" in directory "."
-changing working directory to "/path/to"
-first-pass rendering starting for "helmfile.yaml.part.0": inherited=&{default  map[] map[]}, overrode=<nil>
-first-pass uses: &{default  map[] map[]}
-first-pass rendering output of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-first-pass produced: &{default  map[] map[]}
-first-pass rendering result of "helmfile.yaml.part.0": {default  map[] map[]}
-vals:
-map[]
-defaultVals:[]
-second-pass rendering result of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-merged environment: &{default  map[] map[]}
-3 release(s) matching name=test3 found in helmfile.yaml
-
-err: release "default//test2" depends on "default/kube-system/disabled" which does not match the selectors. Please add a selector like "--selector name=disabled", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies
-changing working directory back to "/path/to"

pkg/app/testdata/app_lint_test/include-needs_with_include-transitive-needs_should_not_fail_on_disabled_direct_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test2 found in helmfile.yaml
 
 processing 2 groups of releases in this order:

pkg/app/testdata/app_lint_test/include-needs_with_include-transitive-needs_should_not_fail_on_disabled_transitive_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test3 found in helmfile.yaml
 
 processing 3 groups of releases in this order:

pkg/app/testdata/app_lint_test/include-transitive-needs

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 4 groups of releases in this order:

pkg/app/testdata/app_lint_test/include-transitive-needs_should_not_fail_on_disabled_transitive_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test3 found in helmfile.yaml
 
 processing 3 groups of releases in this order:

pkg/app/testdata/app_lint_test/skip-needs

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 2 groups of releases in this order:

pkg/app/testdata/app_list_test/default_environment_includes_all_releases

@@ -121,6 +121,7 @@ second-pass rendering result of "helmfile_1.yaml.part.1":
 43: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 changing working directory back to "/path/to"
 processing file "helmfile_2.yaml" in directory "/path/to/helmfile.d"
 changing working directory to "/path/to/helmfile.d"

pkg/app/testdata/app_list_test/filters_releases_for_environment_used_in_multiple_files

@@ -121,6 +121,7 @@ second-pass rendering result of "helmfile_1.yaml.part.1":
 43: 
 
 merged environment: &{shared  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 changing working directory back to "/path/to"
 processing file "helmfile_2.yaml" in directory "/path/to/helmfile.d"
 changing working directory to "/path/to/helmfile.d"

pkg/app/testdata/app_list_test/list_releases_matching_selector_and_environment

@@ -121,6 +121,7 @@ second-pass rendering result of "helmfile_1.yaml.part.1":
 43: 
 
 merged environment: &{development  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 changing working directory back to "/path/to"
 processing file "helmfile_2.yaml" in directory "/path/to/helmfile.d"
 changing working directory to "/path/to/helmfile.d"

pkg/app/testdata/app_template_test/bad_selector

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 0 release(s) matching app=test_non_existent found in helmfile.yaml
 
 changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/fail_on_unselected_need_by_default

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 err: release "default/default/external-secrets" depends on "default/kube-system/kubernetes-external-secrets" which does not match the selectors. Please add a selector like "--selector name=kubernetes-external-secrets", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies

pkg/app/testdata/app_template_test/include-needs

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 4 groups of releases in this order:

pkg/app/testdata/app_template_test/include-needs_fail_on_disabled_direct_need

@@ -1,108 +0,0 @@
-processing file "helmfile.yaml" in directory "."
-changing working directory to "/path/to"
-first-pass rendering starting for "helmfile.yaml.part.0": inherited=&{default  map[] map[]}, overrode=<nil>
-first-pass uses: &{default  map[] map[]}
-first-pass rendering output of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-first-pass produced: &{default  map[] map[]}
-first-pass rendering result of "helmfile.yaml.part.0": {default  map[] map[]}
-vals:
-map[]
-defaultVals:[]
-second-pass rendering result of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-merged environment: &{default  map[] map[]}
-1 release(s) matching name=test2 found in helmfile.yaml
-
-err: release "default//test2" depends on "default/kube-system/disabled" which does not match the selectors. Please add a selector like "--selector name=disabled", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies
-changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/include-needs_fail_on_disabled_transitive_need

@@ -1,108 +0,0 @@
-processing file "helmfile.yaml" in directory "."
-changing working directory to "/path/to"
-first-pass rendering starting for "helmfile.yaml.part.0": inherited=&{default  map[] map[]}, overrode=<nil>
-first-pass uses: &{default  map[] map[]}
-first-pass rendering output of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-first-pass produced: &{default  map[] map[]}
-first-pass rendering result of "helmfile.yaml.part.0": {default  map[] map[]}
-vals:
-map[]
-defaultVals:[]
-second-pass rendering result of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-merged environment: &{default  map[] map[]}
-1 release(s) matching name=test3 found in helmfile.yaml
-
-err: release "default//test2" depends on "default/kube-system/disabled" which does not match the selectors. Please add a selector like "--selector name=disabled", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies
-changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/include-needs_should_not_fail_on_disabled_direct_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test2 found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -111,4 +112,5 @@ GROUP RELEASES
 
 processing releases in group 1/2: default/kube-system/disabled
 processing releases in group 2/2: default//test2
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/include-needs_should_not_fail_on_disabled_transitive_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test3 found in helmfile.yaml
 
 processing 3 groups of releases in this order:
@@ -113,4 +114,5 @@ GROUP RELEASES
 processing releases in group 1/3: default/kube-system/disabled
 processing releases in group 2/3: default//test2
 processing releases in group 3/3: default//test3
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/include-needs_with_include-transitive-needs_fail_on_disabled_direct_need

@@ -1,108 +0,0 @@
-processing file "helmfile.yaml" in directory "."
-changing working directory to "/path/to"
-first-pass rendering starting for "helmfile.yaml.part.0": inherited=&{default  map[] map[]}, overrode=<nil>
-first-pass uses: &{default  map[] map[]}
-first-pass rendering output of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-first-pass produced: &{default  map[] map[]}
-first-pass rendering result of "helmfile.yaml.part.0": {default  map[] map[]}
-vals:
-map[]
-defaultVals:[]
-second-pass rendering result of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-merged environment: &{default  map[] map[]}
-2 release(s) matching name=test2 found in helmfile.yaml
-
-err: release "default//test2" depends on "default/kube-system/disabled" which does not match the selectors. Please add a selector like "--selector name=disabled", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies
-changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/include-needs_with_include-transitive-needs_fail_on_disabled_transitive_need

@@ -1,108 +0,0 @@
-processing file "helmfile.yaml" in directory "."
-changing working directory to "/path/to"
-first-pass rendering starting for "helmfile.yaml.part.0": inherited=&{default  map[] map[]}, overrode=<nil>
-first-pass uses: &{default  map[] map[]}
-first-pass rendering output of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-first-pass produced: &{default  map[] map[]}
-first-pass rendering result of "helmfile.yaml.part.0": {default  map[] map[]}
-vals:
-map[]
-defaultVals:[]
-second-pass rendering result of "helmfile.yaml.part.0":
- 0: 
- 1: releases:
- 2: - name: logging
- 3:   chart: incubator/raw
- 4:   namespace: kube-system
- 5: 
- 6: - name: kubernetes-external-secrets
- 7:   chart: incubator/raw
- 8:   namespace: kube-system
- 9:   needs:
-10:   - kube-system/logging
-11: 
-12: - name: external-secrets
-13:   chart: incubator/raw
-14:   namespace: default
-15:   labels:
-16:     app: test
-17:   needs:
-18:   - kube-system/kubernetes-external-secrets
-19: 
-20: - name: my-release
-21:   chart: incubator/raw
-22:   namespace: default
-23:   labels:
-24:     app: test
-25:   needs:
-26:   - default/external-secrets
-27: 
-28: 
-29: # Disabled releases are treated as missing
-30: - name: disabled
-31:   chart: incubator/raw
-32:   namespace: kube-system
-33:   installed: false
-34: 
-35: - name: test2
-36:   chart: incubator/raw
-37:   needs:
-38:   - kube-system/disabled
-39: 
-40: - name: test3
-41:   chart: incubator/raw
-42:   needs:
-43:   - test2
-44: 
-
-merged environment: &{default  map[] map[]}
-3 release(s) matching name=test3 found in helmfile.yaml
-
-err: release "default//test2" depends on "default/kube-system/disabled" which does not match the selectors. Please add a selector like "--selector name=disabled", or indicate whether to skip (--skip-needs) or include (--include-needs) these dependencies
-changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/include-needs_with_include-transitive-needs_should_not_fail_on_disabled_direct_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test2 found in helmfile.yaml
 
 processing 2 groups of releases in this order:
@@ -111,4 +112,5 @@ GROUP RELEASES
 
 processing releases in group 1/2: default/kube-system/disabled
 processing releases in group 2/2: default//test2
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/include-needs_with_include-transitive-needs_should_not_fail_on_disabled_transitive_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test3 found in helmfile.yaml
 
 processing 3 groups of releases in this order:
@@ -113,4 +114,5 @@ GROUP RELEASES
 processing releases in group 1/3: default/kube-system/disabled
 processing releases in group 2/3: default//test2
 processing releases in group 3/3: default//test3
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/include-transitive-needs

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 4 groups of releases in this order:

pkg/app/testdata/app_template_test/include-transitive-needs_should_not_fail_on_disabled_transitive_need

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 1 release(s) matching name=test3 found in helmfile.yaml
 
 processing 3 groups of releases in this order:
@@ -113,4 +114,5 @@ GROUP RELEASES
 processing releases in group 1/3: default/kube-system/disabled
 processing releases in group 2/3: default//test2
 processing releases in group 3/3: default//test3
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 changing working directory back to "/path/to"

pkg/app/testdata/app_template_test/skip-needs

@@ -102,6 +102,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 44: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release test2 needs disabled, but disabled is not installed due to installed: false. Either mark disabled as installed or remove disabled from test2's needs
 2 release(s) matching app=test found in helmfile.yaml
 
 processing 2 groups of releases in this order:

pkg/app/testdata/testapply/delete_bar_when_foo_needs_bar/log

@@ -32,8 +32,10 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 Affected releases are:
   bar (stable/mychart2) DELETED
   foo (stable/mychart1) UPDATED
@@ -55,6 +57,7 @@ GROUP RELEASES
 1     default//foo
 
 processing releases in group 1/1: default//foo
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 
 UPDATED RELEASES:
 NAME   CHART             VERSION   DURATION

pkg/app/testdata/testapply/delete_foo_and_bar_when_bar_needs_foo/log

@@ -34,6 +34,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/testapply/delete_foo_and_bar_when_foo_needs_bar/log

@@ -34,6 +34,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/testapply/delete_foo_when_bar_needs_foo/log

@@ -32,8 +32,10 @@ second-pass rendering result of "helmfile.yaml.part.0":
  9: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 Affected releases are:
   bar (stable/mychart2) UPDATED
   foo (stable/mychart1) DELETED
@@ -55,6 +57,7 @@ GROUP RELEASES
 1     default//bar
 
 processing releases in group 1/1: default//bar
+WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 
 UPDATED RELEASES:
 NAME   CHART             VERSION   DURATION

pkg/app/testdata/testapply/smoke/log

@@ -122,6 +122,7 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/testapply_2/skip-needs=false_include-needs=true_with_installed_but_disabled_release/log

@@ -62,8 +62,10 @@ second-pass rendering result of "helmfile.yaml.part.0":
 24: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 2 release(s) matching app=test found in helmfile.yaml
 
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 Affected releases are:
   external-secrets (incubator/raw) UPDATED
   kubernetes-external-secrets (incubator/raw) DELETED
@@ -89,6 +91,7 @@ GROUP RELEASES
 2     default/default/my-release
 
 processing releases in group 1/2: default/default/external-secrets
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 processing releases in group 2/2: default/default/my-release
 
 UPDATED RELEASES:

pkg/app/testdata/testapply_2/skip-needs=false_include-needs=true_with_not_installed_and_disabled_release/log

@@ -62,8 +62,10 @@ second-pass rendering result of "helmfile.yaml.part.0":
 24: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 2 release(s) matching app=test found in helmfile.yaml
 
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 Affected releases are:
   external-secrets (incubator/raw) UPDATED
   my-release (incubator/raw) UPDATED
@@ -83,6 +85,7 @@ GROUP RELEASES
 2     default/default/my-release
 
 processing releases in group 1/2: default/default/external-secrets
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 processing releases in group 2/2: default/default/my-release
 
 UPDATED RELEASES:

pkg/app/testdata/testapply_3/skip-needs=false_include-needs=true_with_installed_but_disabled_release/log

@@ -62,8 +62,10 @@ second-pass rendering result of "helmfile.yaml.part.0":
 24: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 2 release(s) matching app=test found in helmfile.yaml
 
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 Affected releases are:
   external-secrets (incubator/raw) UPDATED
   kubernetes-external-secrets (incubator/raw) DELETED
@@ -89,6 +91,7 @@ GROUP RELEASES
 2     default/my-release
 
 processing releases in group 1/2: default/external-secrets
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 processing releases in group 2/2: default/my-release
 
 UPDATED RELEASES:

pkg/app/testdata/testapply_3/skip-needs=false_include-needs=true_with_not_installed_and_disabled_release/log

@@ -62,8 +62,10 @@ second-pass rendering result of "helmfile.yaml.part.0":
 24: 
 
 merged environment: &{default  map[] map[]}
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 2 release(s) matching app=test found in helmfile.yaml
 
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 Affected releases are:
   external-secrets (incubator/raw) UPDATED
   my-release (incubator/raw) UPDATED
@@ -83,6 +85,7 @@ GROUP RELEASES
 2     default/my-release
 
 processing releases in group 1/2: default/external-secrets
+WARNING: release external-secrets needs kubernetes-external-secrets, but kubernetes-external-secrets is not installed due to installed: false. Either mark kubernetes-external-secrets as installed or remove kubernetes-external-secrets from external-secrets's needs
 processing releases in group 2/2: default/my-release
 
 UPDATED RELEASES:

pkg/state/selector_test.go

@@ -110,7 +110,12 @@ func TestSelectReleasesWithOverrides(t *testing.T) {
 	for _, tc := range testcases {
 		state.Selectors = tc.selector
 
-		state.Releases = state.GetReleasesWithOverrides()
+		releases, err := state.GetReleasesWithOverrides()
+		state.Releases = releases
+
+		if err != nil {
+			t.Fatalf("%s %s: %v", tc.selector, tc.subject, err)
+		}
 
 		rs, err := state.GetSelectedReleases(false)
 		if err != nil {
@@ -180,7 +185,12 @@ func TestSelectReleasesWithOverridesWithIncludedTransitives(t *testing.T) {
 
 	for _, tc := range testcases {
 		state.Selectors = tc.selector
-		state.Releases = state.GetReleasesWithOverrides()
+		releases, err := state.GetReleasesWithOverrides()
+		if err != nil {
+			t.Fatalf("%s %s: %v", tc.selector, tc.subject, err)
+		}
+
+		state.Releases = releases
 
 		rs, err := state.GetSelectedReleases(tc.includeTransitiveNeeds)
 		if err != nil {

pkg/state/state.go

@@ -67,6 +67,7 @@ type ReleaseSetSpec struct {
 	Repositories        []RepositorySpec  `yaml:"repositories,omitempty"`
 	CommonLabels        map[string]string `yaml:"commonLabels,omitempty"`
 	Releases            []ReleaseSpec     `yaml:"releases,omitempty"`
+	OrginReleases       []ReleaseSpec     `yaml:"-"`
 	Selectors           []string          `yaml:"-"`
 
 	// Capabilities.APIVersions
@@ -290,7 +291,7 @@ type ReleaseSpec struct {
 	// MissingFileHandler is set to either "Error" or "Warn". "Error" instructs helmfile to fail when unable to find a values or secrets file. When "Warn", it prints the file and continues.
 	// The default value for MissingFileHandler is "Error".
 	MissingFileHandler *string `yaml:"missingFileHandler,omitempty"`
-	// Needs is the [TILLER_NS/][NS/]NAME representations of releases that this release depends on.
+	// Needs is the [KUBECONTEXT/][NS/]NAME representations of releases that this release depends on.
 	Needs []string `yaml:"needs,omitempty"`
 
 	// Hooks is a list of extension points paired with operations, that are executed in specific points of the lifecycle of releases defined in helmfile
@@ -458,15 +459,12 @@ var DefaultFetchOutputDirTemplate = filepath.Join(
 	"{{ or .Release.Version \"latest\" }}",
 )
 
-func (st *HelmState) ApplyOverrides(spec *ReleaseSpec) {
+func (st *HelmState) reformat(spec *ReleaseSpec) []string {
-	if st.OverrideKubeContext != "" {
-		spec.KubeContext = st.OverrideKubeContext
-	}
-	if st.OverrideNamespace != "" {
-		spec.Namespace = st.OverrideNamespace
-	}
-
 	var needs []string
+	releaseInstalledInfo := make(map[string]bool)
+	for _, r := range st.OrginReleases {
+		releaseInstalledInfo[r.Name] = r.Desired()
+	}
 
 	// Since the representation differs between needs and id,
 	// correct it by prepending Namespace and KubeContext.
@@ -478,6 +476,9 @@ func (st *HelmState) ApplyOverrides(spec *ReleaseSpec) {
 		components := strings.Split(n, "/")
 
 		name = components[len(components)-1]
+		if !releaseInstalledInfo[name] {
+			st.logger.Warnf("WARNING: %s", fmt.Sprintf("release %s needs %s, but %s is not installed due to installed: false. Either mark %s as installed or remove %s from %s's needs", spec.Name, name, name, name, name, spec.Name))
+		}
 
 		if len(components) > 1 {
 			ns = components[len(components)-2]
@@ -512,8 +513,18 @@ func (st *HelmState) ApplyOverrides(spec *ReleaseSpec) {
 
 		needs = append(needs, strings.Join(componentsAfterOverride, "/"))
 	}
+	return needs
+}
 
-	spec.Needs = needs
+func (st *HelmState) ApplyOverrides(spec *ReleaseSpec) {
+	if st.OverrideKubeContext != "" {
+		spec.KubeContext = st.OverrideKubeContext
+	}
+	if st.OverrideNamespace != "" {
+		spec.Namespace = st.OverrideNamespace
+	}
+
+	spec.Needs = st.reformat(spec)
 }
 
 type RepoUpdater interface {
@@ -610,6 +621,7 @@ func (st *HelmState) prepareSyncReleases(helm helmexec.Interface, additionalValu
 		},
 		func(workerIndex int) {
 			for release := range jobs {
+				errs := []*ReleaseError{}
 				st.ApplyOverrides(release)
 
 				// If `installed: false`, the only potential operation on this release would be uninstalling.
@@ -633,7 +645,6 @@ func (st *HelmState) prepareSyncReleases(helm helmexec.Interface, additionalValu
 					continue
 				}
 
-				errs := []*ReleaseError{}
 				for _, value := range additionalValues {
 					valfile, err := filepath.Abs(value)
 					if err != nil {
@@ -1054,10 +1065,9 @@ func releasesNeedCharts(releases []ReleaseSpec) []ReleaseSpec {
 	var result []ReleaseSpec
 
 	for _, r := range releases {
-		if !r.Desired() {
+		if r.Desired() {
-			continue
+			result = append(result, r)
 		}
-		result = append(result, r)
 	}
 
 	return result
@@ -2178,14 +2188,14 @@ func (st *HelmState) Clean() []error {
 	return nil
 }
 
-func (st *HelmState) GetReleasesWithOverrides() []ReleaseSpec {
+func (st *HelmState) GetReleasesWithOverrides() ([]ReleaseSpec, error) {
 	var rs []ReleaseSpec
 	for _, r := range st.Releases {
 		spec := r
 		st.ApplyOverrides(&spec)
 		rs = append(rs, spec)
 	}
-	return rs
+	return rs, nil
 }
 
 func (st *HelmState) SelectReleases(includeTransitiveNeeds bool) ([]Release, error) {