panic with a clear message (#1693)

This commit is contained in:
Quan TRAN 2021-03-04 01:32:50 +01:00 committed by GitHub
parent 42c97cd919
commit 56405e7445
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions

View File

@ -1988,8 +1988,12 @@ func markExcludedReleases(releases []ReleaseSpec, selectors []string, commonLabe
if len(conditionSplit) != 2 { if len(conditionSplit) != 2 {
return nil, fmt.Errorf("Condition value must be in the form 'foo.enabled' where 'foo' can be modified as necessary") return nil, fmt.Errorf("Condition value must be in the form 'foo.enabled' where 'foo' can be modified as necessary")
} }
if values[conditionSplit[0]].(map[string]interface{})["enabled"] == true { if v, ok := values[conditionSplit[0]]; ok {
conditionMatch = true if v.(map[string]interface{})["enabled"] == true {
conditionMatch = true
}
} else {
panic(fmt.Sprintf("environment values does not contain field %s", conditionSplit[0]))
} }
} }
res := Release{ res := Release{