public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: duration of delete failures are always 0s (#1734)

This commit is contained in:
Felipe Santos 2024-10-11 19:58:38 -03:00 committed by GitHub
parent cd0f603d4f
commit 4beb2ac042
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/state/state.go
View File

@ -2138,17 +2138,23 @@ func (st *HelmState) DeleteReleases(affectedReleases *AffectedReleases, helm hel
start := time.Now() start := time.Now()
if _, err := st.triggerReleaseEvent("preuninstall", nil, &release, "delete"); err != nil { if _, err := st.triggerReleaseEvent("preuninstall", nil, &release, "delete"); err != nil {
release.duration = time.Since(start)
affectedReleases.Failed = append(affectedReleases.Failed, &release) affectedReleases.Failed = append(affectedReleases.Failed, &release)
return err return err
} }
if err := helm.DeleteRelease(context, release.Name, flags...); err != nil { if err := helm.DeleteRelease(context, release.Name, flags...); err != nil {
release.duration = time.Since(start)
affectedReleases.Failed = append(affectedReleases.Failed, &release) affectedReleases.Failed = append(affectedReleases.Failed, &release)
return err return err
} }
if _, err := st.triggerReleaseEvent("postuninstall", nil, &release, "delete"); err != nil { if _, err := st.triggerReleaseEvent("postuninstall", nil, &release, "delete"); err != nil {
release.duration = time.Since(start)
affectedReleases.Failed = append(affectedReleases.Failed, &release) affectedReleases.Failed = append(affectedReleases.Failed, &release)
return err return err
} }