feat: Support for helm's --set-file

Resolves #207
This commit is contained in:
Yusuke KUOKA
2018-08-24 13:06:31 +09:00
parent 013276f576
commit 48e65791c0
3 changed files with 36 additions and 4 deletions
+6 -3
View File
@@ -81,6 +81,7 @@ type ReleaseSpec struct {
type SetValue struct {
Name string `yaml:"name"`
Value string `yaml:"value"`
File string `yaml:"file"`
}
// CreateFromFile loads the helmfile from disk and processes the template
@@ -757,11 +758,13 @@ func (state *HelmState) namespaceAndValuesFlags(helm helmexec.Interface, basePat
flags = append(flags, "--values", valfile)
}
if len(release.SetValues) > 0 {
val := []string{}
for _, set := range release.SetValues {
val = append(val, fmt.Sprintf("%s=%s", escape(set.Name), escape(set.Value)))
if set.Value != "" {
flags = append(flags, "--set", fmt.Sprintf("%s=%s", escape(set.Name), escape(set.Value)))
} else if set.File != "" {
flags = append(flags, "--set-file", fmt.Sprintf("%s=%s", escape(set.Name), set.File))
}
}
flags = append(flags, "--set", strings.Join(val, ","))
}
/***********
+26 -1
View File
@@ -704,7 +704,32 @@ func TestHelmState_SyncReleases(t *testing.T) {
},
},
helm: &mockHelmExec{},
wantReleases: []mockRelease{{"releaseName", []string{"--set", "someList=a\\,b\\,c,json=\\{\"name\": \"john\"\\}"}}},
wantReleases: []mockRelease{{"releaseName", []string{"--set", "someList=a\\,b\\,c", "--set", "json=\\{\"name\": \"john\"\\}"}}},
},
{
name: "set single value from file",
releases: []ReleaseSpec{
{
Name: "releaseName",
Chart: "foo",
SetValues: []SetValue{
{
Name: "foo",
Value: "FOO",
},
{
Name: "bar",
File: "path/to/bar",
},
{
Name: "baz",
Value: "BAZ",
},
},
},
},
helm: &mockHelmExec{},
wantReleases: []mockRelease{{"releaseName", []string{"--set", "foo=FOO", "--set-file", "bar=path/to/bar", "--set", "baz=BAZ"}}},
},
}
for _, tt := range tests {