public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Apply suggestions from Copilot code review 

Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
This commit is contained in:
Simon Bouchard 2025-09-19 20:19:41 -04:00
parent 32afe9de42
commit 422ac1ecef
No known key found for this signature in database
GPG Key ID: F20152B81CECA893
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/state/state.go
View File

@ -1111,7 +1111,7 @@ func (st *HelmState) performSyncOrReinstallOfRelease(affectedReleases *AffectedR
st.logger.Debugf("update strategy - sync failed: %s", err.Error()) st.logger.Debugf("update strategy - sync failed: %s", err.Error())
// Only fail if a different error than forbidden updates // Only fail if a different error than forbidden updates
if !strings.Contains(err.Error(), "Forbidden: updates") { if !strings.Contains(err.Error(), "Forbidden: updates") {
st.logger.Debugf("update strategy - sync failed not due to Fobidden updates") st.logger.Debugf("update strategy - sync failed not due to Forbidden updates")
m.Lock() m.Lock()
affectedReleases.Failed = append(affectedReleases.Failed, release) affectedReleases.Failed = append(affectedReleases.Failed, release)
m.Unlock() m.Unlock()

8
pkg/state/state_test.go
View File

@ -1730,17 +1730,17 @@ func TestHelmState_SyncReleasesAffectedReleasesWithReinstallIfForbidden(t *testi
affectedReleases := AffectedReleases{} affectedReleases := AffectedReleases{}
if err := state.SyncReleases(&affectedReleases, helm, []string{}, 1); err != nil { if err := state.SyncReleases(&affectedReleases, helm, []string{}, 1); err != nil {
if !testEq(affectedReleases.Failed, tt.wantAffected.Failed) { if !testEq(affectedReleases.Failed, tt.wantAffected.Failed) {
t.Errorf("HelmState.SynchAffectedRelease() error failed for [%s] = %v, want %v", tt.name, affectedReleases.Failed, tt.wantAffected.Failed) t.Errorf("HelmState.SyncReleases() error failed for [%s] = %v, want %v", tt.name, affectedReleases.Failed, tt.wantAffected.Failed)
} //else expected error } //else expected error
} }
if !testEq(affectedReleases.Upgraded, tt.wantAffected.Upgraded) { if !testEq(affectedReleases.Upgraded, tt.wantAffected.Upgraded) {
t.Errorf("HelmState.SynchAffectedRelease() upgrade failed for [%s] = %v, want %v", tt.name, affectedReleases.Upgraded, tt.wantAffected.Upgraded) t.Errorf("HelmState.SyncReleases() upgrade failed for [%s] = %v, want %v", tt.name, affectedReleases.Upgraded, tt.wantAffected.Upgraded)
} }
if !testEq(affectedReleases.Reinstalled, tt.wantAffected.Reinstalled) { if !testEq(affectedReleases.Reinstalled, tt.wantAffected.Reinstalled) {
t.Errorf("HelmState.SynchAffectedRelease() reinstalled failed for [%s] = %v, want %v", tt.name, affectedReleases.Reinstalled, tt.wantAffected.Reinstalled) t.Errorf("HelmState.SyncReleases() reinstalled failed for [%s] = %v, want %v", tt.name, affectedReleases.Reinstalled, tt.wantAffected.Reinstalled)
} }
if !testEq(affectedReleases.Deleted, tt.wantAffected.Deleted) { if !testEq(affectedReleases.Deleted, tt.wantAffected.Deleted) {
t.Errorf("HelmState.SynchAffectedRelease() deleted failed for [%s] = %v, want %v", tt.name, affectedReleases.Deleted, tt.wantAffected.Deleted) t.Errorf("HelmState.SyncReleases() deleted failed for [%s] = %v, want %v", tt.name, affectedReleases.Deleted, tt.wantAffected.Deleted)
} }
}) })
} }