From 3bbd81624702fb4568b6c5843211e593a9ed2665 Mon Sep 17 00:00:00 2001 From: yxxhero <11087727+yxxhero@users.noreply.github.com> Date: Thu, 18 May 2023 12:34:18 +0800 Subject: [PATCH] fix extra args missing in helmfile apply subcommand (#858) Signed-off-by: yxxhero --- pkg/app/app.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/app/app.go b/pkg/app/app.go index 2af72709..d1e1f6c5 100644 --- a/pkg/app/app.go +++ b/pkg/app/app.go @@ -1315,6 +1315,8 @@ func (a *App) apply(r *Run, c ApplyConfigProvider) (bool, bool, []error) { st := r.state helm := r.helm + helm.SetExtraArgs(argparser.GetArgs(c.Args(), r.state)...) + selectedReleases, selectedAndNeededReleases, err := a.getSelectedReleases(r, c.IncludeTransitiveNeeds()) if err != nil { return false, false, []error{err} @@ -1425,8 +1427,6 @@ Do you really want to apply? return true, false, preapplyErrors } - r.helm.SetExtraArgs(argparser.GetArgs(c.Args(), r.state)...) - // We deleted releases by traversing the DAG in reverse order if len(releasesToBeDeleted) > 0 { _, deletionErrs := withDAG(st, helm, a.Logger, state.PlanOptions{Reverse: true, SelectedReleases: toDelete, SkipNeeds: true}, a.WrapWithoutSelector(func(subst *state.HelmState, helm helmexec.Interface) []error {