Merge pull request #458 from helmfile/455-chartify-not-applied-to-needed-releases

fix: needs logic in chart stage

pkg/app/app.go

@@ -164,6 +164,7 @@ func (a *App) Diff(c DiffConfigProvider) error {
 			IncludeCRDs:            &includeCRDs,
 			Validate:               c.Validate(),
 			Concurrency:            c.Concurrency(),
+			IncludeTransitiveNeeds: c.IncludeNeeds(),
 		}, func() {
 			msg, matched, affected, errs = a.diff(run, c)
 		})
@@ -232,6 +233,7 @@ func (a *App) Template(c TemplateConfigProvider) error {
 			SkipCleanup:            c.SkipCleanup(),
 			Validate:               c.Validate(),
 			Concurrency:            c.Concurrency(),
+			IncludeTransitiveNeeds: c.IncludeNeeds(),
 		}, func() {
 			ok, errs = a.template(run, c)
 		})
@@ -305,6 +307,7 @@ func (a *App) Lint(c LintConfigProvider) error {
 			SkipDeps:               c.SkipDeps(),
 			SkipCleanup:            c.SkipCleanup(),
 			Concurrency:            c.Concurrency(),
+			IncludeTransitiveNeeds: c.IncludeNeeds(),
 		}, func() {
 			ok, lintErrs, errs = a.lint(run, c)
 		})
@@ -360,7 +363,7 @@ func (a *App) Sync(c SyncConfigProvider) error {
 			Wait:                   c.Wait(),
 			WaitForJobs:            c.WaitForJobs(),
 			IncludeCRDs:            &includeCRDs,
-			IncludeTransitiveNeeds: c.IncludeTransitiveNeeds(),
+			IncludeTransitiveNeeds: c.IncludeNeeds(),
 			Validate:               c.Validate(),
 			Concurrency:            c.Concurrency(),
 		}, func() {
@@ -396,6 +399,7 @@ func (a *App) Apply(c ApplyConfigProvider) error {
 			SkipCleanup:            c.RetainValuesFiles() || c.SkipCleanup(),
 			Validate:               c.Validate(),
 			Concurrency:            c.Concurrency(),
+			IncludeTransitiveNeeds: c.IncludeNeeds(),
 		}, func() {
 			matched, updated, es := a.apply(run, c)
 

pkg/app/app_test.go

@@ -2270,7 +2270,7 @@ func (c configImpl) SkipTests() bool {
 }
 
 func (c configImpl) IncludeNeeds() bool {
-	return c.includeNeeds
+	return c.includeNeeds || c.IncludeTransitiveNeeds()
 }
 
 func (c configImpl) IncludeTransitiveNeeds() bool {
@@ -2382,7 +2382,7 @@ func (a applyConfig) SkipNeeds() bool {
 }
 
 func (a applyConfig) IncludeNeeds() bool {
-	return a.includeNeeds
+	return a.includeNeeds || a.IncludeTransitiveNeeds()
 }
 
 func (a applyConfig) IncludeTransitiveNeeds() bool {

pkg/app/diff_test.go

@@ -78,7 +78,7 @@ func (a diffConfig) SkipNeeds() bool {
 }
 
 func (a diffConfig) IncludeNeeds() bool {
-	return a.includeNeeds
+	return a.includeNeeds || a.IncludeTransitiveNeeds()
 }
 
 func (a diffConfig) IncludeTransitiveNeeds() bool {

test/integration/chart-needs-golden/diff

@@ -0,0 +1,927 @@
+********************
+
+	Release was not present in Helm.  Diff will show entire contents as new.
+
+********************
+- 
++ # Source: azuredisk-csi-storageclass/templates/azuredisk-csi-storageclass.yaml
++ # Source: azuredisk-csi-storageclass/templates/azuredisk-csi-storageclass.yaml
++ apiVersion: storage.k8s.io/v1
++ kind: StorageClass
++ metadata:
++   name: managed-csi
++ provisioner: disk.csi.azure.com
++ parameters:
++   skuName: Premium_LRS
++ reclaimPolicy: Retain
++ volumeBindingMode: Immediate
++ allowVolumeExpansion: true
+
+Comparing release=azuredisk-csi-driver, chart=azuredisk-csi-driver/azuredisk-csi-driver
+********************
+
+	Release was not present in Helm.  Diff will show entire contents as new.
+
+********************
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRoleBinding
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: azuredisk-csi-attacher-binding
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ subjects:
++   - kind: ServiceAccount
++     name: csi-azuredisk-controller-sa
++ roleRef:
++   kind: ClusterRole
++   name: azuredisk-external-attacher-role
++   apiGroup: rbac.authorization.k8s.io
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRoleBinding
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: azuredisk-csi-provisioner-binding
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ subjects:
++   - kind: ServiceAccount
++     name: csi-azuredisk-controller-sa
++ roleRef:
++   kind: ClusterRole
++   name: azuredisk-external-provisioner-role
++   apiGroup: rbac.authorization.k8s.io
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRoleBinding
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: azuredisk-csi-resizer-role
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ subjects:
++   - kind: ServiceAccount
++     name: csi-azuredisk-controller-sa
++ roleRef:
++   kind: ClusterRole
++   name: azuredisk-external-resizer-role
++   apiGroup: rbac.authorization.k8s.io
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRoleBinding
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: azuredisk-csi-snapshotter-binding
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ subjects:
++   - kind: ServiceAccount
++     name: csi-azuredisk-controller-sa
++ roleRef:
++   kind: ClusterRole
++   name: azuredisk-external-snapshotter-role
++   apiGroup: rbac.authorization.k8s.io
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRole
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: azuredisk-external-attacher-role
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ rules:
++   - apiGroups: [""]
++     resources: ["persistentvolumes"]
++     verbs: ["get", "list", "watch", "update"]
++   - apiGroups: [""]
++     resources: ["nodes"]
++     verbs: ["get", "list", "watch"]
++   - apiGroups: ["csi.storage.k8s.io"]
++     resources: ["csinodeinfos"]
++     verbs: ["get", "list", "watch"]
++   - apiGroups: ["storage.k8s.io"]
++     resources: ["volumeattachments"]
++     verbs: ["get", "list", "watch", "update", "patch"]
++   - apiGroups: ["storage.k8s.io"]
++     resources: ["volumeattachments/status"]
++     verbs: ["get", "list", "watch", "update", "patch"]
++   - apiGroups: ["coordination.k8s.io"]
++     resources: ["leases"]
++     verbs: ["get", "watch", "list", "delete", "update", "create", "patch"]
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRole
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: azuredisk-external-provisioner-role
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ rules:
++   - apiGroups: [""]
++     resources: ["persistentvolumes"]
++     verbs: ["get", "list", "watch", "create", "delete"]
++   - apiGroups: [""]
++     resources: ["persistentvolumeclaims"]
++     verbs: ["get", "list", "watch", "update"]
++   - apiGroups: ["storage.k8s.io"]
++     resources: ["storageclasses"]
++     verbs: ["get", "list", "watch"]
++   - apiGroups: [""]
++     resources: ["events"]
++     verbs: ["get", "list", "watch", "create", "update", "patch"]
++   - apiGroups: ["storage.k8s.io"]
++     resources: ["csinodes"]
++     verbs: ["get", "list", "watch"]
++   - apiGroups: [""]
++     resources: ["nodes"]
++     verbs: ["get", "list", "watch"]
++   - apiGroups: ["snapshot.storage.k8s.io"]
++     resources: ["volumesnapshots"]
++     verbs: ["get", "list"]
++   - apiGroups: ["snapshot.storage.k8s.io"]
++     resources: ["volumesnapshotcontents"]
++     verbs: ["get", "list"]
++   - apiGroups: ["coordination.k8s.io"]
++     resources: ["leases"]
++     verbs: ["get", "watch", "list", "delete", "update", "create", "patch"]
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRole
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: azuredisk-external-resizer-role
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ rules:
++   - apiGroups: [""]
++     resources: ["persistentvolumes"]
++     verbs: ["get", "list", "watch", "update", "patch"]
++   - apiGroups: [""]
++     resources: ["persistentvolumeclaims"]
++     verbs: ["get", "list", "watch"]
++   - apiGroups: [""]
++     resources: ["persistentvolumeclaims/status"]
++     verbs: ["update", "patch"]
++   - apiGroups: [""]
++     resources: ["events"]
++     verbs: ["list", "watch", "create", "update", "patch"]
++   - apiGroups: ["coordination.k8s.io"]
++     resources: ["leases"]
++     verbs: ["get", "watch", "list", "delete", "update", "create", "patch"]
++   - apiGroups: [""]
++     resources: ["pods"]
++     verbs: ["get", "list", "watch"]
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRole
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: azuredisk-external-snapshotter-role
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ rules:
++   - apiGroups: [""]
++     resources: ["events"]
++     verbs: ["list", "watch", "create", "update", "patch"]
++   - apiGroups: [""]
++     resources: ["secrets"]
++     verbs: ["get", "list"]
++   - apiGroups: ["snapshot.storage.k8s.io"]
++     resources: ["volumesnapshotclasses"]
++     verbs: ["get", "list", "watch"]
++   - apiGroups: ["snapshot.storage.k8s.io"]
++     resources: ["volumesnapshotcontents"]
++     verbs: ["create", "get", "list", "watch", "update", "delete", "patch"]
++   - apiGroups: ["snapshot.storage.k8s.io"]
++     resources: ["volumesnapshotcontents/status"]
++     verbs: ["update", "patch"]
++   - apiGroups: ["coordination.k8s.io"]
++     resources: ["leases"]
++     verbs: ["get", "watch", "list", "delete", "update", "create", "patch"]
+- 
++ # Source: azuredisk-csi-driver/templates/csi-azuredisk-controller.yaml
++ kind: Deployment
++ apiVersion: apps/v1
++ metadata:
++   name: csi-azuredisk-controller
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ spec:
++   replicas: 2
++   selector:
++     matchLabels:
++       app: csi-azuredisk-controller
++   template:
++     metadata:
++       labels:
++         app.kubernetes.io/instance: "azuredisk-csi-driver"
++         app.kubernetes.io/managed-by: "Helm"
++         app.kubernetes.io/name: "azuredisk-csi-driver"
++         app.kubernetes.io/version: "v1.23.0"
++         helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++         app: csi-azuredisk-controller
++     spec:
++       hostNetwork: true
++       serviceAccountName: csi-azuredisk-controller-sa
++       nodeSelector:
++         kubernetes.io/os: linux
++       priorityClassName: system-cluster-critical
++       tolerations:
++         - effect: NoSchedule
++           key: node-role.kubernetes.io/master
++           operator: Exists
++         - effect: NoSchedule
++           key: node-role.kubernetes.io/controlplane
++           operator: Exists
++         - effect: NoSchedule
++           key: node-role.kubernetes.io/control-plane
++           operator: Exists      
++       containers:
++         - name: csi-provisioner
++           image: "mcr.microsoft.com/oss/kubernetes-csi/csi-provisioner:v3.2.0"
++           args:
++             - "--feature-gates=Topology=true"
++             - "--csi-address=$(ADDRESS)"
++             - "--v=2"
++             - "--timeout=15s"
++             - "--leader-election"
++             - "--worker-threads=50"
++             - "--extra-create-metadata=true"
++             - "--strict-topology=true"
++           env:
++             - name: ADDRESS
++               value: /csi/csi.sock
++           volumeMounts:
++             - mountPath: /csi
++               name: socket-dir
++           resources:
++             limits:
++               memory: 500Mi
++             requests:
++               cpu: 10m
++               memory: 20Mi
++         - name: csi-attacher
++           image: "mcr.microsoft.com/oss/kubernetes-csi/csi-attacher:v3.5.0"
++           args:
++             - "-v=2"
++             - "-csi-address=$(ADDRESS)"
++             - "-timeout=1200s"
++             - "-leader-election"
++             - "-worker-threads=500"
++           env:
++             - name: ADDRESS
++               value: /csi/csi.sock
++           volumeMounts:
++           - mountPath: /csi
++             name: socket-dir
++           resources:
++             limits:
++               memory: 500Mi
++             requests:
++               cpu: 10m
++               memory: 20Mi
++         - name: csi-snapshotter
++           image: "mcr.microsoft.com/oss/kubernetes-csi/csi-snapshotter:v5.0.1"
++           args:
++             - "-csi-address=$(ADDRESS)"
++             - "-leader-election"
++             - "-v=2"
++           env:
++             - name: ADDRESS
++               value: /csi/csi.sock
++           volumeMounts:
++             - name: socket-dir
++               mountPath: /csi
++           resources:
++             limits:
++               memory: 100Mi
++             requests:
++               cpu: 10m
++               memory: 20Mi
++         - name: csi-resizer
++           image: "mcr.microsoft.com/oss/kubernetes-csi/csi-resizer:v1.5.0"
++           args:
++             - "-csi-address=$(ADDRESS)"
++             - "-v=2"
++             - "-leader-election"
++             - '-handle-volume-inuse-error=false'
++             - '-feature-gates=RecoverVolumeExpansionFailure=true'
++             - "-timeout=240s"
++           env:
++             - name: ADDRESS
++               value: /csi/csi.sock
++           volumeMounts:
++             - name: socket-dir
++               mountPath: /csi
++           resources:
++             limits:
++               memory: 500Mi
++             requests:
++               cpu: 10m
++               memory: 20Mi
++         - name: liveness-probe
++           image: "mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.7.0"
++           args:
++             - --csi-address=/csi/csi.sock
++             - --probe-timeout=3s
++             - --health-port=29602
++             - --v=2
++           volumeMounts:
++             - name: socket-dir
++               mountPath: /csi
++           resources:
++             limits:
++               memory: 100Mi
++             requests:
++               cpu: 10m
++               memory: 20Mi
++         - name: azuredisk
++           image: "mcr.microsoft.com/oss/kubernetes-csi/azuredisk-csi:v1.23.0"
++           args:
++             - "--v=5"
++             - "--endpoint=$(CSI_ENDPOINT)"
++             - "--metrics-address=0.0.0.0:29604"
++             - "--disable-avset-nodes=false"
++             - "--vm-type="
++             - "--drivername=disk.csi.azure.com"
++             - "--cloud-config-secret-name=azure-cloud-provider"
++             - "--cloud-config-secret-namespace=kube-system"
++             - "--custom-user-agent="
++             - "--user-agent-suffix=OSS-helm"
++             - "--allow-empty-cloud-config=false"
++             - "--vmss-cache-ttl-seconds=-1"
++           ports:
++             - containerPort: 29602
++               name: healthz
++               protocol: TCP
++             - containerPort: 29604
++               name: metrics
++               protocol: TCP
++           livenessProbe:
++             failureThreshold: 5
++             httpGet:
++               path: /healthz
++               port: healthz
++             initialDelaySeconds: 30
++             timeoutSeconds: 10
++             periodSeconds: 30
++           env:
++             - name: AZURE_CREDENTIAL_FILE
++               valueFrom:
++                 configMapKeyRef:
++                   name: azure-cred-file
++                   key: path
++                   optional: true
++             - name: CSI_ENDPOINT
++               value: unix:///csi/csi.sock
++             - name: AZURE_GO_SDK_LOG_LEVEL
++               value: 
++           imagePullPolicy: IfNotPresent
++           volumeMounts:
++             - mountPath: /csi
++               name: socket-dir
++             - mountPath: /etc/kubernetes/
++               name: azure-cred
++           resources:
++             limits:
++               memory: 500Mi
++             requests:
++               cpu: 10m
++               memory: 20Mi
++       volumes:
++         - name: socket-dir
++           emptyDir: {}
++         - name: azure-cred
++           hostPath:
++             path: /etc/kubernetes/
++             type: DirectoryOrCreate
+- 
++ # Source: azuredisk-csi-driver/templates/serviceaccount-csi-azuredisk-controller.yaml
++ apiVersion: v1
++ kind: ServiceAccount
++ metadata:
++   name: csi-azuredisk-controller-sa
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRoleBinding
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: csi-azuredisk-controller-secret-binding
++ subjects:
++   - kind: ServiceAccount
++     name: csi-azuredisk-controller-sa
++ roleRef:
++   kind: ClusterRole
++   name: csi-azuredisk-controller-secret-role
++   apiGroup: rbac.authorization.k8s.io
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
++ kind: ClusterRole
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: csi-azuredisk-controller-secret-role
++ rules:
++   - apiGroups: [""]
++     resources: ["secrets"]
++     verbs: ["get"]
+- 
++ # Source: azuredisk-csi-driver/templates/csi-azuredisk-node.yaml
++ kind: DaemonSet
++ apiVersion: apps/v1
++ metadata:
++   name: csi-azuredisk-node
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ spec:
++   updateStrategy:
++     rollingUpdate:
++       maxUnavailable: 1
++     type: RollingUpdate
++   selector:
++     matchLabels:
++       app: csi-azuredisk-node
++   template:
++     metadata:
++       labels:
++         app.kubernetes.io/instance: "azuredisk-csi-driver"
++         app.kubernetes.io/managed-by: "Helm"
++         app.kubernetes.io/name: "azuredisk-csi-driver"
++         app.kubernetes.io/version: "v1.23.0"
++         helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++         app: csi-azuredisk-node
++     spec:
++       hostNetwork: true
++       dnsPolicy: Default
++       serviceAccountName: csi-azuredisk-node-sa
++       nodeSelector:
++         kubernetes.io/os: linux
++       affinity:
++         nodeAffinity:
++           requiredDuringSchedulingIgnoredDuringExecution:
++             nodeSelectorTerms:
++             - matchExpressions:
++               - key: type
++                 operator: NotIn
++                 values:
++                 - virtual-kubelet
++       priorityClassName: system-node-critical
++       tolerations:
++         - operator: Exists      
++       containers:
++         - name: liveness-probe
++           volumeMounts:
++             - mountPath: /csi
++               name: socket-dir
++           image: "mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.7.0"
++           args:
++             - --csi-address=/csi/csi.sock
++             - --probe-timeout=3s
++             - --health-port=29603
++             - --v=2
++           resources:
++             limits:
++               memory: 100Mi
++             requests:
++               cpu: 10m
++               memory: 20Mi
++         - name: node-driver-registrar
++           image: "mcr.microsoft.com/oss/kubernetes-csi/csi-node-driver-registrar:v2.5.1"
++           args:
++             - --csi-address=$(ADDRESS)
++             - --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
++             - --v=2
++           livenessProbe:
++             exec:
++               command:
++                 - /csi-node-driver-registrar
++                 - --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
++                 - --mode=kubelet-registration-probe
++             initialDelaySeconds: 30
++             timeoutSeconds: 15
++           env:
++             - name: ADDRESS
++               value: /csi/csi.sock
++             - name: DRIVER_REG_SOCK_PATH
++               value: /var/lib/kubelet/plugins/disk.csi.azure.com/csi.sock
++           volumeMounts:
++             - name: socket-dir
++               mountPath: /csi
++             - name: registration-dir
++               mountPath: /registration
++           resources:
++             limits:
++               memory: 100Mi
++             requests:
++               cpu: 10m
++               memory: 20Mi
++         - name: azuredisk
++           image: "mcr.microsoft.com/oss/kubernetes-csi/azuredisk-csi:v1.23.0"
++           args:
++             - "--v=5"
++             - "--endpoint=$(CSI_ENDPOINT)"
++             - "--nodeid=$(KUBE_NODE_NAME)"
++             - "--metrics-address=0.0.0.0:29605"
++             - "--enable-perf-optimization=true"
++             - "--drivername=disk.csi.azure.com"
++             - "--volume-attach-limit=-1"
++             - "--cloud-config-secret-name=azure-cloud-provider"
++             - "--cloud-config-secret-namespace=kube-system"
++             - "--custom-user-agent="
++             - "--user-agent-suffix=OSS-helm"
++             - "--allow-empty-cloud-config=true"
++             - "--support-zone=true"
++             - "--get-node-info-from-labels=false"
++           ports:
++             - containerPort: 29603
++               name: healthz
++               protocol: TCP
++           livenessProbe:
++             failureThreshold: 5
++             httpGet:
++               path: /healthz
++               port: healthz
++             initialDelaySeconds: 30
++             timeoutSeconds: 10
++             periodSeconds: 30
++           env:
++             - name: AZURE_CREDENTIAL_FILE
++               valueFrom:
++                 configMapKeyRef:
++                   name: azure-cred-file
++                   key: path
++                   optional: true
++             - name: CSI_ENDPOINT
++               value: unix:///csi/csi.sock
++             - name: KUBE_NODE_NAME
++               valueFrom:
++                 fieldRef:
++                   apiVersion: v1
++                   fieldPath: spec.nodeName
++             - name: AZURE_GO_SDK_LOG_LEVEL
++               value: 
++           imagePullPolicy: IfNotPresent
++           securityContext:
++             privileged: true
++           volumeMounts:
++             - mountPath: /csi
++               name: socket-dir
++             - mountPath: /var/lib/kubelet/
++               mountPropagation: Bidirectional
++               name: mountpoint-dir
++             - mountPath: /etc/kubernetes/
++               name: azure-cred
++             - mountPath: /dev
++               name: device-dir
++             - mountPath: /sys/bus/scsi/devices
++               name: sys-devices-dir
++             - mountPath: /sys/class/
++               name: sys-class
++           resources:
++             limits:
++               memory: 200Mi
++             requests:
++               cpu: 10m
++               memory: 20Mi
++       volumes:
++         - hostPath:
++             path: /var/lib/kubelet/plugins/disk.csi.azure.com
++             type: DirectoryOrCreate
++           name: socket-dir
++         - hostPath:
++             path: /var/lib/kubelet/
++             type: DirectoryOrCreate
++           name: mountpoint-dir
++         - hostPath:
++             path: /var/lib/kubelet/plugins_registry/
++             type: DirectoryOrCreate
++           name: registration-dir
++         - hostPath:
++             path: /etc/kubernetes/
++             type: DirectoryOrCreate
++           name: azure-cred
++         - hostPath:
++             path: /dev
++             type: Directory
++           name: device-dir
++         - hostPath:
++             path: /sys/bus/scsi/devices
++             type: Directory
++           name: sys-devices-dir
++         - hostPath:
++             path: /sys/class/
++             type: Directory
++           name: sys-class
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-node.yaml
++ kind: ClusterRole
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: csi-azuredisk-node-role
++ rules:
++   - apiGroups: [""]
++     resources: ["secrets"]
++     verbs: ["get"]
++   - apiGroups: [""]
++     resources: ["nodes"]
++     verbs: ["get"]
+- 
++ # Source: azuredisk-csi-driver/templates/serviceaccount-csi-azuredisk-node.yaml
++ apiVersion: v1
++ kind: ServiceAccount
++ metadata:
++   name: csi-azuredisk-node-sa
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+- 
++ # Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-node.yaml
++ kind: ClusterRoleBinding
++ apiVersion: rbac.authorization.k8s.io/v1
++ metadata:
++   name: csi-azuredisk-node-secret-binding
++ subjects:
++   - kind: ServiceAccount
++     name: csi-azuredisk-node-sa
++ roleRef:
++   kind: ClusterRole
++   name: csi-azuredisk-node-role
++   apiGroup: rbac.authorization.k8s.io
+- 
++ # Source: azuredisk-csi-driver/templates/csi-azuredisk-node-windows.yaml
++ kind: DaemonSet
++ apiVersion: apps/v1
++ metadata:
++   name: csi-azuredisk-node-win
++   labels:
++     app.kubernetes.io/instance: "azuredisk-csi-driver"
++     app.kubernetes.io/managed-by: "Helm"
++     app.kubernetes.io/name: "azuredisk-csi-driver"
++     app.kubernetes.io/version: "v1.23.0"
++     helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++ spec:
++   updateStrategy:
++     rollingUpdate:
++       maxUnavailable: 1
++     type: RollingUpdate
++   selector:
++     matchLabels:
++       app: csi-azuredisk-node-win
++   template:
++     metadata:
++       labels:
++         app.kubernetes.io/instance: "azuredisk-csi-driver"
++         app.kubernetes.io/managed-by: "Helm"
++         app.kubernetes.io/name: "azuredisk-csi-driver"
++         app.kubernetes.io/version: "v1.23.0"
++         helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
++         app: csi-azuredisk-node-win
++     spec:
++       serviceAccountName: csi-azuredisk-node-sa
++       tolerations:
++         - effect: NoSchedule
++           key: node.kubernetes.io/os
++           operator: Exists
++       nodeSelector:
++         kubernetes.io/os: windows
++       affinity:
++         nodeAffinity:
++           requiredDuringSchedulingIgnoredDuringExecution:
++             nodeSelectorTerms:
++             - matchExpressions:
++               - key: type
++                 operator: NotIn
++                 values:
++                 - virtual-kubelet
++       priorityClassName: system-node-critical      
++       containers:
++         - name: liveness-probe
++           volumeMounts:
++             - mountPath: C:\csi
++               name: plugin-dir
++           image: "mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.7.0"
++           args:
++             - "--csi-address=$(CSI_ENDPOINT)"
++             - "--probe-timeout=3s"
++             - "--health-port=29603"
++             - "--v=2"
++           env:
++             - name: CSI_ENDPOINT
++               value: unix://C:\\csi\\csi.sock
++           imagePullPolicy: IfNotPresent
++           resources:
++             limits:
++               memory: 150Mi
++             requests:
++               cpu: 10m
++               memory: 40Mi
++         - name: node-driver-registrar
++           image: "mcr.microsoft.com/oss/kubernetes-csi/csi-node-driver-registrar:v2.5.1"
++           args:
++             - "--v=2"
++             - "--csi-address=$(CSI_ENDPOINT)"
++             - "--kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)"
++           livenessProbe:
++             exec:
++               command:
++                 - /csi-node-driver-registrar.exe
++                 - --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
++                 - --mode=kubelet-registration-probe
++             initialDelaySeconds: 60
++             timeoutSeconds: 30
++           env:
++             - name: CSI_ENDPOINT
++               value: unix://C:\\csi\\csi.sock
++             - name: DRIVER_REG_SOCK_PATH
++               value: C:\\var\\lib\\kubelet\\plugins\\disk.csi.azure.com\\csi.sock
++             - name: KUBE_NODE_NAME
++               valueFrom:
++                 fieldRef:
++                   fieldPath: spec.nodeName
++           imagePullPolicy: IfNotPresent
++           volumeMounts:
++             - name: kubelet-dir
++               mountPath: "C:\\var\\lib\\kubelet"
++             - name: plugin-dir
++               mountPath: C:\csi
++             - name: registration-dir
++               mountPath: C:\registration
++           resources:
++             limits:
++               memory: 150Mi
++             requests:
++               cpu: 30m
++               memory: 40Mi
++         - name: azuredisk
++           image: "mcr.microsoft.com/oss/kubernetes-csi/azuredisk-csi:v1.23.0"
++           args:
++             - "--v=5"
++             - "--endpoint=$(CSI_ENDPOINT)"
++             - "--nodeid=$(KUBE_NODE_NAME)"
++             - "--metrics-address=0.0.0.0:29605"
++             - "--drivername=disk.csi.azure.com"
++             - "--volume-attach-limit=-1"
++             - "--cloud-config-secret-name=azure-cloud-provider"
++             - "--cloud-config-secret-namespace=kube-system"
++             - "--custom-user-agent="
++             - "--user-agent-suffix=OSS-helm"
++             - "--allow-empty-cloud-config=true"
++             - "--support-zone=true"
++             - "--get-node-info-from-labels=false"
++           ports:
++             - containerPort: 29603
++               name: healthz
++               protocol: TCP
++           livenessProbe:
++             failureThreshold: 5
++             httpGet:
++               path: /healthz
++               port: healthz
++             initialDelaySeconds: 30
++             timeoutSeconds: 10
++             periodSeconds: 30
++           env:
++             - name: AZURE_CREDENTIAL_FILE
++               valueFrom:
++                 configMapKeyRef:
++                   name: azure-cred-file
++                   key: path-windows
++                   optional: true
++             - name: CSI_ENDPOINT
++               value: unix://C:\\csi\\csi.sock
++             - name: KUBE_NODE_NAME
++               valueFrom:
++                 fieldRef:
++                   apiVersion: v1
++                   fieldPath: spec.nodeName
++             - name: AZURE_GO_SDK_LOG_LEVEL
++               value: 
++           imagePullPolicy: IfNotPresent
++           volumeMounts:
++             - name: kubelet-dir
++               mountPath: "C:\\var\\lib\\kubelet"
++             - name: plugin-dir
++               mountPath: C:\csi
++             - name: azure-config
++               mountPath: C:\k
++             - name: csi-proxy-fs-pipe-v1
++               mountPath: \\.\pipe\csi-proxy-filesystem-v1
++             - name: csi-proxy-disk-pipe-v1
++               mountPath: \\.\pipe\csi-proxy-disk-v1
++             - name: csi-proxy-volume-pipe-v1
++               mountPath: \\.\pipe\csi-proxy-volume-v1
++             # these paths are still included for compatibility, they're used
++             # only if the node has still the beta version of the CSI proxy
++             - name: csi-proxy-fs-pipe-v1beta1
++               mountPath: \\.\pipe\csi-proxy-filesystem-v1beta1
++             - name: csi-proxy-disk-pipe-v1beta2
++               mountPath: \\.\pipe\csi-proxy-disk-v1beta2
++             - name: csi-proxy-volume-pipe-v1beta2
++               mountPath: \\.\pipe\csi-proxy-volume-v1beta2
++           resources:
++             limits:
++               memory: 200Mi
++             requests:
++               cpu: 10m
++               memory: 40Mi
++       volumes:
++         - name: csi-proxy-fs-pipe-v1
++           hostPath:
++             path: \\.\pipe\csi-proxy-filesystem-v1
++         - name: csi-proxy-disk-pipe-v1
++           hostPath:
++             path: \\.\pipe\csi-proxy-disk-v1
++         - name: csi-proxy-volume-pipe-v1
++           hostPath:
++             path: \\.\pipe\csi-proxy-volume-v1
++         # these paths are still included for compatibility, they're used
++         # only if the node has still the beta version of the CSI proxy
++         - name: csi-proxy-fs-pipe-v1beta1
++           hostPath:
++             path: \\.\pipe\csi-proxy-filesystem-v1beta1
++         - name: csi-proxy-disk-pipe-v1beta2
++           hostPath:
++             path: \\.\pipe\csi-proxy-disk-v1beta2
++         - name: csi-proxy-volume-pipe-v1beta2
++           hostPath:
++             path: \\.\pipe\csi-proxy-volume-v1beta2
++         - name: registration-dir
++           hostPath:
++             path: C:\var\lib\kubelet\plugins_registry\
++             type: Directory
++         - name: kubelet-dir
++           hostPath:
++             path: C:\var\lib\kubelet\
++             type: Directory
++         - name: plugin-dir
++           hostPath:
++             path: C:\var\lib\kubelet\plugins\disk.csi.azure.com\
++             type: DirectoryOrCreate
++         - name: azure-config
++           hostPath:
++             path: C:\k
++             type: DirectoryOrCreate
+- 
++ # Source: azuredisk-csi-driver/templates/csi-azuredisk-driver.yaml
++ apiVersion: storage.k8s.io/v1
++ kind: CSIDriver
++ metadata:
++   name: disk.csi.azure.com
++   annotations:
++     csiDriver: "v1.23.0"
++     snapshot: "v5.0.1"
++ spec:
++   attachRequired: true
++   podInfoOnMount: false
++   fsGroupPolicy: File
+

test/integration/chart-needs-golden/lint

@@ -0,0 +1,9 @@
+[INFO] Chart.yaml: icon is recommended
+[INFO] values.yaml: file does not exist
+
+1 chart(s) linted, 0 chart(s) failed
+
+[INFO] Chart.yaml: icon is recommended
+
+1 chart(s) linted, 0 chart(s) failed
+

test/integration/chart-needs-golden/template

@@ -0,0 +1,931 @@
+---
+# Source: azuredisk-csi-storageclass/templates/azuredisk-csi-storageclass.yaml
+# Source: azuredisk-csi-storageclass/templates/azuredisk-csi-storageclass.yaml
+apiVersion: storage.k8s.io/v1
+kind: StorageClass
+metadata:
+  name: managed-csi
+provisioner: disk.csi.azure.com
+parameters:
+  skuName: Premium_LRS
+reclaimPolicy: Retain
+volumeBindingMode: Immediate
+allowVolumeExpansion: true
+
+---
+# Source: azuredisk-csi-driver/templates/serviceaccount-csi-azuredisk-controller.yaml
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: csi-azuredisk-controller-sa
+  namespace: default
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+---
+# Source: azuredisk-csi-driver/templates/serviceaccount-csi-azuredisk-node.yaml
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: csi-azuredisk-node-sa
+  namespace: default
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRole
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: azuredisk-external-provisioner-role
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+rules:
+  - apiGroups: [""]
+    resources: ["persistentvolumes"]
+    verbs: ["get", "list", "watch", "create", "delete"]
+  - apiGroups: [""]
+    resources: ["persistentvolumeclaims"]
+    verbs: ["get", "list", "watch", "update"]
+  - apiGroups: ["storage.k8s.io"]
+    resources: ["storageclasses"]
+    verbs: ["get", "list", "watch"]
+  - apiGroups: [""]
+    resources: ["events"]
+    verbs: ["get", "list", "watch", "create", "update", "patch"]
+  - apiGroups: ["storage.k8s.io"]
+    resources: ["csinodes"]
+    verbs: ["get", "list", "watch"]
+  - apiGroups: [""]
+    resources: ["nodes"]
+    verbs: ["get", "list", "watch"]
+  - apiGroups: ["snapshot.storage.k8s.io"]
+    resources: ["volumesnapshots"]
+    verbs: ["get", "list"]
+  - apiGroups: ["snapshot.storage.k8s.io"]
+    resources: ["volumesnapshotcontents"]
+    verbs: ["get", "list"]
+  - apiGroups: ["coordination.k8s.io"]
+    resources: ["leases"]
+    verbs: ["get", "watch", "list", "delete", "update", "create", "patch"]
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRole
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: azuredisk-external-attacher-role
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+rules:
+  - apiGroups: [""]
+    resources: ["persistentvolumes"]
+    verbs: ["get", "list", "watch", "update"]
+  - apiGroups: [""]
+    resources: ["nodes"]
+    verbs: ["get", "list", "watch"]
+  - apiGroups: ["csi.storage.k8s.io"]
+    resources: ["csinodeinfos"]
+    verbs: ["get", "list", "watch"]
+  - apiGroups: ["storage.k8s.io"]
+    resources: ["volumeattachments"]
+    verbs: ["get", "list", "watch", "update", "patch"]
+  - apiGroups: ["storage.k8s.io"]
+    resources: ["volumeattachments/status"]
+    verbs: ["get", "list", "watch", "update", "patch"]
+  - apiGroups: ["coordination.k8s.io"]
+    resources: ["leases"]
+    verbs: ["get", "watch", "list", "delete", "update", "create", "patch"]
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRole
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: azuredisk-external-snapshotter-role
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+rules:
+  - apiGroups: [""]
+    resources: ["events"]
+    verbs: ["list", "watch", "create", "update", "patch"]
+  - apiGroups: [""]
+    resources: ["secrets"]
+    verbs: ["get", "list"]
+  - apiGroups: ["snapshot.storage.k8s.io"]
+    resources: ["volumesnapshotclasses"]
+    verbs: ["get", "list", "watch"]
+  - apiGroups: ["snapshot.storage.k8s.io"]
+    resources: ["volumesnapshotcontents"]
+    verbs: ["create", "get", "list", "watch", "update", "delete", "patch"]
+  - apiGroups: ["snapshot.storage.k8s.io"]
+    resources: ["volumesnapshotcontents/status"]
+    verbs: ["update", "patch"]
+  - apiGroups: ["coordination.k8s.io"]
+    resources: ["leases"]
+    verbs: ["get", "watch", "list", "delete", "update", "create", "patch"]
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRole
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: azuredisk-external-resizer-role
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+rules:
+  - apiGroups: [""]
+    resources: ["persistentvolumes"]
+    verbs: ["get", "list", "watch", "update", "patch"]
+  - apiGroups: [""]
+    resources: ["persistentvolumeclaims"]
+    verbs: ["get", "list", "watch"]
+  - apiGroups: [""]
+    resources: ["persistentvolumeclaims/status"]
+    verbs: ["update", "patch"]
+  - apiGroups: [""]
+    resources: ["events"]
+    verbs: ["list", "watch", "create", "update", "patch"]
+  - apiGroups: ["coordination.k8s.io"]
+    resources: ["leases"]
+    verbs: ["get", "watch", "list", "delete", "update", "create", "patch"]
+  - apiGroups: [""]
+    resources: ["pods"]
+    verbs: ["get", "list", "watch"]
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRole
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: csi-azuredisk-controller-secret-role
+rules:
+  - apiGroups: [""]
+    resources: ["secrets"]
+    verbs: ["get"]
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-node.yaml
+kind: ClusterRole
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: csi-azuredisk-node-role
+rules:
+  - apiGroups: [""]
+    resources: ["secrets"]
+    verbs: ["get"]
+  - apiGroups: [""]
+    resources: ["nodes"]
+    verbs: ["get"]
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRoleBinding
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: azuredisk-csi-provisioner-binding
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+subjects:
+  - kind: ServiceAccount
+    name: csi-azuredisk-controller-sa
+    namespace: default
+roleRef:
+  kind: ClusterRole
+  name: azuredisk-external-provisioner-role
+  apiGroup: rbac.authorization.k8s.io
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRoleBinding
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: azuredisk-csi-attacher-binding
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+subjects:
+  - kind: ServiceAccount
+    name: csi-azuredisk-controller-sa
+    namespace: default
+roleRef:
+  kind: ClusterRole
+  name: azuredisk-external-attacher-role
+  apiGroup: rbac.authorization.k8s.io
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRoleBinding
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: azuredisk-csi-snapshotter-binding
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+subjects:
+  - kind: ServiceAccount
+    name: csi-azuredisk-controller-sa
+    namespace: default
+roleRef:
+  kind: ClusterRole
+  name: azuredisk-external-snapshotter-role
+  apiGroup: rbac.authorization.k8s.io
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRoleBinding
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: azuredisk-csi-resizer-role
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+subjects:
+  - kind: ServiceAccount
+    name: csi-azuredisk-controller-sa
+    namespace: default
+roleRef:
+  kind: ClusterRole
+  name: azuredisk-external-resizer-role
+  apiGroup: rbac.authorization.k8s.io
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-controller.yaml
+kind: ClusterRoleBinding
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: csi-azuredisk-controller-secret-binding
+subjects:
+  - kind: ServiceAccount
+    name: csi-azuredisk-controller-sa
+    namespace: default
+roleRef:
+  kind: ClusterRole
+  name: csi-azuredisk-controller-secret-role
+  apiGroup: rbac.authorization.k8s.io
+---
+# Source: azuredisk-csi-driver/templates/rbac-csi-azuredisk-node.yaml
+kind: ClusterRoleBinding
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: csi-azuredisk-node-secret-binding
+subjects:
+  - kind: ServiceAccount
+    name: csi-azuredisk-node-sa
+    namespace: default
+roleRef:
+  kind: ClusterRole
+  name: csi-azuredisk-node-role
+  apiGroup: rbac.authorization.k8s.io
+---
+# Source: azuredisk-csi-driver/templates/csi-azuredisk-node-windows.yaml
+kind: DaemonSet
+apiVersion: apps/v1
+metadata:
+  name: csi-azuredisk-node-win
+  namespace: default
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+spec:
+  updateStrategy:
+    rollingUpdate:
+      maxUnavailable: 1
+    type: RollingUpdate
+  selector:
+    matchLabels:
+      app: csi-azuredisk-node-win
+  template:
+    metadata:
+      labels:
+        app.kubernetes.io/instance: "azuredisk-csi-driver"
+        app.kubernetes.io/managed-by: "Helm"
+        app.kubernetes.io/name: "azuredisk-csi-driver"
+        app.kubernetes.io/version: "v1.23.0"
+        helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+        app: csi-azuredisk-node-win
+    spec:
+      serviceAccountName: csi-azuredisk-node-sa
+      tolerations:
+        - effect: NoSchedule
+          key: node.kubernetes.io/os
+          operator: Exists
+      nodeSelector:
+        kubernetes.io/os: windows
+      affinity:
+        nodeAffinity:
+          requiredDuringSchedulingIgnoredDuringExecution:
+            nodeSelectorTerms:
+            - matchExpressions:
+              - key: type
+                operator: NotIn
+                values:
+                - virtual-kubelet
+      priorityClassName: system-node-critical      
+      containers:
+        - name: liveness-probe
+          volumeMounts:
+            - mountPath: C:\csi
+              name: plugin-dir
+          image: "mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.7.0"
+          args:
+            - "--csi-address=$(CSI_ENDPOINT)"
+            - "--probe-timeout=3s"
+            - "--health-port=29603"
+            - "--v=2"
+          env:
+            - name: CSI_ENDPOINT
+              value: unix://C:\\csi\\csi.sock
+          imagePullPolicy: IfNotPresent
+          resources:
+            limits:
+              memory: 150Mi
+            requests:
+              cpu: 10m
+              memory: 40Mi
+        - name: node-driver-registrar
+          image: "mcr.microsoft.com/oss/kubernetes-csi/csi-node-driver-registrar:v2.5.1"
+          args:
+            - "--v=2"
+            - "--csi-address=$(CSI_ENDPOINT)"
+            - "--kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)"
+          livenessProbe:
+            exec:
+              command:
+                - /csi-node-driver-registrar.exe
+                - --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
+                - --mode=kubelet-registration-probe
+            initialDelaySeconds: 60
+            timeoutSeconds: 30
+          env:
+            - name: CSI_ENDPOINT
+              value: unix://C:\\csi\\csi.sock
+            - name: DRIVER_REG_SOCK_PATH
+              value: C:\\var\\lib\\kubelet\\plugins\\disk.csi.azure.com\\csi.sock
+            - name: KUBE_NODE_NAME
+              valueFrom:
+                fieldRef:
+                  fieldPath: spec.nodeName
+          imagePullPolicy: IfNotPresent
+          volumeMounts:
+            - name: kubelet-dir
+              mountPath: "C:\\var\\lib\\kubelet"
+            - name: plugin-dir
+              mountPath: C:\csi
+            - name: registration-dir
+              mountPath: C:\registration
+          resources:
+            limits:
+              memory: 150Mi
+            requests:
+              cpu: 30m
+              memory: 40Mi
+        - name: azuredisk
+          image: "mcr.microsoft.com/oss/kubernetes-csi/azuredisk-csi:v1.23.0"
+          args:
+            - "--v=5"
+            - "--endpoint=$(CSI_ENDPOINT)"
+            - "--nodeid=$(KUBE_NODE_NAME)"
+            - "--metrics-address=0.0.0.0:29605"
+            - "--drivername=disk.csi.azure.com"
+            - "--volume-attach-limit=-1"
+            - "--cloud-config-secret-name=azure-cloud-provider"
+            - "--cloud-config-secret-namespace=kube-system"
+            - "--custom-user-agent="
+            - "--user-agent-suffix=OSS-helm"
+            - "--allow-empty-cloud-config=true"
+            - "--support-zone=true"
+            - "--get-node-info-from-labels=false"
+          ports:
+            - containerPort: 29603
+              name: healthz
+              protocol: TCP
+          livenessProbe:
+            failureThreshold: 5
+            httpGet:
+              path: /healthz
+              port: healthz
+            initialDelaySeconds: 30
+            timeoutSeconds: 10
+            periodSeconds: 30
+          env:
+            - name: AZURE_CREDENTIAL_FILE
+              valueFrom:
+                configMapKeyRef:
+                  name: azure-cred-file
+                  key: path-windows
+                  optional: true
+            - name: CSI_ENDPOINT
+              value: unix://C:\\csi\\csi.sock
+            - name: KUBE_NODE_NAME
+              valueFrom:
+                fieldRef:
+                  apiVersion: v1
+                  fieldPath: spec.nodeName
+            - name: AZURE_GO_SDK_LOG_LEVEL
+              value: 
+          imagePullPolicy: IfNotPresent
+          volumeMounts:
+            - name: kubelet-dir
+              mountPath: "C:\\var\\lib\\kubelet"
+            - name: plugin-dir
+              mountPath: C:\csi
+            - name: azure-config
+              mountPath: C:\k
+            - name: csi-proxy-fs-pipe-v1
+              mountPath: \\.\pipe\csi-proxy-filesystem-v1
+            - name: csi-proxy-disk-pipe-v1
+              mountPath: \\.\pipe\csi-proxy-disk-v1
+            - name: csi-proxy-volume-pipe-v1
+              mountPath: \\.\pipe\csi-proxy-volume-v1
+            # these paths are still included for compatibility, they're used
+            # only if the node has still the beta version of the CSI proxy
+            - name: csi-proxy-fs-pipe-v1beta1
+              mountPath: \\.\pipe\csi-proxy-filesystem-v1beta1
+            - name: csi-proxy-disk-pipe-v1beta2
+              mountPath: \\.\pipe\csi-proxy-disk-v1beta2
+            - name: csi-proxy-volume-pipe-v1beta2
+              mountPath: \\.\pipe\csi-proxy-volume-v1beta2
+          resources:
+            limits:
+              memory: 200Mi
+            requests:
+              cpu: 10m
+              memory: 40Mi
+      volumes:
+        - name: csi-proxy-fs-pipe-v1
+          hostPath:
+            path: \\.\pipe\csi-proxy-filesystem-v1
+        - name: csi-proxy-disk-pipe-v1
+          hostPath:
+            path: \\.\pipe\csi-proxy-disk-v1
+        - name: csi-proxy-volume-pipe-v1
+          hostPath:
+            path: \\.\pipe\csi-proxy-volume-v1
+        # these paths are still included for compatibility, they're used
+        # only if the node has still the beta version of the CSI proxy
+        - name: csi-proxy-fs-pipe-v1beta1
+          hostPath:
+            path: \\.\pipe\csi-proxy-filesystem-v1beta1
+        - name: csi-proxy-disk-pipe-v1beta2
+          hostPath:
+            path: \\.\pipe\csi-proxy-disk-v1beta2
+        - name: csi-proxy-volume-pipe-v1beta2
+          hostPath:
+            path: \\.\pipe\csi-proxy-volume-v1beta2
+        - name: registration-dir
+          hostPath:
+            path: C:\var\lib\kubelet\plugins_registry\
+            type: Directory
+        - name: kubelet-dir
+          hostPath:
+            path: C:\var\lib\kubelet\
+            type: Directory
+        - name: plugin-dir
+          hostPath:
+            path: C:\var\lib\kubelet\plugins\disk.csi.azure.com\
+            type: DirectoryOrCreate
+        - name: azure-config
+          hostPath:
+            path: C:\k
+            type: DirectoryOrCreate
+---
+# Source: azuredisk-csi-driver/templates/csi-azuredisk-node.yaml
+kind: DaemonSet
+apiVersion: apps/v1
+metadata:
+  name: csi-azuredisk-node
+  namespace: default
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+spec:
+  updateStrategy:
+    rollingUpdate:
+      maxUnavailable: 1
+    type: RollingUpdate
+  selector:
+    matchLabels:
+      app: csi-azuredisk-node
+  template:
+    metadata:
+      labels:
+        app.kubernetes.io/instance: "azuredisk-csi-driver"
+        app.kubernetes.io/managed-by: "Helm"
+        app.kubernetes.io/name: "azuredisk-csi-driver"
+        app.kubernetes.io/version: "v1.23.0"
+        helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+        app: csi-azuredisk-node
+    spec:
+      hostNetwork: true
+      dnsPolicy: Default
+      serviceAccountName: csi-azuredisk-node-sa
+      nodeSelector:
+        kubernetes.io/os: linux
+      affinity:
+        nodeAffinity:
+          requiredDuringSchedulingIgnoredDuringExecution:
+            nodeSelectorTerms:
+            - matchExpressions:
+              - key: type
+                operator: NotIn
+                values:
+                - virtual-kubelet
+      priorityClassName: system-node-critical
+      tolerations:
+        - operator: Exists      
+      containers:
+        - name: liveness-probe
+          volumeMounts:
+            - mountPath: /csi
+              name: socket-dir
+          image: "mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.7.0"
+          args:
+            - --csi-address=/csi/csi.sock
+            - --probe-timeout=3s
+            - --health-port=29603
+            - --v=2
+          resources:
+            limits:
+              memory: 100Mi
+            requests:
+              cpu: 10m
+              memory: 20Mi
+        - name: node-driver-registrar
+          image: "mcr.microsoft.com/oss/kubernetes-csi/csi-node-driver-registrar:v2.5.1"
+          args:
+            - --csi-address=$(ADDRESS)
+            - --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
+            - --v=2
+          livenessProbe:
+            exec:
+              command:
+                - /csi-node-driver-registrar
+                - --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
+                - --mode=kubelet-registration-probe
+            initialDelaySeconds: 30
+            timeoutSeconds: 15
+          env:
+            - name: ADDRESS
+              value: /csi/csi.sock
+            - name: DRIVER_REG_SOCK_PATH
+              value: /var/lib/kubelet/plugins/disk.csi.azure.com/csi.sock
+          volumeMounts:
+            - name: socket-dir
+              mountPath: /csi
+            - name: registration-dir
+              mountPath: /registration
+          resources:
+            limits:
+              memory: 100Mi
+            requests:
+              cpu: 10m
+              memory: 20Mi
+        - name: azuredisk
+          image: "mcr.microsoft.com/oss/kubernetes-csi/azuredisk-csi:v1.23.0"
+          args:
+            - "--v=5"
+            - "--endpoint=$(CSI_ENDPOINT)"
+            - "--nodeid=$(KUBE_NODE_NAME)"
+            - "--metrics-address=0.0.0.0:29605"
+            - "--enable-perf-optimization=true"
+            - "--drivername=disk.csi.azure.com"
+            - "--volume-attach-limit=-1"
+            - "--cloud-config-secret-name=azure-cloud-provider"
+            - "--cloud-config-secret-namespace=kube-system"
+            - "--custom-user-agent="
+            - "--user-agent-suffix=OSS-helm"
+            - "--allow-empty-cloud-config=true"
+            - "--support-zone=true"
+            - "--get-node-info-from-labels=false"
+          ports:
+            - containerPort: 29603
+              name: healthz
+              protocol: TCP
+          livenessProbe:
+            failureThreshold: 5
+            httpGet:
+              path: /healthz
+              port: healthz
+            initialDelaySeconds: 30
+            timeoutSeconds: 10
+            periodSeconds: 30
+          env:
+            - name: AZURE_CREDENTIAL_FILE
+              valueFrom:
+                configMapKeyRef:
+                  name: azure-cred-file
+                  key: path
+                  optional: true
+            - name: CSI_ENDPOINT
+              value: unix:///csi/csi.sock
+            - name: KUBE_NODE_NAME
+              valueFrom:
+                fieldRef:
+                  apiVersion: v1
+                  fieldPath: spec.nodeName
+            - name: AZURE_GO_SDK_LOG_LEVEL
+              value: 
+          imagePullPolicy: IfNotPresent
+          securityContext:
+            privileged: true
+          volumeMounts:
+            - mountPath: /csi
+              name: socket-dir
+            - mountPath: /var/lib/kubelet/
+              mountPropagation: Bidirectional
+              name: mountpoint-dir
+            - mountPath: /etc/kubernetes/
+              name: azure-cred
+            - mountPath: /dev
+              name: device-dir
+            - mountPath: /sys/bus/scsi/devices
+              name: sys-devices-dir
+            - mountPath: /sys/class/
+              name: sys-class
+          resources:
+            limits:
+              memory: 200Mi
+            requests:
+              cpu: 10m
+              memory: 20Mi
+      volumes:
+        - hostPath:
+            path: /var/lib/kubelet/plugins/disk.csi.azure.com
+            type: DirectoryOrCreate
+          name: socket-dir
+        - hostPath:
+            path: /var/lib/kubelet/
+            type: DirectoryOrCreate
+          name: mountpoint-dir
+        - hostPath:
+            path: /var/lib/kubelet/plugins_registry/
+            type: DirectoryOrCreate
+          name: registration-dir
+        - hostPath:
+            path: /etc/kubernetes/
+            type: DirectoryOrCreate
+          name: azure-cred
+        - hostPath:
+            path: /dev
+            type: Directory
+          name: device-dir
+        - hostPath:
+            path: /sys/bus/scsi/devices
+            type: Directory
+          name: sys-devices-dir
+        - hostPath:
+            path: /sys/class/
+            type: Directory
+          name: sys-class
+---
+# Source: azuredisk-csi-driver/templates/csi-azuredisk-controller.yaml
+kind: Deployment
+apiVersion: apps/v1
+metadata:
+  name: csi-azuredisk-controller
+  namespace: default
+  labels:
+    app.kubernetes.io/instance: "azuredisk-csi-driver"
+    app.kubernetes.io/managed-by: "Helm"
+    app.kubernetes.io/name: "azuredisk-csi-driver"
+    app.kubernetes.io/version: "v1.23.0"
+    helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+spec:
+  replicas: 2
+  selector:
+    matchLabels:
+      app: csi-azuredisk-controller
+  template:
+    metadata:
+      labels:
+        app.kubernetes.io/instance: "azuredisk-csi-driver"
+        app.kubernetes.io/managed-by: "Helm"
+        app.kubernetes.io/name: "azuredisk-csi-driver"
+        app.kubernetes.io/version: "v1.23.0"
+        helm.sh/chart: "azuredisk-csi-driver-v1.23.0"
+        app: csi-azuredisk-controller
+    spec:
+      hostNetwork: true
+      serviceAccountName: csi-azuredisk-controller-sa
+      nodeSelector:
+        kubernetes.io/os: linux
+      priorityClassName: system-cluster-critical
+      tolerations:
+        - effect: NoSchedule
+          key: node-role.kubernetes.io/master
+          operator: Exists
+        - effect: NoSchedule
+          key: node-role.kubernetes.io/controlplane
+          operator: Exists
+        - effect: NoSchedule
+          key: node-role.kubernetes.io/control-plane
+          operator: Exists      
+      containers:
+        - name: csi-provisioner
+          image: "mcr.microsoft.com/oss/kubernetes-csi/csi-provisioner:v3.2.0"
+          args:
+            - "--feature-gates=Topology=true"
+            - "--csi-address=$(ADDRESS)"
+            - "--v=2"
+            - "--timeout=15s"
+            - "--leader-election"
+            - "--leader-election-namespace=default"
+            - "--worker-threads=50"
+            - "--extra-create-metadata=true"
+            - "--strict-topology=true"
+          env:
+            - name: ADDRESS
+              value: /csi/csi.sock
+          volumeMounts:
+            - mountPath: /csi
+              name: socket-dir
+          resources:
+            limits:
+              memory: 500Mi
+            requests:
+              cpu: 10m
+              memory: 20Mi
+        - name: csi-attacher
+          image: "mcr.microsoft.com/oss/kubernetes-csi/csi-attacher:v3.5.0"
+          args:
+            - "-v=2"
+            - "-csi-address=$(ADDRESS)"
+            - "-timeout=1200s"
+            - "-leader-election"
+            - "--leader-election-namespace=default"
+            - "-worker-threads=500"
+          env:
+            - name: ADDRESS
+              value: /csi/csi.sock
+          volumeMounts:
+          - mountPath: /csi
+            name: socket-dir
+          resources:
+            limits:
+              memory: 500Mi
+            requests:
+              cpu: 10m
+              memory: 20Mi
+        - name: csi-snapshotter
+          image: "mcr.microsoft.com/oss/kubernetes-csi/csi-snapshotter:v5.0.1"
+          args:
+            - "-csi-address=$(ADDRESS)"
+            - "-leader-election"
+            - "--leader-election-namespace=default"
+            - "-v=2"
+          env:
+            - name: ADDRESS
+              value: /csi/csi.sock
+          volumeMounts:
+            - name: socket-dir
+              mountPath: /csi
+          resources:
+            limits:
+              memory: 100Mi
+            requests:
+              cpu: 10m
+              memory: 20Mi
+        - name: csi-resizer
+          image: "mcr.microsoft.com/oss/kubernetes-csi/csi-resizer:v1.5.0"
+          args:
+            - "-csi-address=$(ADDRESS)"
+            - "-v=2"
+            - "-leader-election"
+            - "--leader-election-namespace=default"
+            - '-handle-volume-inuse-error=false'
+            - '-feature-gates=RecoverVolumeExpansionFailure=true'
+            - "-timeout=240s"
+          env:
+            - name: ADDRESS
+              value: /csi/csi.sock
+          volumeMounts:
+            - name: socket-dir
+              mountPath: /csi
+          resources:
+            limits:
+              memory: 500Mi
+            requests:
+              cpu: 10m
+              memory: 20Mi
+        - name: liveness-probe
+          image: "mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.7.0"
+          args:
+            - --csi-address=/csi/csi.sock
+            - --probe-timeout=3s
+            - --health-port=29602
+            - --v=2
+          volumeMounts:
+            - name: socket-dir
+              mountPath: /csi
+          resources:
+            limits:
+              memory: 100Mi
+            requests:
+              cpu: 10m
+              memory: 20Mi
+        - name: azuredisk
+          image: "mcr.microsoft.com/oss/kubernetes-csi/azuredisk-csi:v1.23.0"
+          args:
+            - "--v=5"
+            - "--endpoint=$(CSI_ENDPOINT)"
+            - "--metrics-address=0.0.0.0:29604"
+            - "--disable-avset-nodes=false"
+            - "--vm-type="
+            - "--drivername=disk.csi.azure.com"
+            - "--cloud-config-secret-name=azure-cloud-provider"
+            - "--cloud-config-secret-namespace=kube-system"
+            - "--custom-user-agent="
+            - "--user-agent-suffix=OSS-helm"
+            - "--allow-empty-cloud-config=false"
+            - "--vmss-cache-ttl-seconds=-1"
+          ports:
+            - containerPort: 29602
+              name: healthz
+              protocol: TCP
+            - containerPort: 29604
+              name: metrics
+              protocol: TCP
+          livenessProbe:
+            failureThreshold: 5
+            httpGet:
+              path: /healthz
+              port: healthz
+            initialDelaySeconds: 30
+            timeoutSeconds: 10
+            periodSeconds: 30
+          env:
+            - name: AZURE_CREDENTIAL_FILE
+              valueFrom:
+                configMapKeyRef:
+                  name: azure-cred-file
+                  key: path
+                  optional: true
+            - name: CSI_ENDPOINT
+              value: unix:///csi/csi.sock
+            - name: AZURE_GO_SDK_LOG_LEVEL
+              value: 
+          imagePullPolicy: IfNotPresent
+          volumeMounts:
+            - mountPath: /csi
+              name: socket-dir
+            - mountPath: /etc/kubernetes/
+              name: azure-cred
+          resources:
+            limits:
+              memory: 500Mi
+            requests:
+              cpu: 10m
+              memory: 20Mi
+      volumes:
+        - name: socket-dir
+          emptyDir: {}
+        - name: azure-cred
+          hostPath:
+            path: /etc/kubernetes/
+            type: DirectoryOrCreate
+---
+# Source: azuredisk-csi-driver/templates/csi-azuredisk-driver.yaml
+apiVersion: storage.k8s.io/v1
+kind: CSIDriver
+metadata:
+  name: disk.csi.azure.com
+  annotations:
+    csiDriver: "v1.23.0"
+    snapshot: "v5.0.1"
+spec:
+  attachRequired: true
+  podInfoOnMount: false
+  fsGroupPolicy: File
+

test/integration/issue.455/azuredisk-csi-storageclass/azuredisk-csi-storageclass.yaml

@@ -0,0 +1,10 @@
+apiVersion: storage.k8s.io/v1
+kind: StorageClass
+metadata:
+  name: managed-csi
+provisioner: disk.csi.azure.com
+parameters:
+  skuName: Premium_LRS
+reclaimPolicy: Retain
+volumeBindingMode: Immediate
+allowVolumeExpansion: true

test/integration/issue.455/helmfile.yaml

@@ -0,0 +1,10 @@
+repositories:
+  - name: azuredisk-csi-driver
+    url: https://raw.githubusercontent.com/kubernetes-sigs/azuredisk-csi-driver/master/charts
+releases:
+  - name: azuredisk-csi-storageclass
+    chart: ./azuredisk-csi-storageclass
+  - name: azuredisk-csi-driver
+    chart: azuredisk-csi-driver/azuredisk-csi-driver
+    needs:
+      - azuredisk-csi-storageclass

test/integration/run.sh

@@ -18,6 +18,7 @@ if [[ ! -d "${dir}" ]]; then dir="${PWD}"; fi
 
 test_ns="helmfile-tests-$(date +"%Y%m%d-%H%M%S")"
 helmfile="./helmfile ${EXTRA_HELMFILE_FLAGS} --namespace=${test_ns}"
+helmfile_no_extra_flags="./helmfile --namespace=${test_ns}"
 helm="helm --kube-context=minikube"
 kubectl="kubectl --context=minikube --namespace=${test_ns}"
 helm_dir="${PWD}/${dir}/.helm"
@@ -206,9 +207,7 @@ if [[ helm_major_version -eq 3 ]]; then
   tmp=$(mktemp -d)
   direct=${tmp}/direct.build.yaml
   reverse=${tmp}/reverse.build.yaml
-  yaml_overwrite_reverse=${tmp}/yaml.override.build.yaml
   secrets_golden_dir=${dir}/secrets-golden
-  feature_golden_dir=${dir}/yaml-features-golden
 
   info "Building secrets output"
 
@@ -230,16 +229,22 @@ if [[ helm_major_version -eq 3 ]]; then
 
   test_pass "secretssops.3"
 
+  yaml_feature_golden_dir=${dir}/yaml-features-golden
+  yaml_overwrite_reverse=${tmp}/yaml.override.build.yaml
+
   test_start "yaml overwrite feature"
-  info "Comparing yaml overwrite feature output ${yaml_overwrite_reverse} with ${feature_golden_dir}/overwritten.yaml"
+  info "Comparing yaml overwrite feature output ${yaml_overwrite_reverse} with ${yaml_feature_golden_dir}/overwritten.yaml"
   for i in $(seq 10); do
       info "Comparing build/yaml-overwrite #$i"
       ${helmfile} -f ${dir}/issue.657.yaml template --skip-deps > ${yaml_overwrite_reverse} || fail "\"helmfile template\" shouldn't fail"
-      ./yamldiff ${feature_golden_dir}/overwritten.yaml ${yaml_overwrite_reverse} || fail "\"helmfile template\" should be consistent"
+      ./yamldiff ${yaml_feature_golden_dir}/overwritten.yaml ${yaml_overwrite_reverse} || fail "\"helmfile template\" should be consistent"
       echo code=$?
   done
   test_pass "yaml overwrite feature"
 
+  # chart preprocessing with needs
+  . ${dir}/test-cases/chart-needs.sh
+
 fi
 
 # ALL DONE -----------------------------------------------------------------------------------------------------------

test/integration/test-cases/chart-needs.sh

@@ -0,0 +1,55 @@
+chart_needs_golden_dir=${dir}/chart-needs-golden
+chart_needs_template_reverse=${tmp}/chart.needs.template.log
+chart_needs_lint_reverse=${tmp}/chart.needs.lint.log
+chart_needs_diff_reverse=${tmp}/chart.needs.diff.log
+
+test_start "chart prepare when helmfile template with needs"
+
+info "https://github.com/helmfile/helmfile/issues/455"
+
+for i in $(seq 10); do
+    info "Comparing template/chart-needs #$i"
+    ${helmfile} -f ${dir}/issue.455/helmfile.yaml template --include-needs > ${chart_needs_template_reverse} || fail "\"helmfile template\" shouldn't fail"
+    ./yamldiff ${chart_needs_golden_dir}/template ${chart_needs_template_reverse} || fail "\"helmfile template\" should be consistent"
+    echo code=$?
+done
+
+for i in $(seq 10); do
+    info "Comparing lint/chart-needs #$i"
+    ${helmfile_no_extra_flags} -f ${dir}/issue.455/helmfile.yaml lint --include-needs | grep -v Linting > ${chart_needs_lint_reverse} || fail "\"helmfile lint\" shouldn't fail"
+    diff -u ${chart_needs_golden_dir}/lint ${chart_needs_lint_reverse} || fail "\"helmfile lint\" should be consistent"
+    echo code=$?
+done
+
+for i in $(seq 10); do
+    info "Comparing diff/chart-needs #$i"
+    ${helmfile_no_extra_flags} -f ${dir}/issue.455/helmfile.yaml diff --include-needs | grep -Ev "Comparing release=azuredisk-csi-storageclass, chart=/tmp/[0-9a-zA-Z]+/azuredisk-csi-storageclass" | grep -v "$test_ns" > ${chart_needs_diff_reverse} || fail "\"helmfile diff\" shouldn't fail"
+    diff -u ${chart_needs_golden_dir}/diff ${chart_needs_diff_reverse} || fail "\"helmfile diff\" should be consistent"
+    echo code=$?
+done
+
+info "Applying ${dir}/issue.455/helmfile.yaml"
+${helmfile} -f ${dir}/issue.455/helmfile.yaml  apply --include-needs
+code=$?
+[ ${code} -eq 0 ] || fail "unexpected exit code returned by helmfile apply: want 0, got ${code}"
+
+${kubectl} get storageclass managed-csi -o yaml | grep -q "provisioner: disk.csi.azure.com" || fail "storageclass managed-csi should be created when applying helmfile.yaml"
+
+info "Destroying ${dir}/issue.455/helmfile.yaml"
+${helmfile} -f ${dir}/issue.455/helmfile.yaml destroy
+code=$?
+[ ${code} -eq 0 ] || fail "unexpected exit code returned by helmfile destroy: want 0, got ${code}"
+
+info "Syncing ${dir}/issue.455/helmfile.yaml"
+${helmfile} -f ${dir}/issue.455/helmfile.yaml  sync --include-needs
+code=$?
+[ ${code} -eq 0 ] || fail "unexpected exit code returned by helmfile apply: want 0, got ${code}"
+
+${kubectl} get storageclass managed-csi -o yaml | grep -q "provisioner: disk.csi.azure.com" || fail "storageclass managed-csi should be created when syncing helmfile.yaml"
+
+info "Destroying ${dir}/issue.455/helmfile.yaml"
+${helmfile} -f ${dir}/issue.455/helmfile.yaml destroy
+code=$?
+[ ${code} -eq 0 ] || fail "unexpected exit code returned by helmfile destroy: want 0, got ${code}"
+
+test_pass "chart prepare when helmfile template with needs"