Fix various golangci-lint errors (#2059)

This commit is contained in:
Anton Bretting
2022-02-12 20:28:08 +09:00
committed by GitHub
parent 9a2df3c0a2
commit 2f04831817
29 changed files with 362 additions and 263 deletions
+3 -3
View File
@@ -2,8 +2,9 @@ package argparser
import (
"fmt"
"github.com/roboll/helmfile/pkg/state"
"strings"
"github.com/roboll/helmfile/pkg/state"
)
type keyVal struct {
@@ -95,10 +96,9 @@ func GetArgs(args string, state *state.HelmState) []string {
argArr = append(argArr, fmt.Sprintf("%s=%s", obj.key, obj.val))
}
} else {
argArr = append(argArr, fmt.Sprintf("%s", obj.key))
argArr = append(argArr, obj.key)
}
}
}
state.HelmDefaults.Args = argArr
+3 -7
View File
@@ -1,9 +1,10 @@
package argparser
import (
"github.com/roboll/helmfile/pkg/state"
"strings"
"testing"
"github.com/roboll/helmfile/pkg/state"
)
func TestGetArgs(t *testing.T) {
@@ -44,10 +45,5 @@ func Test2(t *testing.T) {
}
func compareArgs(expectedArgs string, args []string) bool {
if strings.Compare(strings.Join(args, " "), expectedArgs) != 0 {
return false
}
return true
return strings.Compare(strings.Join(args, " "), expectedArgs) == 0
}