public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix capitalization of cleanup-on-fail config key (#1005) 

It is how `cleanupOnFail` to be consistent with other keys.

Ref #969
This commit is contained in:
KUOKA Yusuke 2019-11-29 09:29:26 +09:00 committed by GitHub
parent e745a2602b
commit 27c098c17c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
README.md
View File

@ -74,7 +74,7 @@ helmDefaults:
tillerNamespace: tiller-namespace #dedicated default key for tiller-namespace
tillerless: false #dedicated default key for tillerless
kubeContext: kube-context #dedicated default key for kube-context (--kube-context)
cleanup-on-fail: false #dedicated default key for helm flag --cleanup-on-fail
cleanupOnFail: false #dedicated default key for helm flag --cleanup-on-fail
# additional and global args passed to helm
args:
- "--set k=v"
@ -159,7 +159,7 @@ releases:
# restores previous state in case of failed release
atomic: true
# when true, cleans up any new resources created during a failed release
cleanup-on-fail: false
cleanupOnFail: false
# name of the tiller namespace
tillerNamespace: vault
# if true, will use the helm-tiller plugin

4
pkg/state/state.go
View File

@ -102,7 +102,7 @@ type HelmSpec struct {
// Atomic, when set to true, restore previous state in case of a failed install/upgrade attempt
Atomic bool `yaml:"atomic"`
// CleanupOnFail, when set to true, the --cleanup-on-fail helm flag is passed to the upgrade command
CleanupOnFail bool `yaml:"cleanup-on-fail,omitempty"`
CleanupOnFail bool `yaml:"cleanupOnFail,omitempty"`
TLS bool `yaml:"tls"`
TLSCACert string `yaml:"tlsCACert,omitempty"`
@ -142,7 +142,7 @@ type ReleaseSpec struct {
// Atomic, when set to true, restore previous state in case of a failed install/upgrade attempt
Atomic *bool `yaml:"atomic,omitempty"`
// CleanupOnFail, when set to true, the --cleanup-on-fail helm flag is passed to the upgrade command
CleanupOnFail *bool `yaml:"cleanup-on-fail,omitempty"`
CleanupOnFail *bool `yaml:"cleanupOnFail,omitempty"`
// MissingFileHandler is set to either "Error" or "Warn". "Error" instructs helmfile to fail when unable to find a values or secrets file. When "Warn", it prints the file and continues.
// The default value for MissingFileHandler is "Error".