From 2792ef75d1ff84d2a0f2db67a0594a555e431ee7 Mon Sep 17 00:00:00 2001 From: James Christian Date: Tue, 14 Sep 2021 06:51:22 +0100 Subject: [PATCH] bug: write-values deletes provided --values files. (#1905) This fixes the bug by not including provided values files in the array of generated values, which is evalutated in a defered block. Resolves #1904 --- pkg/state/state.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/state/state.go b/pkg/state/state.go index 3ca87a78..eb5291ab 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -1473,7 +1473,6 @@ func (st *HelmState) WriteReleasesValues(helm helmexec.Interface, additionalValu if _, err := os.Stat(valfile); os.IsNotExist(err) { return []error{err} } - generatedFiles = append(generatedFiles, valfile) } outputValuesFile, err := st.GenerateOutputFilePath(release, opts.OutputFileTemplate) @@ -1489,7 +1488,7 @@ func (st *HelmState) WriteReleasesValues(helm helmexec.Interface, additionalValu merged := map[string]interface{}{} - for _, f := range generatedFiles { + for _, f := range append(generatedFiles, additionalValues...) { src := map[string]interface{}{} srcBytes, err := st.readFile(f)