From 2214b0ff8c83efcbf0df4036b87e33015a7fb1cd Mon Sep 17 00:00:00 2001 From: yxxhero Date: Wed, 11 Mar 2026 20:17:59 +0800 Subject: [PATCH] refactor: check ops nil before Helm version in appendHideNotesFlags - Swap the order to check ops == nil first to avoid unnecessary IsVersionAtLeast call - Restore the "see Helm release" comment for consistency with other flag helpers Signed-off-by: yxxhero --- pkg/state/helmx.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/state/helmx.go b/pkg/state/helmx.go index d23dfce1..988afc08 100644 --- a/pkg/state/helmx.go +++ b/pkg/state/helmx.go @@ -257,10 +257,11 @@ func (st *HelmState) appendCascadeFlags(flags []string, helm helmexec.Interface, // append hide-notes flags to helm flags func (st *HelmState) appendHideNotesFlags(flags []string, helm helmexec.Interface, ops *SyncOpts) []string { - if !helm.IsVersionAtLeast("3.16.0") { + if ops == nil { return flags } - if ops == nil { + // see https://github.com/helm/helm/releases/tag/v3.16.0 + if !helm.IsVersionAtLeast("3.16.0") { return flags } switch {