public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add experimental "forceNamespace" in helmfile.yaml (#1444) 

This is an experimental feature to support a potential use-case that you need to set namespaces in manifests rendered by `helmfile template`, WHEN the chart is unconventional hence does not have `namespace: {{ .Namespace }}`.
Rather than using this, you should usually fork/maintain or update/pull-request the chart to have `namespace: {{ .Namespace }}`.
Use this only when you CAN NOT do so, but still need to use `helmfile template`.
This commit is contained in:
Yusuke Kuoka 2020-09-01 10:13:27 +09:00 committed by GitHub
parent cd0ecc5263
commit 19d79427a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/state/helmx.go
View File

@ -144,6 +144,10 @@ func (st *HelmState) PrepareChartify(helm helmexec.Interface, release *ReleaseSp
shouldRun = true shouldRun = true
} }
if release.ForceNamespace != "" {
chartify.Opts.OverrideNamespace = release.ForceNamespace
}
if shouldRun { if shouldRun {
generatedFiles, err := st.generateValuesFiles(helm, release, workerIndex) generatedFiles, err := st.generateValuesFiles(helm, release, workerIndex)
if err != nil { if err != nil {

7
pkg/state/state.go
View File

@ -253,6 +253,13 @@ type ReleaseSpec struct {
// Without this, any error in url parsing result in silently falling-back to normal process of treating `chart:` as the regular // Without this, any error in url parsing result in silently falling-back to normal process of treating `chart:` as the regular
// helm chart name. // helm chart name.
ForceGoGetter bool `yaml:"forceGoGetter,omitempty"` ForceGoGetter bool `yaml:"forceGoGetter,omitempty"`
// ForceNamespace is an experimental feature to set metadata.namespace in every K8s resource rendered by the chart,
// regardless of the template, even when it doesn't have `namespace: {{ .Namespace | quote }}`.
// This is only needed when you can't FIX your chart to have `namespace: {{ .Namespace }}` AND you're using `helmfile template`.
// In standard use-cases, `Namespace` should be sufficient.
// Use this only when you know what you want to do!
ForceNamespace string `yaml:"forceNamespace"`
} }
type Release struct { type Release struct {