public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: `installed: false` not respecting TLS settings and tiller namespace (#683) 

It was just missing the appendConnectionFlags call to compose flags passed to `helm delete` there. This fixes it.

Fixes #605
This commit is contained in:
KUOKA Yusuke 2019-06-12 19:07:31 +09:00 committed by GitHub
parent 2e38f42a40
commit 1831d3375f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/state/state.go
View File

@ -383,7 +383,8 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme
if err != nil { if err != nil {
relErr = newReleaseError(release, err) relErr = newReleaseError(release, err)
} else if installed { } else if installed {
if err := helm.DeleteRelease(context, release.Name, "--purge"); err != nil { deletionFlags := st.appendConnectionFlags([]string{"--purge"}, release)
if err := helm.DeleteRelease(context, release.Name, deletionFlags...); err != nil {
affectedReleases.Failed = append(affectedReleases.Failed, release) affectedReleases.Failed = append(affectedReleases.Failed, release)
relErr = newReleaseError(release, err) relErr = newReleaseError(release, err)
} else { } else {