From 0c688471ea90d3c93cf76e12ae84dadbb7adb035 Mon Sep 17 00:00:00 2001 From: Adam Blasko Date: Wed, 22 Jan 2025 23:12:30 +0100 Subject: [PATCH] fix: using correct option for takeOwnership flag Fixed test to correctly assert the new flag --- pkg/state/helmx.go | 2 +- pkg/state/helmx_test.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/state/helmx.go b/pkg/state/helmx.go index e03a095a..88e8e98a 100644 --- a/pkg/state/helmx.go +++ b/pkg/state/helmx.go @@ -155,7 +155,7 @@ func (st *HelmState) appendTakeOwnershipFlags(flags []string, helm helmexec.Inte return flags } switch { - case ops.HideNotes: + case ops.TakeOwnership: flags = append(flags, "--take-ownership") } return flags diff --git a/pkg/state/helmx_test.go b/pkg/state/helmx_test.go index 77e91203..c9cdc44f 100644 --- a/pkg/state/helmx_test.go +++ b/pkg/state/helmx_test.go @@ -340,18 +340,18 @@ func TestAppendTakeOwnershipFlags(t *testing.T) { flags: []string{}, helm: testutil.NewVersionHelmExec("3.16.0"), opt: &SyncOpts{ - HideNotes: true, + TakeOwnership: true, }, expected: []string{}, }, }, { - name: "hide-notes from cmd flag", + name: "take-ownership from cmd flag", args: args{ flags: []string{}, helm: testutil.NewVersionHelmExec("3.17.0"), opt: &SyncOpts{ - HideNotes: true, + TakeOwnership: true, }, expected: []string{"--take-ownership"}, },