fix: pre-build transitive subchart deps for envelope charts (#851)

mirror of https://github.com/helmfile/helmfile.git synced 2026-10-22 09:30:54 +02:00

Helm's `dependency build` on the parent chart fetches each file:// subchart
and packages it as .tgz, but does NOT recursively build the subchart's own
dependencies first. For envelope charts whose subcharts declare their own
local file:// dependencies, the resulting .tgz lacks the nested subchart's
resources. chartify's `helm template` then silently drops those resources,
and strategicMergePatches/jsonPatches targeting them fail with
"no resource matches".

Fix: add `preBuildTransitiveSubchartDeps`, called from processChartification
before chartify runs (gated on !skipDeps). It walks the transitive file://
dependency tree depth-first and runs `helm dependency build` bottom-up on each
subchart source directory, so each subchart's deps are pre-built before the
parent packages them. The function is best-effort: errors are logged at debug
level and do not abort the operation, matching helmfile's existing behavior
of tolerating already-built deps.

Verified with a reproduction case that fails before the fix
(`Error: no resource matches strategic merge patch ".../nested-sm.[noNs]"`)
and passes after it.

Resolves #851

Signed-off-by: yxxhero <aiopsclub@163.com>

This commit is contained in:

yxxhero

2026-07-02 06:37:50 +08:00

committed by

yxxhero

parent cc85562625

commit 08504ad6f6

14 changed files with 559 additions and 0 deletions

									
										test/integration/run.sh
									
		+1
		
												View File
												
				@@ -132,6 +132,7 @@ ${kubectl} create namespace ${test_ns} || fail "Could not create namespace ${tes

				. ${dir}/test-cases/issue-2247.sh

				. ${dir}/test-cases/issue-2097.sh

				. ${dir}/test-cases/issue-2291.sh

				. ${dir}/test-cases/issue-851.sh

				. ${dir}/test-cases/oci-parallel-pull.sh

				. ${dir}/test-cases/issue-2297-local-chart-transformers.sh

				. ${dir}/test-cases/issue-2309-kube-context-template.sh