From 01cfc7aa72c7fe70ee914876506a477e487afa7f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 20 May 2026 04:16:44 +0000 Subject: [PATCH] test: address review feedback on defaultInherit tests Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/3ea9b8e4-633f-43c4-899f-e063ec576486 Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com> --- pkg/app/app_template_test.go | 6 +++--- pkg/state/state_exec_tmpl_test.go | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/app/app_template_test.go b/pkg/app/app_template_test.go index 8c74f744..c468c22d 100644 --- a/pkg/app/app_template_test.go +++ b/pkg/app/app_template_test.go @@ -646,11 +646,11 @@ func TestTemplate_DefaultInherit_Multiple(t *testing.T) { templates: ns: namespace: from-ns-template - ctx: + override: namespace: from-ctx-template defaultInherit: - ns - - ctx + - override releases: - name: app1 chart: incubator/raw @@ -688,7 +688,7 @@ releases: }) } - t.Run("multiple default inherits are applied", func(t *testing.T) { + t.Run("multiple default inherits are applied in order", func(t *testing.T) { check(t, testcase{ templated: []exectest.Release{ {Name: "app1", Flags: []string{"--kube-context", "default", "--namespace", "from-ctx-template"}}, diff --git a/pkg/state/state_exec_tmpl_test.go b/pkg/state/state_exec_tmpl_test.go index f26fc555..92ec36df 100644 --- a/pkg/state/state_exec_tmpl_test.go +++ b/pkg/state/state_exec_tmpl_test.go @@ -476,10 +476,10 @@ func TestDefaultInherits_UnmarshalYAML(t *testing.T) { }, } - for _, yamlV3 := range []bool{true, false} { - t.Run(fmt.Sprintf("GoYamlV3=%t", yamlV3), func(t *testing.T) { + for _, enableGoYamlV3 := range []bool{true, false} { + t.Run(fmt.Sprintf("GoYamlV3=%t", enableGoYamlV3), func(t *testing.T) { prev := runtime.GoYamlV3 - runtime.GoYamlV3 = yamlV3 + runtime.GoYamlV3 = enableGoYamlV3 defer func() { runtime.GoYamlV3 = prev }()