public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: remove always-constant basePath param from newTestHelmStateWithFiles to fix unparam lint error 

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/b4a669cb-692c-4ca6-a68b-1b04a062b989

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-04-27 00:46:55 +00:00 committed by GitHub
parent c66017c266
commit 01838037b9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
pkg/state/create_test.go
View File

@ -1097,8 +1097,9 @@ func TestMergedReleaseTemplateData_InlineValues(t *testing.T) {
}
}
func newTestHelmStateWithFiles(t *testing.T, files map[string]string, basePath string) *HelmState {
func newTestHelmStateWithFiles(t *testing.T, files map[string]string) *HelmState {
t.Helper()
const basePath = "/project"
logger := zaptest.NewLogger(t).Sugar()
valsRuntime, err := vals.New(vals.Options{CacheSize: 32})
require.NoError(t, err)
@ -1117,7 +1118,7 @@ func newTestHelmStateWithFiles(t *testing.T, files map[string]string, basePath s
}
func TestResolveReleaseValues_Empty(t *testing.T) {
st := newTestHelmStateWithFiles(t, map[string]string{}, "/project")
st := newTestHelmStateWithFiles(t, map[string]string{})
release := &ReleaseSpec{Name: "myrelease", Chart: "mychart"}
result, err := st.resolveReleaseValues(release)
@ -1134,7 +1135,7 @@ image:
`
st := newTestHelmStateWithFiles(t, map[string]string{
valuesFile: valuesContent,
}, "/project")
})
release := &ReleaseSpec{
Name: "myrelease",
@ -1152,7 +1153,7 @@ image:
}
func TestResolveReleaseValues_InlineMap(t *testing.T) {
st := newTestHelmStateWithFiles(t, map[string]string{}, "/project")
st := newTestHelmStateWithFiles(t, map[string]string{})
release := &ReleaseSpec{
Name: "myrelease",
@ -1189,7 +1190,7 @@ ingress:
st := newTestHelmStateWithFiles(t, map[string]string{
baseValuesFile: baseValuesContent,
overrideValuesFile: overrideValuesContent,
}, "/project")
})
release := &ReleaseSpec{
Name: "myrelease",
@ -1219,7 +1220,7 @@ func TestResolveReleaseValues_FileAndInlineMerged(t *testing.T) {
`
st := newTestHelmStateWithFiles(t, map[string]string{
valuesFile: valuesContent,
}, "/project")
})
release := &ReleaseSpec{
Name: "myrelease",
@ -1245,7 +1246,7 @@ image:
`
st := newTestHelmStateWithFiles(t, map[string]string{
valuesFile: valuesContent,
}, "/project")
})
release := &ReleaseSpec{Name: "myrelease", Chart: "mychart"}
tmplData := st.createReleaseTemplateData(release, map[string]any{})
@ -1263,7 +1264,7 @@ enabled: {{ .Values.ingress.enabled }}
`
st := newTestHelmStateWithFiles(t, map[string]string{
valuesFile: valuesContent,
}, "/project")
})
release := &ReleaseSpec{Name: "myrelease", Chart: "mychart"}
tmplData := st.createReleaseTemplateData(release, map[string]any{
@ -1286,7 +1287,7 @@ releaseNamespace: {{ .Release.Namespace }}
`
st := newTestHelmStateWithFiles(t, map[string]string{
valuesFile: valuesContent,
}, "/project")
})
release := &ReleaseSpec{Name: "myapp", Chart: "mychart", Namespace: "production"}
tmplData := st.createReleaseTemplateData(release, map[string]any{})
@ -1304,7 +1305,7 @@ host: {{ .Values.ingress.host }}
`
st := newTestHelmStateWithFiles(t, map[string]string{
patchFile: patchContent,
}, "/project")
})
release := &ReleaseSpec{Name: "myrelease", Chart: "mychart"}
tmplData := st.createReleaseTemplateData(release, map[string]any{
@ -1330,7 +1331,7 @@ host: {{ .Values.ingress.host }}
}
func TestGenerateTemporaryReleaseValuesFilesWithData_InlineMap(t *testing.T) {
st := newTestHelmStateWithFiles(t, map[string]string{}, "/project")
st := newTestHelmStateWithFiles(t, map[string]string{})
release := &ReleaseSpec{Name: "myrelease", Chart: "mychart"}
tmplData := st.createReleaseTemplateData(release, map[string]any{})
@ -1358,7 +1359,7 @@ func TestGenerateTemporaryReleaseValuesFilesWithData_InlineMap(t *testing.T) {
}
func TestGenerateTemporaryReleaseValuesFilesWithData_UnknownTypeError(t *testing.T) {
st := newTestHelmStateWithFiles(t, map[string]string{}, "/project")
st := newTestHelmStateWithFiles(t, map[string]string{})
release := &ReleaseSpec{Name: "myrelease", Chart: "mychart"}
tmplData := st.createReleaseTemplateData(release, map[string]any{})