--- pvemanagerlib-5.3-5.js 2018-12-03 06:13:25.000000000 -0500 +++ pvemanagerlib.js 2018-12-12 07:51:20.483169368 -0500 @@ -5854,6 +5854,7 @@ alias: ['widget.pveiScsiProviderSelector'], comboItems: [ ['comstar', 'Comstar'], + ['freenas', 'FreeNAS-API'], [ 'istgt', 'istgt'], [ 'iet', 'IET'], [ 'LIO', 'LIO'] @@ -29983,6 +29984,7 @@ data: { isLIO: false, isComstar: true, + isFreeNAS: false, hasWriteCacheOption: true } }, @@ -29995,10 +29997,19 @@ } }, changeISCSIProvider: function(f, newVal, oldVal) { + var me = this; var vm = this.getViewModel(); vm.set('isLIO', newVal === 'LIO'); vm.set('isComstar', newVal === 'comstar'); - vm.set('hasWriteCacheOption', newVal === 'comstar' || newVal === 'istgt'); + vm.set('isFreeNAS', newVal === 'freenas'); + vm.set('hasWriteCacheOption', newVal === 'comstar' || newVal === 'freenas' || newVal === 'istgt'); + if (newVal !== 'freenas') { + me.lookupReference('freenas_use_ssl_field').setValue(false); + me.lookupReference('freenas_apiv4_host_field').setValue(''); + me.lookupReference('freenas_user_field').setValue(''); + me.lookupReference('freenas_password_field').setValue(''); + me.lookupReference('freenas_confirmpw_field').setValue(''); + } } }, @@ -30016,6 +30027,7 @@ }, setValues: function diff(values) { + values.freenas_confirmpw = values.freenas_password; values.writecache = values.nowritecache ? 0 : 1; this.callParent([values]); }, @@ -30032,7 +30044,7 @@ allowBlank: false }, { - xtype: me.isCreate ? 'textfield' : 'displayfield', + xtype: 'textfield', name: 'pool', value: '', fieldLabel: gettext('Pool'), @@ -30046,7 +30058,7 @@ allowBlank: false }, { - xtype: me.isCreate ? 'textfield' : 'displayfield', + xtype: 'textfield', name: 'target', value: '', fieldLabel: gettext('Target'), @@ -30057,8 +30069,28 @@ name: 'comstar_tg', value: '', fieldLabel: gettext('Target group'), - bind: me.isCreate ? { disabled: '{!isComstar}' } : { hidden: '{!isComstar}' }, + bind: { hidden: '{!isComstar}' }, allowBlank: true + }, + { + xtype: 'proxmoxcheckbox', + name: 'freenas_use_ssl', + reference: 'freenas_use_ssl_field', + inputId: 'freenas_use_ssl_field', + checked: false, + bind: { hidden: '{!isFreeNAS}' }, + uncheckedValue: 0, + fieldLabel: gettext('API use SSL') + }, + { + xtype: 'textfield', + name: 'freenas_user', + reference: 'freenas_user_field', + inputId: 'freenas_user_field', + value: '', + allowBlank: false, + fieldLabel: gettext('API Username'), + bind: { hidden: '{!isFreeNAS}' }, } ]; @@ -30089,7 +30121,7 @@ xtype: me.isCreate ? 'textfield' : 'displayfield', name: 'comstar_hg', value: '', - bind: me.isCreate ? { disabled: '{!isComstar}' } : { hidden: '{!isComstar}' }, + bind: { hidden: '{!isComstar}' }, fieldLabel: gettext('Host group'), allowBlank: true }, @@ -30097,9 +30129,60 @@ xtype: me.isCreate ? 'textfield' : 'displayfield', name: 'lio_tpg', value: '', - bind: me.isCreate ? { disabled: '{!isLIO}' } : { hidden: '{!isLIO}' }, + bind: { hidden: '{!isLIO}' }, + fieldLabel: gettext('Target portal group'), + allowBlank: true + }, + { + xtype: 'proxmoxtextfield', + name: 'freenas_apiv4_host', + reference: 'freenas_apiv4_host_field', + value: '', + editable: true, + allowBlank: true, + emptyText: Proxmox.Utils.noneText, + bind: { hidden: '{!isFreeNAS}' }, + fieldLabel: gettext('API IPv4 Host'), + allowBlank: true + }, + { + xtype: 'proxmoxtextfield', + name: 'freenas_password', + reference: 'freenas_password_field', + inputType: me.isCreate ? '' : 'password', + value: '', + editable: true, + deleteEmpty: true, + allowBlank: false, + emptyText: Proxmox.Utils.noneText, + bind: { hidden: '{!isFreeNAS}' }, + fieldLabel: gettext('API Password'), + change: function(f, value) { + if (f.rendered) { + f.up().down('field[name=freenas_confirmpw]').validate(); + } + } + }, + { + xtype: 'proxmoxtextfield', + name: 'freenas_confirmpw', + reference: 'freenas_confirmpw_field', + inputType: me.isCreate ? '' : 'password', + value: '', + editable: true, + deleteEmpty: true, allowBlank: false, - fieldLabel: gettext('Target portal group') + submitValue: false, + emptyText: Proxmox.Utils.noneText, + bind: { hidden: '{!isFreeNAS}' }, + fieldLabel: gettext('Confirm Password'), + validator: function(value) { + var pw = this.up().down('field[name=freenas_password]').getValue(); + if (pw !== value) { + return "Passwords do not match!"; + } + return true; + } } ];