Fix CI workflow file issues causing no-jobs-run failure

Two bugs that prevented any jobs from running:

1. action.yml contained only YAML comments (no 'on:' or 'jobs:' keys),
   making it an invalid workflow file. GitHub rejected it at parse time.
   Fixed by giving it a minimal valid structure with workflow_dispatch
   trigger only, so it never fires automatically.

2. build.yml perlcritic step referenced perl5/PVE/Storage/Custom/FreeNAS.pm
   which is not committed to the repository, causing a step failure.
   Removed — only FreeNAS.pm (LunCmd) is linted for now.

3. build.yml publish job used 'if: |' block scalar for a multi-line
   expression, which GitHub Actions rejects in expression position.
   Changed to a single inline expression string.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Kevin Adams
2026-05-15 14:52:17 -04:00
co-authored by Claude Sonnet 4.6
parent 636cd06ff6
commit ba238eb7d6
2 changed files with 15 additions and 9 deletions
+13 -4
View File
@@ -1,4 +1,13 @@
# This workflow has been superseded by build.yml
# It previously dispatched to the external freenas-proxmox-packer repository.
# The build pipeline now lives entirely in build.yml in this repository.
# This file is kept only to avoid breaking any external references; it does nothing.
# This workflow has been superseded by build.yml.
# It is retained only so that any external links to this file do not 404.
# It will never trigger automatically.
name: Deprecated (superseded by build.yml)
on:
workflow_dispatch:
jobs:
noop:
runs-on: ubuntu-latest
steps:
- run: echo "This workflow is deprecated. The active CI pipeline is build.yml."
+2 -5
View File
@@ -39,8 +39,7 @@ jobs:
run: |
echo "==> Running perlcritic..."
perlcritic --profile .perlcriticrc \
perl5/PVE/Storage/LunCmd/FreeNAS.pm \
perl5/PVE/Storage/Custom/FreeNAS.pm
perl5/PVE/Storage/LunCmd/FreeNAS.pm
- name: Shell script lint (shellcheck)
run: |
@@ -266,9 +265,7 @@ jobs:
runs-on: ubuntu-latest
needs: [build, security]
# Only publish on direct pushes (not PRs) to tracked branches or tags
if: |
github.event_name == 'push' &&
needs.build.outputs.channel != 'none'
if: github.event_name == 'push' && needs.build.outputs.channel != 'none'
steps:
- uses: actions/checkout@v4