public_git
/
freenas-proxmox
mirror of https://github.com/TheGrandWazoo/freenas-proxmox.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Undef $iscsi_lunid in FreeNAS.pm on line 457 

- The perl code was creating a new variable in the ‘if’ code block by
using 'my' at the beginning of the assignment at line 452. Once the code
exited this block that variable was released and now defaulted to the
main block variable at line 441 which is still set to 'undef'. Removing
the 'my' from the assignment line allowed the code to use the main block
$iscsi_lunid variable.

Fixes issue #7
This commit is contained in:
Kevin Scott Adams 2018-07-09 15:38:54 -04:00
parent 23990fc008
commit a29328e7fa
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
perl5/PVE/Storage/LunCmd/FreeNAS.pm
View File

@ -449,7 +449,7 @@ sub freenas_list_lu {
foreach my $node (@$extents) { foreach my $node (@$extents) {
if($node->{'id'} == $item->{'iscsi_extent'}) { if($node->{'id'} == $item->{'iscsi_extent'}) {
if ($item->{'iscsi_lunid'} =~ /(\d+)/) { if ($item->{'iscsi_lunid'} =~ /(\d+)/) {
my $iscsi_lunid = "$1"; $iscsi_lunid = "$1";
} else { } else {
syslog("info", "FreeNAS::API::freenas_list_lu : iscsi_lunid did not pass tainted testing"); syslog("info", "FreeNAS::API::freenas_list_lu : iscsi_lunid did not pass tainted testing");
next; next;