public_git
/
freenas-proxmox
mirror of https://github.com/TheGrandWazoo/freenas-proxmox.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

docs: add removal instructions for qemu_blockdev_options override (#266) 

When Proxmox fixes PVE::Storage::Plugin to use int($3) for the iscsi lun
field, this override becomes redundant. The comment now includes the exact
grep command to verify the upstream fix and confirms when removal is safe.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Kevin Adams 2026-05-31 23:05:17 -04:00
parent b1423a9d72
commit 84d459da02
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
perl5/PVE/Storage/Custom/TrueNAS.pm
View File

@ -628,6 +628,9 @@ sub path {
# integer. PVE::Storage::Plugin does lun => "$3" (string capture from the # integer. PVE::Storage::Plugin does lun => "$3" (string capture from the
# iscsi:// URL regex) which QEMU 9's strict blockdev schema rejects. We build # iscsi:// URL regex) which QEMU 9's strict blockdev schema rejects. We build
# the hash directly from _find_extent so the value is always an IV. (#266) # the hash directly from _find_extent so the value is always an IV. (#266)
# REMOVE this override once Proxmox fixes Plugin.pm to use int($3) — verify by
# checking pve-storage changelog for an iscsi lun integer fix, then confirm
# "grep 'lun =>' /usr/share/perl5/PVE/Storage/Plugin.pm" no longer quotes $3.
sub qemu_blockdev_options { sub qemu_blockdev_options {
my ($class, $scfg, $storeid, $volname, $machine_version, $options) = @_; my ($class, $scfg, $storeid, $volname, $machine_version, $options) = @_;
_resolve_token($storeid, $scfg); _resolve_token($storeid, $scfg);