public_git
/
freenas-proxmox
mirror of https://github.com/TheGrandWazoo/freenas-proxmox.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix dangling extent on failed LUN creation (issue #214) 

Fix dangling extent on failed LUN creation (issue #214)
This commit is contained in:
Kevin Scott Adams 2026-05-18 17:14:12 -04:00 committed by GitHub
parent b44c989638 af737128d2
commit 4edd50b300
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
perl5/PVE/Storage/LunCmd/FreeNAS.pm
View File

@ -263,16 +263,18 @@ sub run_create_lu {
# Create the extent # Create the extent
my $extent = freenas_iscsi_create_extent($scfg, $lun_path); my $extent = freenas_iscsi_create_extent($scfg, $lun_path);
die "Unable to create extent for $lun_path" if !defined($extent);
# Associate the new extent to the target # Associate the new extent to the target; roll back the extent if this fails
# to avoid leaving a dangling extent on TrueNAS (issue #214)
my $link = freenas_iscsi_create_target_to_extent($scfg, $target_id, $extent->{'id'}, $lun_id); my $link = freenas_iscsi_create_target_to_extent($scfg, $target_id, $extent->{'id'}, $lun_id);
if (!defined($link)) {
if (defined($link)) { syslog("err", (caller(0))[3] . " : target-to-extent failed for $lun_path -- rolling back extent $extent->{'id'}");
syslog("info","FreeNAS::create_lu(lun_path=$lun_path, lun_id=$lun_id) : successful"); freenas_iscsi_remove_extent($scfg, $extent->{'id'});
} else { die "Unable to create lun $lun_path (extent rolled back)";
die "Unable to create lun $lun_path";
} }
syslog("info", (caller(0))[3] . "(lun_path=$lun_path, lun_id=$lun_id) : successful");
return ""; return "";
} }