public_git
/
freenas-proxmox
mirror of https://github.com/TheGrandWazoo/freenas-proxmox.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix regex operator precedence bug in freenas_api_call method guard 

'! $method =~ /pattern/' is parsed as '(! $method) =~ /pattern/' due to
precedence, so the regex ran against "" and always returned false. The
guard never fired and any method string passed through to the API call.

Changed to '$method !~ /^(?:GET|DELETE|POST)$/' which correctly tests the
method string. Also replaced atomic group (?>...) with non-capturing (?:...)
since there is no backtracking concern here.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Kevin Adams 2026-05-15 14:27:02 -04:00
parent 43a8efd125
commit 4c38b5732e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
perl5/PVE/Storage/LunCmd/FreeNAS.pm
View File

@ -464,7 +464,7 @@ sub freenas_api_call {
syslog("info", (caller(0))[3] . " : called for host '" . $apihost . "'"); syslog("info", (caller(0))[3] . " : called for host '" . $apihost . "'");
$method = uc($method); $method = uc($method);
if (! $method =~ /^(?>GET|DELETE|POST)$/) { if ($method !~ /^(?:GET|DELETE|POST)$/) {
syslog("info", (caller(0))[3] . " : Invalid HTTP RESTful service method '$method'"); syslog("info", (caller(0))[3] . " : Invalid HTTP RESTful service method '$method'");
die "Invalid HTTP RESTful service method '$method' used."; die "Invalid HTTP RESTful service method '$method' used.";
} }