public_git
/
democratic-csi
mirror of https://github.com/democratic-csi/democratic-csi.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(freenas-api): Cast capacity values to Number for TrueNAS 25.x compatibility 

TrueNAS 25.x introduced stricter Pydantic validation for API inputs.
The refquota, refreservation, and volsize properties now require
strict integer types.

This wraps capacity_bytes in Number() to ensure proper type conversion
before sending to the TrueNAS API.

Fixes provisioning failures with error:
{"data.refquota.constrained-int":[{"message":"Input should be a valid integer"}]}
This commit is contained in:
Alan Sandoval 2026-01-06 22:13:31 -06:00
parent 8a4a28a87f
commit c0971ff4c2
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/driver/freenas/api.js
View File

@ -2809,15 +2809,16 @@ class FreeNASApiDriver extends CsiBaseDriver {
switch (driverZfsResourceType) {
case "filesystem":
// set quota
// Note: TrueNAS 25.x requires strict integer types for refquota/refreservation
if (this.options.zfs.datasetEnableQuotas) {
setProps = true;
properties.refquota = capacity_bytes;
properties.refquota = Number(capacity_bytes);
}
// set reserve
if (this.options.zfs.datasetEnableReservation) {
setProps = true;
properties.refreservation = capacity_bytes;
properties.refreservation = Number(capacity_bytes);
}
// quota for dataset and all children
@ -3211,19 +3212,20 @@ class FreeNASApiDriver extends CsiBaseDriver {
switch (driverZfsResourceType) {
case "filesystem":
// set quota
// Note: TrueNAS 25.x requires strict integer types for refquota/refreservation
if (this.options.zfs.datasetEnableQuotas) {
setProps = true;
properties.refquota = capacity_bytes;
properties.refquota = Number(capacity_bytes);
}
// set reserve
if (this.options.zfs.datasetEnableReservation) {
setProps = true;
properties.refreservation = capacity_bytes;
properties.refreservation = Number(capacity_bytes);
}
break;
case "volume":
properties.volsize = capacity_bytes;
properties.volsize = Number(capacity_bytes);
setProps = true;
// managed automatically for zvols