Merge pull request #37 from democratic-csi/next

Next

README.md

@@ -1,3 +1,6 @@
+![Image](https://img.shields.io/docker/pulls/democraticcsi/democratic-csi.svg)
+![Image](https://img.shields.io/github/workflow/status/democratic-csi/democratic-csi/CI?style=flat-square)
+
 # Introduction
 
 `democratic-csi` implements the `csi` (container storage interface) spec
@@ -29,8 +32,8 @@ relatively easy to implement new drivers.
 
 Predominantly 3 things are needed:
 
-- node prep
+- node prep (ie: your kubernetes cluster nodes)
-- server prep
+- server prep (ie: your storage server)
 - deploy the driver into the cluster (`helm` chart provided with sample
   `values.yaml`)
 
@@ -150,8 +153,9 @@ zfs-nfs democratic-csi/democratic-csi
 
 ### A note on non standard kubelet paths
 
-Some distrobutions, such as `minikube` and `microk8s` uses a non-standard kubelet path.
+Some distrobutions, such as `minikube` and `microk8s` use a non-standard
-In such cases it is necessary to provide a new kubelet host path, microk8s example below:
+kubelet path. In such cases it is necessary to provide a new kubelet host path,
+microk8s example below:
 
 ```bash
 microk8s helm upgrade \
@@ -162,6 +166,20 @@ microk8s helm upgrade \
   zfs-nfs democratic-csi/democratic-csi
 ```
 
+### openshift
+
+`democratic-csi` generally works fine with openshift. Some special parameters
+need to be set with helm (support added in chart version `0.6.1`):
+
+```
+# for sure required
+--set node.rbac.openshift.privileged=true
+--set node.driver.localtimeHostPath=false
+
+# unlikely, but in special circumstances may be required
+--set controller.rbac.openshift.privileged=true
+```
+
 ## Multiple Deployments
 
 You may install multiple deployments of each/any driver. It requires the following:

src/driver/freenas/index.js

@@ -1806,7 +1806,8 @@ class FreeNASDriver extends ControllerZfsSshBaseDriver {
         return versionInfo;
       }
     } catch (e) {
-      versionErrors.v2 = e;
+      // if more info is needed use e.stack
+      versionErrors.v2 = e.toString();
     }
 
     httpClient.setApiVersion(1);
@@ -1827,7 +1828,8 @@ class FreeNASDriver extends ControllerZfsSshBaseDriver {
         return versionInfo;
       }
     } catch (e) {
-      versionErrors.v1 = e;
+      // if more info is needed use e.stack
+      versionErrors.v1 = e.toString();
     }
 
     // throw error if cannot get v1 or v2 data