From 8273af765035867ef72dfb35cdedfe1a473cf747 Mon Sep 17 00:00:00 2001 From: Travis Glenn Hansen Date: Sat, 11 Dec 2021 18:30:21 -0700 Subject: [PATCH] remove unecessary copy process for snapshot list Signed-off-by: Travis Glenn Hansen --- src/driver/controller-zfs-ssh/index.js | 4 +--- src/driver/freenas/api.js | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/driver/controller-zfs-ssh/index.js b/src/driver/controller-zfs-ssh/index.js index 4ceee8a..2ce1a1e 100644 --- a/src/driver/controller-zfs-ssh/index.js +++ b/src/driver/controller-zfs-ssh/index.js @@ -1,4 +1,3 @@ -const _ = require("lodash"); const { CsiBaseDriver } = require("../index"); const SshClient = require("../../utils/ssh").SshClient; const { GrpcError, grpc } = require("../../utils/grpc"); @@ -1710,7 +1709,6 @@ class ControllerZfsSshBaseDriver extends CsiBaseDriver { } entries = this.ctx.cache.get(`ListSnapshots:result:${uuid}`); if (entries) { - entries = _.cloneDeep(entries); entries_length = entries.length; entries = entries.slice(start_position, end_position); if (max_entries > 0 && end_position > entries_length) { @@ -1918,7 +1916,7 @@ class ControllerZfsSshBaseDriver extends CsiBaseDriver { if (max_entries && entries.length > max_entries) { uuid = uuidv4(); - this.ctx.cache.set(`ListSnapshots:result:${uuid}`, _.cloneDeep(entries)); + this.ctx.cache.set(`ListSnapshots:result:${uuid}`, entries); next_token = `${uuid}:${max_entries}`; entries = entries.slice(0, max_entries); } diff --git a/src/driver/freenas/api.js b/src/driver/freenas/api.js index ca4228f..eb16c55 100644 --- a/src/driver/freenas/api.js +++ b/src/driver/freenas/api.js @@ -1,4 +1,3 @@ -const _ = require("lodash"); const { GrpcError, grpc } = require("../../utils/grpc"); const { CsiBaseDriver } = require("../index"); const HttpClient = require("./http").Client; @@ -3272,7 +3271,6 @@ class FreeNASApiDriver extends CsiBaseDriver { } entries = this.ctx.cache.get(`ListSnapshots:result:${uuid}`); if (entries) { - entries = _.cloneDeep(entries); entries_length = entries.length; entries = entries.slice(start_position, end_position); if (max_entries > 0 && end_position > entries_length) { @@ -3638,7 +3636,7 @@ class FreeNASApiDriver extends CsiBaseDriver { if (max_entries && entries.length > max_entries) { uuid = uuidv4(); - this.ctx.cache.set(`ListSnapshots:result:${uuid}`, _.cloneDeep(entries)); + this.ctx.cache.set(`ListSnapshots:result:${uuid}`, entries); next_token = `${uuid}:${max_entries}`; entries = entries.slice(0, max_entries); }