public_git
/
democratic-csi
mirror of https://github.com/democratic-csi/democratic-csi.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix cache timeout

This commit is contained in:
Danil Uzlov 2025-03-30 18:05:46 +00:00
parent df09678217
commit 7aeac628b8
1 changed files with 27 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/driver/controller-proxy/index.js
View File

@ -335,14 +335,26 @@ class DriverCache {
// We can delete drivers that weren't requested for a long time. // We can delete drivers that weren't requested for a long time.
// User can configure cache timeout so that driver re-creation is not too frequent. // User can configure cache timeout so that driver re-creation is not too frequent.
this.enableCacheTimeout = timeoutMinutes != -1; // TODO how do we make sure that cache timeout is bigger than RPC call duration?
if (this.enableCacheTimeout) { // If the driver has cleanup, it can break the call.
const oneMinuteInMs = 1000 * 60; // The smallest timeout is 1 minute.
this.cacheTimeoutMs = timeoutMinutes * oneMinuteInMs; // Any PRC SHOULD finish in this time, but it's possible that something hangs, or some storage backend is just slow.
this.ctx.logger.info(`driver cache timeout is ${timeoutMinutes} minutes`);
} else { const oneMinuteInMs = 1000 * 60;
this.cacheTimeoutMs = timeoutMinutes * oneMinuteInMs;
let cacheType = '';
if (timeoutMinutes === -1) {
this.ctx.logger.info("driver cache is disabled");
cacheType = 'force-create';
} else if (timeoutMinutes === 0) {
this.ctx.logger.info("driver cache is permanent"); this.ctx.logger.info("driver cache is permanent");
cacheType = 'permanent';
} else {
this.ctx.logger.info(`driver cache timeout is ${timeoutMinutes} minutes`);
cacheType = 'timeout';
} }
this.cacheType = cacheType;
} }
getCleanupHandlers() { getCleanupHandlers() {
@ -358,9 +370,14 @@ class DriverCache {
lookUpConnection(connectionName) { lookUpConnection(connectionName) {
const configPath = this.configFolder + '/' + connectionName + '.yaml'; const configPath = this.configFolder + '/' + connectionName + '.yaml';
if (this.timeout == 0) { if (this.cacheType == 'force-create') {
// when timeout is 0, force creating a new driver on each request // when timeout is 0, force creating a new driver on each request
return this.createDriverFromFile(configPath); const driver = this.createDriverFromFile(configPath);
const oneMinuteInMs = 1000 * 60;
setTimeout(() => {
this.runDriverCleanup(driver);
}, oneMinuteInMs);
return driver;
} }
let cachedDriver = this.driverCache[connectionName]; let cachedDriver = this.driverCache[connectionName];
@ -376,11 +393,11 @@ class DriverCache {
clearTimeout(cachedDriver.timer); clearTimeout(cachedDriver.timer);
cachedDriver.timer = null; cachedDriver.timer = null;
} }
if (this.enableCacheTimeout) { if (this.cacheType == 'timeout') {
cachedDriver.timer = setTimeout(() => { cachedDriver.timer = setTimeout(() => {
this.ctx.logger.info("removing inactive connection: %s", connectionName); this.ctx.logger.info("removing inactive connection: %s", connectionName);
this.removeCacheEntry(cachedDriver.driver); this.removeCacheEntry(cachedDriver.driver);
}, this.timeout); }, this.cacheTimeoutMs);
} }
const fileTime = this.getFileTime(configPath); const fileTime = this.getFileTime(configPath);